From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web11.6313.1634628215849767385 for ; Tue, 19 Oct 2021 00:23:35 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NTWDfJ3Y; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3BE0F61264 for ; Tue, 19 Oct 2021 07:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634628215; bh=TEUywPsE+1fNmHtsMpUpI0mFryOaO2r/c4DbjPDrPv8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NTWDfJ3YNbf9U7W90ryQ8PfyYFEc+Ky7FBdcjfk7qMClpMmZn03ayovecoLen9qPM tpwHPqpJVdGv0NG9eJMc92vxugUD3H3Bw+SEL2Ll03v41pFrjvqv0OXwXH3mYXCgmG uT3f7VxR3UfIqoeosb3ifgQ8su+pcvKsRb0DOzruTlVlc8pp752A3BVYIMZNzkJadX YkqdxRYTG3By89ydP3wTgauIyvSlXxnMYW5gojNqEcVMWUYEF8QG0Eipx1yoO2Q6Yi A8uHbC8mHKOZwOh0mtwT7VNvolGEZoJWsZeaakV8pFItpTDD9whga/kF06uj9JJ7gM EIfwgwTRefsVA== Received: by mail-oi1-f170.google.com with SMTP id o83so3547084oif.4 for ; Tue, 19 Oct 2021 00:23:35 -0700 (PDT) X-Gm-Message-State: AOAM530wYdDKsm8DoNA81AAjZHr/fhXBsadrj1Rd+7oTbNrZO8BvEZdC m/lZ9litrps/91sXKDKuQSeDx/cZBo4Qi+7bxfg= X-Google-Smtp-Source: ABdhPJzoTIodlXhc4ULoiQEAGvDtgbNYMzme7TtY8/bkrgYxMhzZgIL9ZCZBGcKH71rU0Ecsm0PIvwYeEq4F7ZB3pJw= X-Received: by 2002:a05:6808:1805:: with SMTP id bh5mr2856252oib.47.1634628214597; Tue, 19 Oct 2021 00:23:34 -0700 (PDT) MIME-Version: 1.0 References: <20211018205127.7099-1-jeremy.linton@arm.com> In-Reply-To: <20211018205127.7099-1-jeremy.linton@arm.com> From: "Ard Biesheuvel" Date: Tue, 19 Oct 2021 09:23:23 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/5] Platform/Rpi: Various cleanups + DT booting To: Jeremy Linton Cc: edk2-devel-groups-io , Peter Batard , Ard Biesheuvel , Leif Lindholm , Andrei Warkentin , Sunny Wang , Samer El-Haj-Mahmoud , Mark Kettenis , Jeremy Linton Content-Type: text/plain; charset="UTF-8" On Mon, 18 Oct 2021 at 22:51, Jeremy Linton wrote: > > From: Jeremy Linton > > This set is a few patches I've been collecting to fix minor issues I've seen > while debugging other problems, or just various things I think should probably > be changed. It also includes the patch to adjust the PCIe/XHCI dma-attributes > which fixes DT booting on recent Linux kernels as well as OpenBSD. > > I've been running all of them in some form or another for a while and > generally nothing has broken because of them AFAIK. So its probably time to > start getting a few of them out of my private tree. > > The first patch syncs the DT/PCIe translation to the way its being used in > UEFI, and removes the XHCI reset node. The second is just a compiler > warning. The third is mostly expanding the mailbox lock to cover the return > data. Number 4 is an odd one because it just looks wrong, and I'm worried its > causing random bugs. The final is a corrected shutdown sequence that was > discussed months ago. It looks right. but didn't actually fix the data > persistence problems that resulted in the couple second reboot delay that is > currently in place. > > v1->v2: > Include the DT patch to sync the PCIe/XHCI values > Now that it also fixes a problem with OpenBSD. > Rework the error handling in the DisconnectAll code > borrowed from the UEFI spec. > Adjust some DEBUG_XXX values so they make more sense. > Some comment/changelog grammar. > > Jeremy Linton (5): > Platform/RaspberryPi: Always use non translating DMA in DT mode > Platform/RaspberryPi: Fix vfr warning caused by two defaults > Platform/RaspberryPi: Expand locking to cover return data > Platform/RaspberryPi: Normal memory should not be marked as uncached > Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot > Pushed as dc7fe2ac2b74..63d520f9431a Thanks! > Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 4 +- > .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +- > Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c | 75 +++++++++++++++ > .../Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 102 ++++++++++++--------- > Platform/RaspberryPi/Library/ResetLib/ResetLib.c | 42 +++++++++ > 5 files changed, 179 insertions(+), 46 deletions(-) > > -- > 2.13.7 >