From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, michael.d.kinney@intel.com
Cc: Rebecca Cran <rebecca@bsdio.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Bob Feng <bob.c.feng@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [Patch 1/1] BaseTools/Scripts: Update PatchCheck.py Author checks
Date: Wed, 14 Feb 2024 17:13:23 +0100 [thread overview]
Message-ID: <CAMj1kXETnTbmD3M=7w3rMTgco4_SCBnyqcAOeUU2TvPHTM-t9Q@mail.gmail.com> (raw)
In-Reply-To: <20240213191753.1470-1-michael.d.kinney@intel.com>
On Tue, 13 Feb 2024 at 20:18, Michael D Kinney
<michael.d.kinney@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
>
> * Reject patches that match Author email "devel@edk2.groups.io"
> * Update the current check for " via Groups.Io" to perform a
> case insensitive match. It appears that groups.io has changed the
> format of this string to use all lower case.
>
> Cc: Rebecca Cran <rebecca@bsdio.com> [bcran]
> Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]
> Cc: Bob Feng <bob.c.feng@intel.com> [BobCF]
> Cc: Yuwei Chen <yuwei.chen@intel.com> [YuweiChen1110]
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> BaseTools/Scripts/PatchCheck.py | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck.py
> index 1675dcbd7321..e600e0be440f 100755
> --- a/BaseTools/Scripts/PatchCheck.py
> +++ b/BaseTools/Scripts/PatchCheck.py
> @@ -85,7 +85,11 @@ class EmailAddressCheck:
> self.error("The email address cannot contain a space: " +
> mo.group(3))
>
> - if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'):
> + if mo.group(3) == 'devel@edk2.groups.io':
> + self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
> + email)
> +
> + if ' via groups.io' in name.lower() and mo.group(3).endswith('@groups.io'):
> self.error("Email rewritten by lists DMARC / DKIM / SPF: " +
> email)
>
> --
> 2.40.1.windows.1
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115464): https://edk2.groups.io/g/devel/message/115464
Mute This Topic: https://groups.io/mt/104339266/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-02-14 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 19:17 [edk2-devel] [Patch 1/1] BaseTools/Scripts: Update PatchCheck.py Author checks Michael D Kinney
2024-02-14 15:02 ` Rebecca Cran
2024-02-14 16:13 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXETnTbmD3M=7w3rMTgco4_SCBnyqcAOeUU2TvPHTM-t9Q@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox