From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
Abner Chang <abner.chang@amd.com>,
Daniel Schaefer <git@danielschaefer.me>
Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI
Date: Thu, 15 Sep 2022 23:02:55 +0200 [thread overview]
Message-ID: <CAMj1kXEU9zNorzsnAFRAtnimsFJZdo36TAow9LOaHg6uzu9S6A@mail.gmail.com> (raw)
In-Reply-To: <CO1PR11MB4929B49BB802718E92F69F53D2499@CO1PR11MB4929.namprd11.prod.outlook.com>
On Thu, 15 Sept 2022 at 22:52, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
>
> Ard,
>
> Why would you want to do that? The whole point of CI is to establish a minimum quality level for all code in the project.
>
> They can be disabled with updates to the YAML file. Checks can be disabled completely and may of the checks support exception lists.
>
If the only way to prevent this from happening is to turn it off again
in the YAML file, I'd prefer not to turn it on to begin with.
I agree that code quality is important, but IMO the checks we have at
the moment are way too strict, and 90% of the time I spend on
reviewing and merging patches is on crustify and patchcheck errors.
This is simply not worth my time.
next prev parent reply other threads:[~2022-09-15 21:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 2:36 [PATCH v1 0/3] EmbeddedPkg: Enable CI Michael Kubacki
2022-09-07 2:36 ` [PATCH v1 1/3] EmbeddedPkg/AcpiLib: Fix code formatting errors Michael Kubacki
2022-09-07 2:36 ` [PATCH v1 2/3] EmbeddedPkg: Add CI YAML file Michael Kubacki
2022-09-07 2:36 ` [PATCH v1 3/3] EmbeddedPkg: Only run in CI for GCC5 Michael Kubacki
[not found] ` <1712738C00A60617.17907@groups.io>
2022-09-07 3:27 ` [edk2-devel] " Michael Kubacki
2022-09-09 1:37 ` Michael D Kinney
2022-09-07 7:37 ` [PATCH v1 0/3] EmbeddedPkg: Enable CI Ard Biesheuvel
2022-09-07 15:00 ` [edk2-devel] " Michael Kubacki
2022-09-07 15:16 ` Ard Biesheuvel
2022-09-15 19:46 ` Michael Kubacki
2022-09-15 20:47 ` Ard Biesheuvel
2022-09-15 20:51 ` Michael D Kinney
2022-09-15 21:02 ` Ard Biesheuvel [this message]
2022-09-15 21:54 ` Michael D Kinney
2022-09-23 1:09 ` Michael Kubacki
2022-09-23 11:47 ` Ard Biesheuvel
2022-09-23 15:30 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEU9zNorzsnAFRAtnimsFJZdo36TAow9LOaHg6uzu9S6A@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox