* [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date
@ 2023-03-09 9:02 Gerd Hoffmann
2023-03-09 9:19 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2023-03-09 9:02 UTC (permalink / raw)
To: devel
Cc: Jiewen Yao, Jordan Justen, Pawel Polawski, Gerd Hoffmann,
Oliver Steffen, Ard Biesheuvel, ruifeng.gao
In case PcdFirmwareReleaseDateString is not set use a valid date
as fallback. Using "unknown" makes Windows unhappy.
Fixes: 4cb94f20b002 ("OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*")
Reported-by: ruifeng.gao@intel.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
index dc1e6aed634f..0ca37760455c 100644
--- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
+++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
@@ -160,7 +160,7 @@ InstallAllStructures (
DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
DateLen = StrLen (DateStr);
if (DateLen < 3) {
- DateStr = L"unknown";
+ DateStr = L"2/2/2022";
DateLen = StrLen (DateStr);
}
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date
2023-03-09 9:02 [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date Gerd Hoffmann
@ 2023-03-09 9:19 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2023-03-09 9:19 UTC (permalink / raw)
To: devel, kraxel
Cc: Jiewen Yao, Jordan Justen, Pawel Polawski, Oliver Steffen,
Ard Biesheuvel, ruifeng.gao
On Thu, 9 Mar 2023 at 10:02, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> In case PcdFirmwareReleaseDateString is not set use a valid date
> as fallback. Using "unknown" makes Windows unhappy.
>
> Fixes: 4cb94f20b002 ("OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*")
> Reported-by: ruifeng.gao@intel.com
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Ack. Will queue this one up as well, thanks.
> ---
> OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> index dc1e6aed634f..0ca37760455c 100644
> --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> @@ -160,7 +160,7 @@ InstallAllStructures (
> DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString);
> DateLen = StrLen (DateStr);
> if (DateLen < 3) {
> - DateStr = L"unknown";
> + DateStr = L"2/2/2022";
> DateLen = StrLen (DateStr);
> }
>
> --
> 2.39.2
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-09 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-09 9:02 [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date Gerd Hoffmann
2023-03-09 9:19 ` [edk2-devel] " Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox