From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.9202.1678353609126114833 for ; Thu, 09 Mar 2023 01:20:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eHe4ItfI; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A44C261AB3 for ; Thu, 9 Mar 2023 09:20:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15924C433EF for ; Thu, 9 Mar 2023 09:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678353608; bh=D4C8hKkkejzkKkOKTGbJwof22RJHeermdnXXlzr/PWo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=eHe4ItfIkb/fa3dtOIVZNUfrMNc2ZlJObsnchy6TeS6BLn61/VbPhqkbc2dAl+XXG jPEub0lmhmmfPIxA52V71L4SC1S2f9ExhWTa2cdsvr25K04GSOVeT/Mtwtmb8Bve6z 95TXvHn8bqmX5somgBubFXEFPCwxT0NFUBiCO0B5d4YCVCGWDaCr0anRm+mZE4g29D m0LPlEDhJjM8Fl/9mzggh1tE7L9EgJwzg3zid2/WM8bqO9zFhcMchyOrQRgS7BrGjm XfWW0fjbchFUGnBYD3uuYJzH5JupiGymJO9oHdXab3cfkuvwKVokBoMOs4T1LfwRpQ TcdJKaSijjCEA== Received: by mail-lf1-f44.google.com with SMTP id g17so1430108lfv.4 for ; Thu, 09 Mar 2023 01:20:07 -0800 (PST) X-Gm-Message-State: AO0yUKURv1dw6c3ds+ltx+eLJZ8KVNy+uBkOemlsBV4FeHr5csLBsfjd Zdl9PA1Te+tOfVhmmnyyeRtZgNHcR2l3RlQJXtY= X-Google-Smtp-Source: AK7set/zrXvplFVtlA+eMO3Db1pao0XC5pL42qTKXQA2RuCEqq0yMriF4p26oWKv3EkLbRbNSHdGU6kwBNFPjbUKb4A= X-Received: by 2002:ac2:521c:0:b0:4dc:7fb0:1aca with SMTP id a28-20020ac2521c000000b004dc7fb01acamr6519847lfl.4.1678353606100; Thu, 09 Mar 2023 01:20:06 -0800 (PST) MIME-Version: 1.0 References: <20230309090207.404892-1-kraxel@redhat.com> In-Reply-To: <20230309090207.404892-1-kraxel@redhat.com> From: "Ard Biesheuvel" Date: Thu, 9 Mar 2023 10:19:54 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: tweak fallback release date To: devel@edk2.groups.io, kraxel@redhat.com Cc: Jiewen Yao , Jordan Justen , Pawel Polawski , Oliver Steffen , Ard Biesheuvel , ruifeng.gao@intel.com Content-Type: text/plain; charset="UTF-8" On Thu, 9 Mar 2023 at 10:02, Gerd Hoffmann wrote: > > In case PcdFirmwareReleaseDateString is not set use a valid date > as fallback. Using "unknown" makes Windows unhappy. > > Fixes: 4cb94f20b002 ("OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*") > Reported-by: ruifeng.gao@intel.com > Signed-off-by: Gerd Hoffmann Ack. Will queue this one up as well, thanks. > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index dc1e6aed634f..0ca37760455c 100644 > --- a/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -160,7 +160,7 @@ InstallAllStructures ( > DateStr = (CHAR16 *)FixedPcdGetPtr (PcdFirmwareReleaseDateString); > DateLen = StrLen (DateStr); > if (DateLen < 3) { > - DateStr = L"unknown"; > + DateStr = L"2/2/2022"; > DateLen = StrLen (DateStr); > } > > -- > 2.39.2 > > > > > >