From: "Ard Biesheuvel" <ardb@kernel.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Gerd Hoffmann <kraxel@redhat.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>
Subject: Re: [PATCH] OvmfPkg/PlatformInitLib: fix comment about uncacheable MTRRs
Date: Thu, 12 Jan 2023 11:20:13 +0100 [thread overview]
Message-ID: <CAMj1kXEW3K_Hrjsq0CwoP9bbd5NpzGH1A8x=gV5m-gTjwdNd+Q@mail.gmail.com> (raw)
In-Reply-To: <20230112074529.56500-1-lersek@redhat.com>
On Thu, 12 Jan 2023 at 08:45, Laszlo Ersek <lersek@redhat.com> wrote:
>
> In commit 49edde15230a ("OvmfPkg/PlatformPei: set 32-bit UC area at
> PciBase / PciExBarBase (pc/q35)", 2019-06-03), I forgot to update the
> comment. Do it now.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Fixes: 49edde15230a5bfd6746225eb95535eaa2ec1ba4
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Queued up as #3887
> ---
> OvmfPkg/Library/PlatformInitLib/MemDetect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> index 0c4956852689..882805269b3e 100644
> --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> @@ -968,7 +968,7 @@ PlatformQemuInitializeRam (
> //
> // We'd like to keep the following ranges uncached:
> // - [640 KB, 1 MB)
> - // - [LowerMemorySize, 4 GB)
> + // - [Uc32Base, 4 GB)
> //
> // Everything else should be WB. Unfortunately, programming the inverse (ie.
> // keeping the default UC, and configuring the complement set of the above as
prev parent reply other threads:[~2023-01-12 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 7:45 [PATCH] OvmfPkg/PlatformInitLib: fix comment about uncacheable MTRRs Laszlo Ersek
2023-01-12 10:20 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXEW3K_Hrjsq0CwoP9bbd5NpzGH1A8x=gV5m-gTjwdNd+Q@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox