From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web10.51422.1673518832228239568 for ; Thu, 12 Jan 2023 02:20:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mEfNgWWh; spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8DCC5CE1DD4 for ; Thu, 12 Jan 2023 10:20:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA15EC433F2 for ; Thu, 12 Jan 2023 10:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673518826; bh=MjoC8pLQpfetW86S8J78z/YfFEA2AtTDFLKfFT0pOQk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mEfNgWWhsD9kRYkM8wPmBBIsN6vHdNW0lps1oSCjPOFyA0VYJdsa24ARVB6otJaDb ah3IdlQ9XJvGo9Ke99FjIBFtVXQ8gCktk3y1B+hZ0wIpM2GPl7Hf2Zk/IKog3iAwQn lpj4Z9AXRtDHMcVMhtOIyjnZroApYzzSB0kLCSOFvrXy1gMAA5w5COpN/l0kYuUOoH KnVicCxThBBqt8PjJrhpcr80wSHMtMIWTntVQD23EhOIgBRvyuk3YnrYLbx0eLJurK BDxqd0GtjqDusnQUReuCzhXJG4y9gxc7b67LOGYNp3fpoSSVB+seFN2bXdBn+NW0tr wqdP+oxhERkxg== Received: by mail-lj1-f181.google.com with SMTP id o7so18466519ljj.8 for ; Thu, 12 Jan 2023 02:20:26 -0800 (PST) X-Gm-Message-State: AFqh2kp6EhBn05qH+coK1h4lQqLFxF7FIpE9ac1J9/uYyJOKiaElEQaI X76siLeNBVC0alPLdAoPMOLBtb6gq6InLUC28bo= X-Google-Smtp-Source: AMrXdXt+/A0cRhgg4+PXAUApqF1bs8Ugl28BKHlFvEPGs7z/OUwE8CCni0XR3H+doBjRCVoiXucGOilCMCBvM+FNrGU= X-Received: by 2002:a2e:96ce:0:b0:283:33fa:ee22 with SMTP id d14-20020a2e96ce000000b0028333faee22mr788200ljj.415.1673518824785; Thu, 12 Jan 2023 02:20:24 -0800 (PST) MIME-Version: 1.0 References: <20230112074529.56500-1-lersek@redhat.com> In-Reply-To: <20230112074529.56500-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Thu, 12 Jan 2023 11:20:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] OvmfPkg/PlatformInitLib: fix comment about uncacheable MTRRs To: Laszlo Ersek Cc: devel@edk2.groups.io, Ard Biesheuvel , Gerd Hoffmann , Jiewen Yao , Jordan Justen Content-Type: text/plain; charset="UTF-8" On Thu, 12 Jan 2023 at 08:45, Laszlo Ersek wrote: > > In commit 49edde15230a ("OvmfPkg/PlatformPei: set 32-bit UC area at > PciBase / PciExBarBase (pc/q35)", 2019-06-03), I forgot to update the > comment. Do it now. > > Cc: Ard Biesheuvel > Cc: Gerd Hoffmann > Cc: Jiewen Yao > Cc: Jordan Justen > Fixes: 49edde15230a5bfd6746225eb95535eaa2ec1ba4 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel Queued up as #3887 > --- > OvmfPkg/Library/PlatformInitLib/MemDetect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c > index 0c4956852689..882805269b3e 100644 > --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c > +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c > @@ -968,7 +968,7 @@ PlatformQemuInitializeRam ( > // > // We'd like to keep the following ranges uncached: > // - [640 KB, 1 MB) > - // - [LowerMemorySize, 4 GB) > + // - [Uc32Base, 4 GB) > // > // Everything else should be WB. Unfortunately, programming the inverse (ie. > // keeping the default UC, and configuring the complement set of the above as