* [PATCH] OvmfPkg/PlatformInitLib: fix comment about uncacheable MTRRs
@ 2023-01-12 7:45 Laszlo Ersek
2023-01-12 10:20 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Laszlo Ersek @ 2023-01-12 7:45 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Gerd Hoffmann, Jiewen Yao, Jordan Justen
In commit 49edde15230a ("OvmfPkg/PlatformPei: set 32-bit UC area at
PciBase / PciExBarBase (pc/q35)", 2019-06-03), I forgot to update the
comment. Do it now.
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Fixes: 49edde15230a5bfd6746225eb95535eaa2ec1ba4
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/Library/PlatformInitLib/MemDetect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
index 0c4956852689..882805269b3e 100644
--- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
+++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
@@ -968,7 +968,7 @@ PlatformQemuInitializeRam (
//
// We'd like to keep the following ranges uncached:
// - [640 KB, 1 MB)
- // - [LowerMemorySize, 4 GB)
+ // - [Uc32Base, 4 GB)
//
// Everything else should be WB. Unfortunately, programming the inverse (ie.
// keeping the default UC, and configuring the complement set of the above as
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] OvmfPkg/PlatformInitLib: fix comment about uncacheable MTRRs
2023-01-12 7:45 [PATCH] OvmfPkg/PlatformInitLib: fix comment about uncacheable MTRRs Laszlo Ersek
@ 2023-01-12 10:20 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2023-01-12 10:20 UTC (permalink / raw)
To: Laszlo Ersek
Cc: devel, Ard Biesheuvel, Gerd Hoffmann, Jiewen Yao, Jordan Justen
On Thu, 12 Jan 2023 at 08:45, Laszlo Ersek <lersek@redhat.com> wrote:
>
> In commit 49edde15230a ("OvmfPkg/PlatformPei: set 32-bit UC area at
> PciBase / PciExBarBase (pc/q35)", 2019-06-03), I forgot to update the
> comment. Do it now.
>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Fixes: 49edde15230a5bfd6746225eb95535eaa2ec1ba4
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Queued up as #3887
> ---
> OvmfPkg/Library/PlatformInitLib/MemDetect.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> index 0c4956852689..882805269b3e 100644
> --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> @@ -968,7 +968,7 @@ PlatformQemuInitializeRam (
> //
> // We'd like to keep the following ranges uncached:
> // - [640 KB, 1 MB)
> - // - [LowerMemorySize, 4 GB)
> + // - [Uc32Base, 4 GB)
> //
> // Everything else should be WB. Unfortunately, programming the inverse (ie.
> // keeping the default UC, and configuring the complement set of the above as
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-12 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-12 7:45 [PATCH] OvmfPkg/PlatformInitLib: fix comment about uncacheable MTRRs Laszlo Ersek
2023-01-12 10:20 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox