* Re: [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer
2021-05-14 11:48 [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer Laszlo Ersek
@ 2021-05-14 14:59 ` Sami Mujawar
2021-05-14 19:53 ` Ard Biesheuvel
2021-05-17 13:43 ` Leif Lindholm
2021-05-29 11:10 ` Laszlo Ersek
2 siblings, 1 reply; 6+ messages in thread
From: Sami Mujawar @ 2021-05-14 14:59 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-groups-io
Cc: Andrew Fish, Ard Biesheuvel, Julien Grall, Leif Lindholm,
Michael D Kinney, Philippe Mathieu-Daudé
Hi Laszlo,
I can help with the reviews for ArmVirtPkg.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 14/05/2021, 12:49, "Laszlo Ersek" <lersek@redhat.com> wrote:
For distributing ArmVirtPkg patch review tasks better, move Sami Mujawar
from the "ArmVirtPkg: Kvmtool" section to the top-level "ArmVirtPkg"
section.
Given that "ArmVirtPkg: Kvmtool" remains without a specific "R" role,
remove "ArmVirtPkg: Kvmtool" altogether.
Cc: Andrew Fish <afish@apple.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Julien Grall <julien@xen.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
Maintainers.txt | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index cafe6b1ab85d..1ec9185e70b9 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -143,33 +143,24 @@ M: Ard Biesheuvel <ardb+tianocore@kernel.org>
ArmVirtPkg
F: ArmVirtPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
M: Laszlo Ersek <lersek@redhat.com>
M: Ard Biesheuvel <ardb+tianocore@kernel.org>
R: Leif Lindholm <leif@nuviainc.com>
+R: Sami Mujawar <sami.mujawar@arm.com>
ArmVirtPkg: modules used on Xen
F: ArmVirtPkg/ArmVirtXen.*
F: ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/
F: ArmVirtPkg/Library/XenVirtMemInfoLib/
F: ArmVirtPkg/PrePi/
F: ArmVirtPkg/XenAcpiPlatformDxe/
F: ArmVirtPkg/XenPlatformHasAcpiDtDxe/
F: ArmVirtPkg/XenioFdtDxe/
R: Julien Grall <julien@xen.org>
-ArmVirtPkg: Kvmtool emulated platform support
-F: ArmVirtPkg/ArmVirtKvmTool.*
-F: ArmVirtPkg/KvmtoolPlatformDxe/
-F: ArmVirtPkg/Library/Fdt16550SerialPortHookLib/
-F: ArmVirtPkg/Library/KvmtoolPlatformPeiLib/
-F: ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/
-F: ArmVirtPkg/Library/KvmtoolVirtMemInfoLib/
-F: ArmVirtPkg/Library/NorFlashKvmtoolLib/
-R: Sami Mujawar <sami.mujawar@arm.com>
-
BaseTools
F: BaseTools/
W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
M: Bob Feng <bob.c.feng@intel.com>
M: Liming Gao <gaoliming@byosoft.com.cn>
R: Yuwei Chen <yuwei.chen@intel.com>
base-commit: 32928415e36b3e234efb5c24143e06060a68fba3
--
2.19.1.3.g30247aa5d201
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer
2021-05-14 14:59 ` Sami Mujawar
@ 2021-05-14 19:53 ` Ard Biesheuvel
0 siblings, 0 replies; 6+ messages in thread
From: Ard Biesheuvel @ 2021-05-14 19:53 UTC (permalink / raw)
To: Sami Mujawar
Cc: Laszlo Ersek, edk2-devel-groups-io, Andrew Fish, Ard Biesheuvel,
Julien Grall, Leif Lindholm, Michael D Kinney,
Philippe Mathieu-Daudé
On Fri, 14 May 2021 at 16:59, Sami Mujawar <Sami.Mujawar@arm.com> wrote:
>
> Hi Laszlo,
>
> I can help with the reviews for ArmVirtPkg.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> On 14/05/2021, 12:49, "Laszlo Ersek" <lersek@redhat.com> wrote:
>
> For distributing ArmVirtPkg patch review tasks better, move Sami Mujawar
> from the "ArmVirtPkg: Kvmtool" section to the top-level "ArmVirtPkg"
> section.
>
> Given that "ArmVirtPkg: Kvmtool" remains without a specific "R" role,
> remove "ArmVirtPkg: Kvmtool" altogether.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Maintainers.txt | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index cafe6b1ab85d..1ec9185e70b9 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -143,33 +143,24 @@ M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> ArmVirtPkg
> F: ArmVirtPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
> M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> R: Leif Lindholm <leif@nuviainc.com>
> +R: Sami Mujawar <sami.mujawar@arm.com>
>
> ArmVirtPkg: modules used on Xen
> F: ArmVirtPkg/ArmVirtXen.*
> F: ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/
> F: ArmVirtPkg/Library/XenVirtMemInfoLib/
> F: ArmVirtPkg/PrePi/
> F: ArmVirtPkg/XenAcpiPlatformDxe/
> F: ArmVirtPkg/XenPlatformHasAcpiDtDxe/
> F: ArmVirtPkg/XenioFdtDxe/
> R: Julien Grall <julien@xen.org>
>
> -ArmVirtPkg: Kvmtool emulated platform support
> -F: ArmVirtPkg/ArmVirtKvmTool.*
> -F: ArmVirtPkg/KvmtoolPlatformDxe/
> -F: ArmVirtPkg/Library/Fdt16550SerialPortHookLib/
> -F: ArmVirtPkg/Library/KvmtoolPlatformPeiLib/
> -F: ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/
> -F: ArmVirtPkg/Library/KvmtoolVirtMemInfoLib/
> -F: ArmVirtPkg/Library/NorFlashKvmtoolLib/
> -R: Sami Mujawar <sami.mujawar@arm.com>
> -
> BaseTools
> F: BaseTools/
> W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> M: Bob Feng <bob.c.feng@intel.com>
> M: Liming Gao <gaoliming@byosoft.com.cn>
> R: Yuwei Chen <yuwei.chen@intel.com>
>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer
2021-05-14 11:48 [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer Laszlo Ersek
2021-05-14 14:59 ` Sami Mujawar
@ 2021-05-17 13:43 ` Leif Lindholm
2021-05-18 16:42 ` [edk2-devel] " Laszlo Ersek
2021-05-29 11:10 ` Laszlo Ersek
2 siblings, 1 reply; 6+ messages in thread
From: Leif Lindholm @ 2021-05-17 13:43 UTC (permalink / raw)
To: Laszlo Ersek
Cc: edk2-devel-groups-io, Andrew Fish, Ard Biesheuvel, Julien Grall,
Michael D Kinney, Philippe Mathieu-Daudé, Sami Mujawar
[-- Attachment #1: Type: text/plain, Size: 2364 bytes --]
On Fri, May 14, 2021 at 12:49 PM Laszlo Ersek <lersek@redhat.com> wrote:
>
> For distributing ArmVirtPkg patch review tasks better, move Sami Mujawar
> from the "ArmVirtPkg: Kvmtool" section to the top-level "ArmVirtPkg"
> section.
>
> Given that "ArmVirtPkg: Kvmtool" remains without a specific "R" role,
> remove "ArmVirtPkg: Kvmtool" altogether.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Maintainers.txt | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index cafe6b1ab85d..1ec9185e70b9 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -143,33 +143,24 @@ M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> ArmVirtPkg
> F: ArmVirtPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
> M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> R: Leif Lindholm <leif@nuviainc.com>
> +R: Sami Mujawar <sami.mujawar@arm.com>
>
> ArmVirtPkg: modules used on Xen
> F: ArmVirtPkg/ArmVirtXen.*
> F: ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/
> F: ArmVirtPkg/Library/XenVirtMemInfoLib/
> F: ArmVirtPkg/PrePi/
> F: ArmVirtPkg/XenAcpiPlatformDxe/
> F: ArmVirtPkg/XenPlatformHasAcpiDtDxe/
> F: ArmVirtPkg/XenioFdtDxe/
> R: Julien Grall <julien@xen.org>
>
> -ArmVirtPkg: Kvmtool emulated platform support
> -F: ArmVirtPkg/ArmVirtKvmTool.*
> -F: ArmVirtPkg/KvmtoolPlatformDxe/
> -F: ArmVirtPkg/Library/Fdt16550SerialPortHookLib/
> -F: ArmVirtPkg/Library/KvmtoolPlatformPeiLib/
> -F: ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/
> -F: ArmVirtPkg/Library/KvmtoolVirtMemInfoLib/
> -F: ArmVirtPkg/Library/NorFlashKvmtoolLib/
> -R: Sami Mujawar <sami.mujawar@arm.com>
> -
> BaseTools
> F: BaseTools/
> W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> M: Bob Feng <bob.c.feng@intel.com>
> M: Liming Gao <gaoliming@byosoft.com.cn>
> R: Yuwei Chen <yuwei.chen@intel.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
[-- Attachment #2: Type: text/html, Size: 3901 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer
2021-05-17 13:43 ` Leif Lindholm
@ 2021-05-18 16:42 ` Laszlo Ersek
0 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2021-05-18 16:42 UTC (permalink / raw)
To: devel, leif
Cc: Andrew Fish, Ard Biesheuvel, Julien Grall, Michael D Kinney,
Philippe Mathieu-Daudé, Sami Mujawar
On 05/17/21 15:43, Leif Lindholm wrote:
> On Fri, May 14, 2021 at 12:49 PM Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> For distributing ArmVirtPkg patch review tasks better, move Sami Mujawar
>> from the "ArmVirtPkg: Kvmtool" section to the top-level "ArmVirtPkg"
>> section.
>>
>> Given that "ArmVirtPkg: Kvmtool" remains without a specific "R" role,
>> remove "ArmVirtPkg: Kvmtool" altogether.
>>
>> Cc: Andrew Fish <afish@apple.com>
>> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> Cc: Julien Grall <julien@xen.org>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Sami Mujawar <sami.mujawar@arm.com>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> Maintainers.txt | 11 +----------
>> 1 file changed, 1 insertion(+), 10 deletions(-)
>>
>> diff --git a/Maintainers.txt b/Maintainers.txt
>> index cafe6b1ab85d..1ec9185e70b9 100644
>> --- a/Maintainers.txt
>> +++ b/Maintainers.txt
>> @@ -143,33 +143,24 @@ M: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> ArmVirtPkg
>> F: ArmVirtPkg/
>> W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
>> M: Laszlo Ersek <lersek@redhat.com>
>> M: Ard Biesheuvel <ardb+tianocore@kernel.org>
>> R: Leif Lindholm <leif@nuviainc.com>
>> +R: Sami Mujawar <sami.mujawar@arm.com>
>>
>> ArmVirtPkg: modules used on Xen
>> F: ArmVirtPkg/ArmVirtXen.*
>> F: ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/
>> F: ArmVirtPkg/Library/XenVirtMemInfoLib/
>> F: ArmVirtPkg/PrePi/
>> F: ArmVirtPkg/XenAcpiPlatformDxe/
>> F: ArmVirtPkg/XenPlatformHasAcpiDtDxe/
>> F: ArmVirtPkg/XenioFdtDxe/
>> R: Julien Grall <julien@xen.org>
>>
>> -ArmVirtPkg: Kvmtool emulated platform support
>> -F: ArmVirtPkg/ArmVirtKvmTool.*
>> -F: ArmVirtPkg/KvmtoolPlatformDxe/
>> -F: ArmVirtPkg/Library/Fdt16550SerialPortHookLib/
>> -F: ArmVirtPkg/Library/KvmtoolPlatformPeiLib/
>> -F: ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/
>> -F: ArmVirtPkg/Library/KvmtoolVirtMemInfoLib/
>> -F: ArmVirtPkg/Library/NorFlashKvmtoolLib/
>> -R: Sami Mujawar <sami.mujawar@arm.com>
>> -
>> BaseTools
>> F: BaseTools/
>> W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
>> M: Bob Feng <bob.c.feng@intel.com>
>> M: Liming Gao <gaoliming@byosoft.com.cn>
>> R: Yuwei Chen <yuwei.chen@intel.com>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Thanks everybody, I consider this fully reviewed now; I intend to merge
it after the stable tag.
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer
2021-05-14 11:48 [PATCH] Maintainers.txt: add Sami Mujawar as top-level ArmVirtPkg reviewer Laszlo Ersek
2021-05-14 14:59 ` Sami Mujawar
2021-05-17 13:43 ` Leif Lindholm
@ 2021-05-29 11:10 ` Laszlo Ersek
2 siblings, 0 replies; 6+ messages in thread
From: Laszlo Ersek @ 2021-05-29 11:10 UTC (permalink / raw)
To: edk2-devel-groups-io
Cc: Andrew Fish, Ard Biesheuvel, Julien Grall, Leif Lindholm,
Michael D Kinney, Philippe Mathieu-Daudé, Sami Mujawar
On 05/14/21 13:48, Laszlo Ersek wrote:
> For distributing ArmVirtPkg patch review tasks better, move Sami Mujawar
> from the "ArmVirtPkg: Kvmtool" section to the top-level "ArmVirtPkg"
> section.
>
> Given that "ArmVirtPkg: Kvmtool" remains without a specific "R" role,
> remove "ArmVirtPkg: Kvmtool" altogether.
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> Maintainers.txt | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index cafe6b1ab85d..1ec9185e70b9 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -143,33 +143,24 @@ M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> ArmVirtPkg
> F: ArmVirtPkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
> M: Laszlo Ersek <lersek@redhat.com>
> M: Ard Biesheuvel <ardb+tianocore@kernel.org>
> R: Leif Lindholm <leif@nuviainc.com>
> +R: Sami Mujawar <sami.mujawar@arm.com>
>
> ArmVirtPkg: modules used on Xen
> F: ArmVirtPkg/ArmVirtXen.*
> F: ArmVirtPkg/Library/XenArmGenericTimerVirtCounterLib/
> F: ArmVirtPkg/Library/XenVirtMemInfoLib/
> F: ArmVirtPkg/PrePi/
> F: ArmVirtPkg/XenAcpiPlatformDxe/
> F: ArmVirtPkg/XenPlatformHasAcpiDtDxe/
> F: ArmVirtPkg/XenioFdtDxe/
> R: Julien Grall <julien@xen.org>
>
> -ArmVirtPkg: Kvmtool emulated platform support
> -F: ArmVirtPkg/ArmVirtKvmTool.*
> -F: ArmVirtPkg/KvmtoolPlatformDxe/
> -F: ArmVirtPkg/Library/Fdt16550SerialPortHookLib/
> -F: ArmVirtPkg/Library/KvmtoolPlatformPeiLib/
> -F: ArmVirtPkg/Library/KvmtoolRtcFdtClientLib/
> -F: ArmVirtPkg/Library/KvmtoolVirtMemInfoLib/
> -F: ArmVirtPkg/Library/NorFlashKvmtoolLib/
> -R: Sami Mujawar <sami.mujawar@arm.com>
> -
> BaseTools
> F: BaseTools/
> W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> M: Bob Feng <bob.c.feng@intel.com>
> M: Liming Gao <gaoliming@byosoft.com.cn>
> R: Yuwei Chen <yuwei.chen@intel.com>
>
> base-commit: 32928415e36b3e234efb5c24143e06060a68fba3
>
Merged as commit b8ed8c0fb2c9, via
<https://github.com/tianocore/edk2/pull/1673>.
Thanks
Laszlo
^ permalink raw reply [flat|nested] 6+ messages in thread