From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web08.61.1651607017933250834 for ; Tue, 03 May 2022 12:43:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PPLHO9uj; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EE825B81EAD for ; Tue, 3 May 2022 19:43:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF3D0C385B3 for ; Tue, 3 May 2022 19:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651607014; bh=wJ35q2rUtC/GKQO5Hn+Sm3w5b/CtHeXWT7se1L+vkDU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=PPLHO9ujb+sOTnRlsfO+WwuqlgMxHqTu7ToEOpWFjTwJGPhca4xFg7KcB1WWOQdOb +SUXtsx0psKI7TDv1U8dIHc9BJFql/mc+ocLJ64AqnqQBt1XN0SP6YFuLukyeS2JSt DqlOD2Q3AoUgK2OP2eryekTupJZoJdb0U6JYkKaD7fr85tyhNyWRojfyq0EQUrak6N BBHk5KlTV3F45Rs3Zf8PSsaj4U+oyhP56I7Ofyu7ijDt67Sa1THkNHeBkTMeO+qrUg 06QOUFbfStZEL8AKimM9jouTHHjDaw2JqDy3p/CDEurSAuNy+YeiqG8QkqRHj0coKY lFIIaIB9Irnxw== Received: by mail-oi1-f177.google.com with SMTP id m11so19220984oib.11 for ; Tue, 03 May 2022 12:43:34 -0700 (PDT) X-Gm-Message-State: AOAM531KEJizIOMs2Nt36qH0gs3cfbnSD/Ig9SR+cQj0cAv85sgf4Vr1 AcPj1XmChUd4OIYPP8i3c+lhWFIThpchj/OrKNg= X-Google-Smtp-Source: ABdhPJzQN45tL5G+/G64jO2FuvALax6Vts/FjF5PalNWops+jG9szAlNfXoaK8aNxf3uJA4P7Y/NQ6+L6IX8J8GVUOA= X-Received: by 2002:a05:6808:1315:b0:326:4405:e405 with SMTP id y21-20020a056808131500b003264405e405mr1036735oiv.228.1651607013850; Tue, 03 May 2022 12:43:33 -0700 (PDT) MIME-Version: 1.0 References: <20220503193106.9394-1-rebecca@bsdio.com> In-Reply-To: <20220503193106.9394-1-rebecca@bsdio.com> From: "Ard Biesheuvel" Date: Tue, 3 May 2022 21:43:22 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt To: edk2-devel-groups-io , Rebecca Cran Cc: Leif Lindholm , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" Hi Rebecca, On Tue, 3 May 2022 at 21:31, Rebecca Cran wrote: > > The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using > the console difficult, for example when using the UiApp. > > To allow for easy inclusion for future debugging, comment out but don't > remove the DEBUG lines. > I'd suggest to either demote the debug level to DEBUG_VERBOSE, or simply remove them, instead of using comments like this. > Signed-off-by: Rebecca Cran > --- > ...utBlt.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c > index 01ec6f68bd93..4766d72cef28 100644 > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c > @@ -815,17 +815,17 @@ LcdGraphicsBlt ( > HorizontalResolution = This->Mode->Info->HorizontalResolution; > VerticalResolution = This->Mode->Info->VerticalResolution; > > - DEBUG (( > - DEBUG_INFO, > - "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n", > - BltOperation, > - DestinationX, > - DestinationY, > - Width, > - Height, > - HorizontalResolution, > - VerticalResolution > - )); > +// DEBUG (( > +// DEBUG_INFO, > +// "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n", > +// BltOperation, > +// DestinationX, > +// DestinationY, > +// Width, > +// Height, > +// HorizontalResolution, > +// VerticalResolution > +// )); > > // Check we have reasonable parameters > if ((Width == 0) || (Height == 0)) { > -- > 2.25.1 > > > > > >