From: "Ard Biesheuvel" <ardb@kernel.org>
To: Matthew Carlson <matthewfcarlson@gmail.com>
Cc: devel@edk2.groups.io, Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH v2 1/1] EmbeddedPkg: fix guid for PrePiHobLib
Date: Tue, 16 Mar 2021 21:38:23 +0100 [thread overview]
Message-ID: <CAMj1kXEWz2sJFhhun7uGPU59a3dAKx1_DS_XjUk+xM6AwYZt0w@mail.gmail.com> (raw)
In-Reply-To: <20210316195312.1762-2-matthewfcarlson@gmail.com>
On Tue, 16 Mar 2021 at 20:53, Matthew Carlson <matthewfcarlson@gmail.com> wrote:
>
> Currently there is a duplicate GUID shared by two INFs.
> This rolls the INF for the PrePiHobLib.
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2381
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: devel@edk2.groups.io
>
> Signed-off-by: Matthew Carlson <matthewfcarlson@gmail.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Thanks for the patch
PR submitted, this should appear on master shortly.
> ---
> EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> index b2c4c04bfd76..55de4511fc98 100644
> --- a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> +++ b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> @@ -12,7 +12,7 @@
> [Defines]
> INF_VERSION = 0x00010005
> BASE_NAME = PrePiHobLib
> - FILE_GUID = 1F3A3278-82EB-4C0D-86F1-5BCDA5846CB2
> + FILE_GUID = AEF7D85A-6A91-4ACD-9A28-193DEFB325FB
> MODULE_TYPE = BASE
> VERSION_STRING = 1.0
> LIBRARY_CLASS = HobLib
> --
> 2.30.1.windows.1
>
prev parent reply other threads:[~2021-03-16 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 19:53 [PATCH v2 0/1] Fix GUID in PrePiHobLib Matthew Carlson
2021-03-16 19:53 ` [PATCH v2 1/1] EmbeddedPkg: fix guid for PrePiHobLib Matthew Carlson
2021-03-16 20:38 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEWz2sJFhhun7uGPU59a3dAKx1_DS_XjUk+xM6AwYZt0w@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox