From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web12.809.1615927116622403073
 for <devel@edk2.groups.io>;
 Tue, 16 Mar 2021 13:38:36 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KMrbKmjw;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id BCDDF64F83
	for <devel@edk2.groups.io>; Tue, 16 Mar 2021 20:38:35 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1615927115;
	bh=87gqgvcL37APpkrSVC7xSWkQwAuPkg9utfaCHQ1CZRo=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=KMrbKmjww4/hl5zwNFnnGcRxlpWwBjeTH9cIzgLI4fWc0LCm7a4dAC+sa8Ja0iTJJ
	 Wz8mnTWm4V5DwrHzPvyl+uvdl6jPT6XLUXBSK6ZY6hQoh+C//Ulg4B2btxH0Y2duQb
	 2/+bFhyXDPTLgs8ac/bJ3toGUIIXTeX8rY2DUoXPB3j6Vz+87ghx3uogPJBGcy5xxI
	 fxg4KE1XD2dLXUJkONCkYOMw/gBXD4pH59kqQjH6Mk6p3sFBc1Ur06ifmQ339NVY+2
	 UQRTVcRxQ8Rs7vmpfTbd3thTbdWWwnCnwRGLbU3CO2FwfwQdGhetJoqqCQTuUCQXVz
	 L0fbinqdh9A9w==
Received: by mail-ot1-f46.google.com with SMTP id 31-20020a9d00220000b02901b64b9b50b1so7577977ota.9
        for <devel@edk2.groups.io>; Tue, 16 Mar 2021 13:38:35 -0700 (PDT)
X-Gm-Message-State: AOAM530wt+EebAvpBDoI1o/KSeaSWKmSCuTOlsNLME26K9blXAQFErir
	YnSeqJzGGBhmcwUgSDEv7Omsi1cUxvwNk5f1XDY=
X-Google-Smtp-Source: ABdhPJz4DfYTY12868ZtEuQ7aDc6yxeu+pRAJtpuGJZLg4zYU8fHv/+1hQQ1jNRher02tKjfEv4pmeqZHAmV2l8QAy8=
X-Received: by 2002:a9d:42c:: with SMTP id 41mr513851otc.108.1615927115132;
 Tue, 16 Mar 2021 13:38:35 -0700 (PDT)
MIME-Version: 1.0
References: <20210316195312.1762-1-matthewfcarlson@gmail.com> <20210316195312.1762-2-matthewfcarlson@gmail.com>
In-Reply-To: <20210316195312.1762-2-matthewfcarlson@gmail.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Tue, 16 Mar 2021 21:38:23 +0100
X-Gmail-Original-Message-ID: <CAMj1kXEWz2sJFhhun7uGPU59a3dAKx1_DS_XjUk+xM6AwYZt0w@mail.gmail.com>
Message-ID: <CAMj1kXEWz2sJFhhun7uGPU59a3dAKx1_DS_XjUk+xM6AwYZt0w@mail.gmail.com>
Subject: Re: [PATCH v2 1/1] EmbeddedPkg: fix guid for PrePiHobLib
To: Matthew Carlson <matthewfcarlson@gmail.com>
Cc: devel@edk2.groups.io, Leif Lindholm <leif@nuviainc.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, 16 Mar 2021 at 20:53, Matthew Carlson <matthewfcarlson@gmail.com> wrote:
>
> Currently there is a duplicate GUID shared by two INFs.
> This rolls the INF for the PrePiHobLib.
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2381
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: devel@edk2.groups.io
>
> Signed-off-by: Matthew Carlson <matthewfcarlson@gmail.com>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

Thanks for the patch

PR submitted, this should appear on master shortly.


> ---
>  EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> index b2c4c04bfd76..55de4511fc98 100644
> --- a/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> +++ b/EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
> @@ -12,7 +12,7 @@
>  [Defines]
>    INF_VERSION                    = 0x00010005
>    BASE_NAME                      = PrePiHobLib
> -  FILE_GUID                      = 1F3A3278-82EB-4C0D-86F1-5BCDA5846CB2
> +  FILE_GUID                      = AEF7D85A-6A91-4ACD-9A28-193DEFB325FB
>    MODULE_TYPE                    = BASE
>    VERSION_STRING                 = 1.0
>    LIBRARY_CLASS                  = HobLib
> --
> 2.30.1.windows.1
>