From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.51384.1643734592989128358 for ; Tue, 01 Feb 2022 08:56:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TbP/H0aw; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B1CA60B8D for ; Tue, 1 Feb 2022 16:56:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7B62C340ED for ; Tue, 1 Feb 2022 16:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643734591; bh=woFIis7fifciFfBT5p10e2+1YIcf59fAITmTk3CCDP0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=TbP/H0awj9CkrNHrq2UBkyHGBTo8g5EtazMOzbcAEqsoB0dDX7JLpKi7Bs/EPus2f yYxCQr84Z53ckHv1ukuFfSV3UDYc9W/ZhM9m5qiX0S4/R2P2mjeHF2wETd5M+eVB2m vbxYes4EKe/AfEY/6uEKT/r84wLh20H8BO1lGPC+zsvZfdP8Kj+9t+yqpOauJFhF93 xoaIc2UMiM5tPkdvcd3DQB19746WcUPIZGvAbYblW/f7HEXWPeNWodiyghrpI0Yvls 4JHB6w7Ck6DB9oGUK+INJYpiXKoWT1iujRj0joSiPeltxUs8sZyMaLKsqPgWdQ9c6n 6ot0LtH+U1/7w== Received: by mail-wr1-f54.google.com with SMTP id s18so33211162wrv.7 for ; Tue, 01 Feb 2022 08:56:31 -0800 (PST) X-Gm-Message-State: AOAM531cLjTgCdphJ4Esfo1STn158iWn6g7moLakLNnWSzfv5D7QADtb INL7F6EmaK/SSrvopA0nc3ASM0AGNABdTGRmx1I= X-Google-Smtp-Source: ABdhPJyAGz2qR7Y4tMjy4o4baOMfz64CxoBbgfyepcI7bvNn7OtHuG1nzsRfhk64DlmzVftR2bJZKIsBDgu/iq6XULY= X-Received: by 2002:adf:f386:: with SMTP id m6mr22592305wro.447.1643734590147; Tue, 01 Feb 2022 08:56:30 -0800 (PST) MIME-Version: 1.0 References: <20220128154103.20752-1-Pierre.Gondois@arm.com> <20220128154103.20752-6-Pierre.Gondois@arm.com> <52503b9c-c820-15b3-65c5-f2cc110f5027@quicinc.com> <60a12a54-1860-f7b8-f4f1-144cf19f347f@arm.com> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 1 Feb 2022 17:56:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table To: Pierre Gondois Cc: Sami Mujawar , Rebecca Cran , "devel@edk2.groups.io" , Ard Biesheuvel , nd Content-Type: text/plain; charset="UTF-8" On Tue, 1 Feb 2022 at 17:56, Ard Biesheuvel wrote: > > On Tue, 1 Feb 2022 at 17:55, Pierre Gondois wrote: > > > > Hi Rebecca, > > > > On 1/31/22 4:21 PM, Sami Mujawar wrote: > > > Hi Rebecca, > > > > > > Thanks for catching this. > > > > > > I think we also need to adda check in Acpiview to report this issue. However, > > > that would be another patch series. > > > > > > Regards, > > > > > > Sami Mujawar > > > > > > *From: *Rebecca Cran > > > *Date: *Monday, 31 January 2022 at 15:17 > > > *To: *devel@edk2.groups.io , Pierre Gondois > > > > > > *Cc: *Ard Biesheuvel , Sami Mujawar > > > > > > *Subject: *Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table > > > > > > On 1/28/22 08:41, PierreGondois wrote: > > > > > >> + Differentiated System Description Table Fields (DSDT) > > >> + > > >> + Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.
> > >> + SPDX-License-Identifier: BSD-2-Clause-Patent > > >> + > > >> +**/ > > >> + > > >> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) { > > > > > > The Revision field should probably be 2, not 1. ACPI 6.4 says: > > > > > > > > > 2. This field also sets the global integer width for the AML > > > interpreter. Values less than two will cause the inter- > > > preter to use 32-bit integers and math. Values of two > > > and greater will cause the interpreter to use full 64-bit > > > integers and math. > > > > > > -- > > > Rebecca Cran > > > > > > > Yes indeed. I forgot to add it in the v4... I will send a v5. > > Please give me a minute before sending another version. > > I am still seeing