From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web10.45929.1681928798490824289
 for <devel@edk2.groups.io>;
 Wed, 19 Apr 2023 11:26:38 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QBdlN5SF;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 01E8064166
	for <devel@edk2.groups.io>; Wed, 19 Apr 2023 18:26:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0879C4339E
	for <devel@edk2.groups.io>; Wed, 19 Apr 2023 18:26:36 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1681928796;
	bh=IG8N9diEyNCl+NQkXzQcLGrNz4fPNXj/EM33aYKxgpg=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=QBdlN5SFxxl+dOTXqoNSJVyY5OEGQxNOOd3va1KzDD5sALpcabwYEML+MMyVmfOdH
	 ghZgx3e7xmMloUe8sU/S5UfzUPbVE5vo4Ki9WsqS7sksBjuMggeJ8BTpwIsw2hKYGy
	 OO7dPgV4XIC6oX+PLpp8TPeKoNNkcOfiHuKqtLnfBaD7Z6hFVsJo1sqRxQe1HTOYEr
	 PdHZK2qQoIbEs1Y5DdV/riv+P3aRDNo1MDPPcJMdBkE/ECuW0W1YZfolw0B3kHcSZa
	 +yYRdqCEno7qXee8acqfS6+f6egO+RWq+fYkZ1uO+BcWxR5aRn3PjZT3BCTD44Wzwl
	 GQinnKT2HhmXA==
Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-4eed764a10cso57876e87.0
        for <devel@edk2.groups.io>; Wed, 19 Apr 2023 11:26:36 -0700 (PDT)
X-Gm-Message-State: AAQBX9f2NnEJBys8UprTDMlY3W2TXAhw1BPOXiv/CXD38v//uV3mhCps
	p6wqdoAx2Rcag37tElycPdAdwy6Syds8vFLTKFE=
X-Google-Smtp-Source: AKy350agEnc9Nx3CGNqWD6UGGVHXjsJbSHI6BUTZFl6fvfEZcTYRt6s6Q38WaIhbnWWRjoG/sOCWJVUByTn/oVE41yw=
X-Received: by 2002:a05:6512:98d:b0:4ea:fafd:e679 with SMTP id
 w13-20020a056512098d00b004eafafde679mr4139212lft.36.1681928794852; Wed, 19
 Apr 2023 11:26:34 -0700 (PDT)
MIME-Version: 1.0
References: <CAMj1kXHMbafkf8WMm0xRUUHvdtq3crEM8c_fcnfX_jUQGvkgFQ@mail.gmail.com>
 <46CED01C-BEA6-49F3-9634-051DC63D248C@posteo.de> <CAMj1kXEwutN2PyeNSCTPFQd3uV7zP0ZKA9ZYM803zvzOA7kdEA@mail.gmail.com>
 <EE155630-B183-40E0-9FC6-068BC98FABA1@posteo.de> <F308E6E3-54FB-414C-8C05-88EE134732F7@posteo.de>
 <CAMj1kXG2iKi_K8tOntBAA6GUjqerbyKifhA4H-0iNqzLCiHaTA@mail.gmail.com>
 <696924B3-EF5B-4799-AAD9-E090C97D9AA9@posteo.de> <CAMj1kXEGJBd8kn9_gDa4tpXG3RWQL_GKN0QDR10FL4pguSWuOQ@mail.gmail.com>
 <1CE9D3E9-4D3E-49B7-B66B-527B16322980@posteo.de>
In-Reply-To: <1CE9D3E9-4D3E-49B7-B66B-527B16322980@posteo.de>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 19 Apr 2023 20:26:23 +0200
X-Gmail-Original-Message-ID: <CAMj1kXEXFWi_raWf7JYtN0ANR=YMEhvu+Mrh1Nn48KBxcdBhVg@mail.gmail.com>
Message-ID: <CAMj1kXEXFWi_raWf7JYtN0ANR=YMEhvu+Mrh1Nn48KBxcdBhVg@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH 1/2] ArmPkg/AsmMacroIoLibV8: Introduce ASM_FUNC_ALIGN()
To: =?UTF-8?Q?Marvin_H=C3=A4user?= <mhaeuser@posteo.de>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <quic_llindhol@quicinc.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>, Sami Mujawar <sami.mujawar@arm.com>, 
	Vitaly Cheptsov <vit9696@protonmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 19 Apr 2023 at 20:25, Marvin H=C3=A4user <mhaeuser@posteo.de> wrote=
:
>
>
> On 19. Apr 2023, at 20:03, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> Your branch seems to be missing 16e0969ef775b898ac700f3261d76030b8ab9ef0
>
> "ArmVirtPkg/ArmVirtQemu: Use PEI flavor of ArmMmuLib for all PEIMs"
>
>
> That's correct (because that commit is after the last commit I managed to=
 reproduce the issue with), but I don't see how this commit would fix the i=
ssue. As I said, the symptom is that PeiCore memory is badly corrupted and =
the stall happens due to executing said corruption, not due to jumping to N=
ULL. Those broken branches I linked can all be made work by rolling back th=
e change to MemoryAllocationLib (which changes the code size, thus misalign=
s *something*). In fact, using the broken variant only for MemoryInitPei is=
 sufficient to reproduce the issue, other modules don't seem to be involved=
.
>

Applying that commit made your branch work for me.