[PATCH] OvmfPkg/BhyvePkg: use correct PlatformSecureLib

[PATCH] OvmfPkg/BhyvePkg: use correct PlatformSecureLib

[Corvin Köhne]

There's no bhyve specific PlatformSecureLib any more. Use the default
one of OvmfPkg which works too.

Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
CC: Ard Biesheuvel <ardb+tianocore@kernel.org>
CC: Jiewen Yao <jiewen.yao@intel.com>
CC: Jordan Justen <jordan.l.justen@intel.com>
CC: Gerd Hoffmann <kraxel@redhat.com>
CC: Rebecca Cran <rebecca@bsdio.com>
CC: Peter Grehan <grehan@freebsd.org>
CC: devel@edk2.groups.io
---
 OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index d4f0c90b8e..475b88b21a 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhyve/BhyveX64.dsc
@@ -198,7 +198,7 @@
   RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
 
 !if $(SECURE_BOOT_ENABLE) == TRUE
-  PlatformSecureLib|OvmfPkg/Bhyve/Library/PlatformSecureLib/PlatformSecureLib.inf
+  PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
   AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
   SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
   PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
-- 
2.30.2

This email contains confidential information. If you have received it in error, you must not read, use, copy or pass on this e-mail or its attachments. If you have received the e-mail in error, please inform me immediately by reply e-mail and then delete this e-mail from your system. Thank you
 
Diese E-Mail enthält vertrauliche Informationen. Sollten Sie sie irrtümlich erhalten haben, dürfen Sie diese E-Mail oder ihre Anhänge nicht lesen, verwenden, kopieren oder weitergeben. Sollten Sie die Mail versehentlich erhalten haben, teilen Sie mir dies bitte umgehend per Antwort-E-Mail mit und löschen Sie diese E-Mail dann aus Ihrem System. Vielen Dank

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075

Re: [PATCH] OvmfPkg/BhyvePkg: use correct PlatformSecureLib

[Ard Biesheuvel]

On Fri, 2 Sept 2022 at 12:41, Corvin Köhne <c.koehne@beckhoff.com> wrote:
>
> There's no bhyve specific PlatformSecureLib any more. Use the default
> one of OvmfPkg which works too.
>
> Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
> CC: Ard Biesheuvel <ardb+tianocore@kernel.org>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Jordan Justen <jordan.l.justen@intel.com>
> CC: Gerd Hoffmann <kraxel@redhat.com>
> CC: Rebecca Cran <rebecca@bsdio.com>
> CC: Peter Grehan <grehan@freebsd.org>
> CC: devel@edk2.groups.io
> ---
>  OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> index d4f0c90b8e..475b88b21a 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> @@ -198,7 +198,7 @@
>    RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>
>  !if $(SECURE_BOOT_ENABLE) == TRUE
> -  PlatformSecureLib|OvmfPkg/Bhyve/Library/PlatformSecureLib/PlatformSecureLib.inf
> +  PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>    SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>    PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf

This patch doesn't apply, probably due to the quoted printable encoding?

Re: [PATCH] OvmfPkg/BhyvePkg: use correct PlatformSecureLib

[Corvin Köhne]

Hi,

I've created a PR for the merge: https://github.com/tianocore/edk2/pull/3288
Can you accept it/cherry pick the patch?


Best regards
Corvin

This email contains confidential information. If you have received it in error, you must not read, use, copy or pass on this e-mail or its attachments. If you have received the e-mail in error, please inform me immediately by reply e-mail and then delete this e-mail from your system. Thank you

Diese E-Mail enthält vertrauliche Informationen. Sollten Sie sie irrtümlich erhalten haben, dürfen Sie diese E-Mail oder ihre Anhänge nicht lesen, verwenden, kopieren oder weitergeben. Sollten Sie die Mail versehentlich erhalten haben, teilen Sie mir dies bitte umgehend per Antwort-E-Mail mit und löschen Sie diese E-Mail dann aus Ihrem System. Vielen Dank

Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075


-----Original Message-----
From: Ard Biesheuvel <ardb@kernel.org>
Sent: Monday, September 5, 2022 2:24 PM
To: Corvin Köhne <C.Koehne@beckhoff.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Jiewen Yao <jiewen.yao@intel.com>; Jordan Justen <jordan.l.justen@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Rebecca Cran <rebecca@bsdio.com>; Peter Grehan <grehan@freebsd.org>; devel@edk2.groups.io
Subject: Re: [PATCH] OvmfPkg/BhyvePkg: use correct PlatformSecureLib

CAUTION: External Email!!
On Fri, 2 Sept 2022 at 12:41, Corvin Köhne <c.koehne@beckhoff.com> wrote:
>
> There's no bhyve specific PlatformSecureLib any more. Use the default
> one of OvmfPkg which works too.
>
> Signed-off-by: Corvin Köhne <c.koehne@beckhoff.com>
> CC: Ard Biesheuvel <ardb+tianocore@kernel.org>
> CC: Jiewen Yao <jiewen.yao@intel.com>
> CC: Jordan Justen <jordan.l.justen@intel.com>
> CC: Gerd Hoffmann <kraxel@redhat.com>
> CC: Rebecca Cran <rebecca@bsdio.com>
> CC: Peter Grehan <grehan@freebsd.org>
> CC: devel@edk2.groups.io
> ---
>  OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> index d4f0c90b8e..475b88b21a 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> @@ -198,7 +198,7 @@
>    RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
>
>  !if $(SECURE_BOOT_ENABLE) == TRUE
> -  PlatformSecureLib|OvmfPkg/Bhyve/Library/PlatformSecureLib/PlatformSecureLib.inf
> +  PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
>    AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>    SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>    PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf

This patch doesn't apply, probably due to the quoted printable encoding?

Re: [PATCH] OvmfPkg/BhyvePkg: use correct PlatformSecureLib

[Ard Biesheuvel]

On Mon, 5 Sept 2022 at 15:19, Corvin Köhne <C.Koehne@beckhoff.com> wrote:
>
> Hi,
>
> I've created a PR for the merge: https://github.com/tianocore/edk2/pull/3288
> Can you accept it/cherry pick the patch?
>
>

OK