From: "Ard Biesheuvel" <ardb@kernel.org>
To: Leif Lindholm <leif@nuviainc.com>
Cc: devel@edk2.groups.io, Rebecca Cran <rebecca@nuviainc.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull
Date: Tue, 9 Feb 2021 14:00:22 +0100 [thread overview]
Message-ID: <CAMj1kXEYtzWhwA0cP7U=g2maEKc0KLu-kzvF=koqfTpwFj0F6A@mail.gmail.com> (raw)
In-Reply-To: <20210208234849.13327-1-leif@nuviainc.com>
On Tue, 9 Feb 2021 at 00:48, Leif Lindholm <leif@nuviainc.com> wrote:
>
> The just added OemMiscLibNull fails to build due to DebugLib.h not
> being included, missing the ASSERT definition. Add the include and the
> library dependency.
>
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 2 +-
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> index b21eeade64b5..5c4268f68b4a 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> @@ -28,4 +28,4 @@ [Packages]
>
> [LibraryClasses]
> BaseMemoryLib
> -
> + DebugLib
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> index 767fc08d166b..73cebef2d1b9 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> @@ -11,6 +11,7 @@
>
> #include <Uefi.h>
> #include <Library/BaseMemoryLib.h>
> +#include <Library/DebugLib.h>
> #include <Library/HiiLib.h>
>
> #include <Library/OemMiscLib.h>
> --
> 2.20.1
>
prev parent reply other threads:[~2021-02-09 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 23:48 [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull Leif Lindholm
2021-02-09 0:16 ` Rebecca Cran
2021-02-09 13:00 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXEYtzWhwA0cP7U=g2maEKc0KLu-kzvF=koqfTpwFj0F6A@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox