From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web10.9851.1612875635585733928 for ; Tue, 09 Feb 2021 05:00:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bOWHyU5U; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id CA44564EB9 for ; Tue, 9 Feb 2021 13:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612875634; bh=HJCXX5eyNka8vldQf5QqKdFqDWwHsuRIuD/GueOvYIY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bOWHyU5UaCVM9Z4dSNRTHKxrKovtaxCtyznl2Pv6U+BZ9z1+pYnOdlCcLP8+SsY6M 2SlzOK2o20GMyfJ1bdKt5oqN4mE+gLF3mUGwS5O68UhhVNgC3JG19mHGOUvgwGeSxZ 4N91e2wZZ0Gucm+0kgTN7Cca3HQ+em6ly9AA1joYNXMN93MhcJ83UokQ/skeTPQQ5M owh1TaOv7NHXZRvpQjdnOmucf6b0eSPNsAX/bUKoe966roqfbfmtv+4a1GQnvJrg6T awhPUxcXw+aLJpyFWgJ38CBkKtxUSy6uafw8tSXMmgjyhPYmAw55KfsF+WVLOIzZCu LhX6hr8fW2Vmw== Received: by mail-oi1-f176.google.com with SMTP id l3so9357857oii.2 for ; Tue, 09 Feb 2021 05:00:34 -0800 (PST) X-Gm-Message-State: AOAM530PZAFxe7q3EmejGucEOW0rBLUFgfdHGSpIBdkVl1O2fQyJE4hM y0gH5a66JARskhpn9519X5kL7rm3w2zxbZFOxCA= X-Google-Smtp-Source: ABdhPJyBf2haXLTah1vrH3AsESv/GcvntsQAZyGyRrgvIp9pr6znUUNCh0zWH0knp6sVoUPVeAJWOu9GbGTgExjEAUs= X-Received: by 2002:aca:b6c1:: with SMTP id g184mr2383828oif.47.1612875633968; Tue, 09 Feb 2021 05:00:33 -0800 (PST) MIME-Version: 1.0 References: <20210208234849.13327-1-leif@nuviainc.com> In-Reply-To: <20210208234849.13327-1-leif@nuviainc.com> From: "Ard Biesheuvel" Date: Tue, 9 Feb 2021 14:00:22 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull To: Leif Lindholm Cc: devel@edk2.groups.io, Rebecca Cran , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" On Tue, 9 Feb 2021 at 00:48, Leif Lindholm wrote: > > The just added OemMiscLibNull fails to build due to DebugLib.h not > being included, missing the ASSERT definition. Add the include and the > library dependency. > > Cc: Rebecca Cran > Cc: Ard Biesheuvel > Signed-off-by: Leif Lindholm Acked-by: Ard Biesheuvel > --- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 2 +- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > index b21eeade64b5..5c4268f68b4a 100644 > --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > @@ -28,4 +28,4 @@ [Packages] > > [LibraryClasses] > BaseMemoryLib > - > + DebugLib > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > index 767fc08d166b..73cebef2d1b9 100644 > --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > @@ -11,6 +11,7 @@ > > #include > #include > +#include > #include > > #include > -- > 2.20.1 >