From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web09.51369.1643734588740051782 for ; Tue, 01 Feb 2022 08:56:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Kcx+x7oE; spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 51CD6CE1A2B for ; Tue, 1 Feb 2022 16:56:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A02DCC36AE2 for ; Tue, 1 Feb 2022 16:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643734583; bh=edNgTalIwt/DufneFPeuHg/NX/DOifkNOZVNB30lufc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Kcx+x7oESTDAxv51A00u7oNqqyARrl6CpO6BQh3Cd3udp77hBPcVyjfhsujCwKuMB sXfGOwRtNzzsgizfLfTDHu18bcKUzqCYjrq5hLVYdniWlqiJmQIUD48pB9qBVdvXPf HM0N2jKORerEOF0iqrfKK7hxLXy4efAhsac/+5XoLjHlrAXX9rV8c7oVNfrwVLf2Ai C6RlRMI1t6TXsmq/hOU94lr1e7cTnTL2AIBs2Vkv4ZiJtnUyL6mjpbMVi3AoA3PdSJ Bek5dD4Lhs4H+DqsnfI2OGONwo7bNgrqMJDvF5gtnGndVwEIoNcGaUa99yzapEjHEB CUmp9kf6xMKxQ== Received: by mail-wm1-f51.google.com with SMTP id bg21-20020a05600c3c9500b0035283e7a012so2081481wmb.0 for ; Tue, 01 Feb 2022 08:56:23 -0800 (PST) X-Gm-Message-State: AOAM532ufNsgTEfHlwzUmDWPQM2V4IFuMQcIY8uaXX8lIMr8+aVSD3Gd hRM8UuZHsOCSEXoCPM0j2t2q599w4b4F+TqaPYU= X-Google-Smtp-Source: ABdhPJzq/dyJoYRZBSEMYNrB8DG2ThyOSg5itJppgEwDmNNuL+OTxDT++yIZw3Ow5809s9aHqtI06q51ekxmPxcPfGk= X-Received: by 2002:a05:600c:4f84:: with SMTP id n4mr2628160wmq.106.1643734581952; Tue, 01 Feb 2022 08:56:21 -0800 (PST) MIME-Version: 1.0 References: <20220128154103.20752-1-Pierre.Gondois@arm.com> <20220128154103.20752-6-Pierre.Gondois@arm.com> <52503b9c-c820-15b3-65c5-f2cc110f5027@quicinc.com> <60a12a54-1860-f7b8-f4f1-144cf19f347f@arm.com> In-Reply-To: <60a12a54-1860-f7b8-f4f1-144cf19f347f@arm.com> From: "Ard Biesheuvel" Date: Tue, 1 Feb 2022 17:56:09 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table To: Pierre Gondois Cc: Sami Mujawar , Rebecca Cran , "devel@edk2.groups.io" , Ard Biesheuvel , nd Content-Type: text/plain; charset="UTF-8" On Tue, 1 Feb 2022 at 17:55, Pierre Gondois wrote: > > Hi Rebecca, > > On 1/31/22 4:21 PM, Sami Mujawar wrote: > > Hi Rebecca, > > > > Thanks for catching this. > > > > I think we also need to adda check in Acpiview to report this issue. However, > > that would be another patch series. > > > > Regards, > > > > Sami Mujawar > > > > *From: *Rebecca Cran > > *Date: *Monday, 31 January 2022 at 15:17 > > *To: *devel@edk2.groups.io , Pierre Gondois > > > > *Cc: *Ard Biesheuvel , Sami Mujawar > > > > *Subject: *Re: [edk2-devel] [PATCH v3 5/8] ArmVirtPkg/Kvmtool: Add DSDT ACPI table > > > > On 1/28/22 08:41, PierreGondois wrote: > > > >> + Differentiated System Description Table Fields (DSDT) > >> + > >> + Copyright (c) 2021 - 2022, ARM Ltd. All rights reserved.
> >> + SPDX-License-Identifier: BSD-2-Clause-Patent > >> + > >> +**/ > >> + > >> +DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-KVMT", 1) { > > > > The Revision field should probably be 2, not 1. ACPI 6.4 says: > > > > > > 2. This field also sets the global integer width for the AML > > interpreter. Values less than two will cause the inter- > > preter to use 32-bit integers and math. Values of two > > and greater will cause the interpreter to use full 64-bit > > integers and math. > > > > -- > > Rebecca Cran > > > > Yes indeed. I forgot to add it in the v4... I will send a v5. Please give me a minute before sending another version. I am still seeing