From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B949BAC166E for ; Thu, 10 Aug 2023 12:55:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=j8OMNe1hDWXtQ4HtatoEGE8qdJIyvaJkKBxbbi6gY1o=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691672152; v=1; b=p3P4iwEJ5x+5R1juT3pHfyEizzQnDdhHl1+MlVu3nIjBb2Ac1mduFTbXwVXnkGr3wOHVZFEw kWdj7uZl7MEWtZrtBHeA6tNcoow9VqdP2yrCYRe/N6H531yHzelLczIe5VIcXv4hJVFuZlZSnVx VhKvQFJFsyIBGLYORmnMOyRE= X-Received: by 127.0.0.2 with SMTP id 2h8cYY7687511xrpJNhgN0zm; Thu, 10 Aug 2023 05:55:52 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.16338.1691672151764673727 for ; Thu, 10 Aug 2023 05:55:52 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0D0DA65255 for ; Thu, 10 Aug 2023 12:55:51 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id E370FC433CD for ; Thu, 10 Aug 2023 12:55:49 +0000 (UTC) X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-4fe61ae020bso1303795e87.2 for ; Thu, 10 Aug 2023 05:55:49 -0700 (PDT) X-Gm-Message-State: gRZD7v0YAYHqQV0QZ8T8Gfyfx7686176AA= X-Google-Smtp-Source: AGHT+IFwUQ7HFSqY13iBWgtEORq5ERQ6ormFEInfyTLEIUAdVjaAY28A4frvBUB6YIxCi3B+YcBF2OvvOcrDDPqrwwA= X-Received: by 2002:a19:7b07:0:b0:4fb:9fa7:dcda with SMTP id w7-20020a197b07000000b004fb9fa7dcdamr1671961lfc.26.1691672147811; Thu, 10 Aug 2023 05:55:47 -0700 (PDT) MIME-Version: 1.0 References: <20230724130006.427522-1-corvink@FreeBSD.org> <20230724130006.427522-2-corvink@FreeBSD.org> <899bbdac-5aa3-50c4-f6e2-926b7a22c799@bsdio.com> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 10 Aug 2023 14:55:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB To: devel@edk2.groups.io, corvink@freebsd.org Cc: Rebecca Cran , Michael Kinney , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Peter Grehan , Michael Kubacki Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=p3P4iwEJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 10 Aug 2023 at 14:53, Corvin K=C3=B6hne wrote= : > > On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote: > > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote: > > > > > > Nit: "sizeof" is normally used like a function. And this patch > > > mixes the > > > two styles. > > > > > > > Actually, this is not unidiomatic for OVMF - sizeof takes either a > > type name (in which case the () are required) or an expression (in > > which case they are optional), and we have always permitted both > > idioms for the latter case. > > > > $ git grep -cE 'sizeof\s*[:alnum:]' OvmfPkg/ > > OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c:4 > > OvmfPkg/EnrollDefaultKeys/AuthData.c:4 > > OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport. > > c:7 > > OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c:1 > > OvmfPkg/PlatformPei/MemTypeInfo.c:1 > > OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c:5 > > OvmfPkg/QemuVideoDxe/VbeShim.c:4 > > OvmfPkg/SmmControl2Dxe/SmiFeatures.c:4 > > OvmfPkg/Virtio10Dxe/Virtio10.c:1 > > OvmfPkg/VirtioGpuDxe/DriverBinding.c:4 > > > > > > > Other than that: > > > > > > > > > Reviewed-by: Rebecca Cran > > > > > > > Thanks > > > > > > I've tried to merge this but I am getting errors and I cannot figure > > out what they are: > > > > https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=3D99505&= view=3Dresults > > > > Thanks. Have you tried > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatt= ing#how-to-find-uncrustify-formatting-errors-in-continuous-integration-ci > > I'm stuck at step 5. I can't see something like "92.5% passed". Maybe I > don't have the permission to see it? > I was having the same problem. The instructions don't match the actual situation, so it is impossible for me to figure why the CI decided to reject the series. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107687): https://edk2.groups.io/g/devel/message/107687 Mute This Topic: https://groups.io/mt/100327419/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-