From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A842D941351 for ; Tue, 22 Aug 2023 07:57:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=95GdpVZwlAb+LZFXvDbwihoK4uCiXF+AGbwc4aWWEbU=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1692691047; v=1; b=iwiwdxeTE+uF7UHub8M5SHQP9Cj75dWYWLtNYvr/4zoyk563CBWGyYZSUrwjIfhYawO3eEwC IJvtAf4YZjyN4dcG99Ezs1RAoL3fa4KXPmHLqUkZHwEzpvGw/QdgGRRHCl4PFucA1mnXH6VfBGS mTmoU9lpQazrZ8TVp8XVlkpM= X-Received: by 127.0.0.2 with SMTP id iMR8YY7687511xb9M5ixosg8; Tue, 22 Aug 2023 00:57:27 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.3414.1692691046527152063 for ; Tue, 22 Aug 2023 00:57:26 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F3C9263D09 for ; Tue, 22 Aug 2023 07:57:25 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50750C43391 for ; Tue, 22 Aug 2023 07:57:25 +0000 (UTC) X-Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2bb99fbaebdso65580601fa.0 for ; Tue, 22 Aug 2023 00:57:25 -0700 (PDT) X-Gm-Message-State: IIybOSWaSwHaNx0vipRM77Rix7686176AA= X-Google-Smtp-Source: AGHT+IHoKLRyyZFam83FO+dbFsesiIDioHSYWdvS+qaAobCMS+PD1MMm7m5R2DQzy6pDZwghMbH8Qk1qsM4qhRr6W0U= X-Received: by 2002:a2e:7c09:0:b0:2b6:a804:4cc with SMTP id x9-20020a2e7c09000000b002b6a80404ccmr6611638ljc.53.1692691043323; Tue, 22 Aug 2023 00:57:23 -0700 (PDT) MIME-Version: 1.0 References: <20230720134557.3903923-1-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 22 Aug 2023 09:57:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy To: devel@edk2.groups.io, kraxel@redhat.com Cc: Jiewen Yao , Michael Brown Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iwiwdxeT; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote: > > On Thu, Jul 20, 2023 at 03:45:57PM +0200, Ard Biesheuvel wrote: > > Instead of relying on raising the TPL to protect the critical sections > > that manipulate the global bitmask that keeps track of bounce buffer > > allocations, use compare-and-exchange to manage the global variable, and > > tweak the logic to line up with that. > > > > Given that IoMmuDxe implements a singleton protocol that is shared > > between multiple drivers, and considering the elaborate and confusing > > requirements in the UEFP spec regarding TPL levels at which protocol > > methods may be invoked, not relying on TPL levels at all is a more > > robust approach in this case. > > > > Cc: Gerd Hoffmann > > Cc: Jiewen Yao > > Cc: Michael Brown > > Link: https://bugzilla.redhat.com/show_bug.cgi?id=2211060 > > Signed-off-by: Ard Biesheuvel > > Looks good to me. > > What is the status? Merged? Or waiting for testing still? If so I can > create a test build with the patch and ask our QE department to check > it. > Still waiting for testing, so yes, please test. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107948): https://edk2.groups.io/g/devel/message/107948 Mute This Topic: https://groups.io/mt/100256049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-