From: "Ard Biesheuvel" <ardb@kernel.org>
To: Dionna Amalie Glaze <dionnaglaze@google.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Gerd Hoffmann <kraxel@redhat.com>,
James Bottomley <jejb@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Xu, Min M" <min.m.xu@intel.com>, Andrew Fish <afish@apple.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH v10 2/4] MdePkg: Introduce the SevMemoryAcceptance protocol
Date: Thu, 26 Jan 2023 18:19:52 +0100 [thread overview]
Message-ID: <CAMj1kXEbnJE-2QzG_ka8dpbjSDPqVL45+dpmT8noLg-UkSLchg@mail.gmail.com> (raw)
In-Reply-To: <CAAH4kHYY+DfkW=2UTF40O1DthQQxySUCMiNDDLZ8x2uuDvYkfw@mail.gmail.com>
On Thu, 26 Jan 2023 at 18:04, Dionna Amalie Glaze
<dionnaglaze@google.com> wrote:
>
> > As Gerd and I discussed before, this protocol should be in OvmfPkg.
> > Please move to https://github.com/tianocore/edk2/tree/master/OvmfPkg/Include/Protocol
> >
>
> Ah, I misinterpreted your response to Gerd's message. v11 will have it
> moved. The CI seems to think I've redefined the protocol struct type
> or failed to use the typedef for declarations, but I don't see how
> that would be. Is this a false positive that I can ignore for the next
> iteration? https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=78271&view=results
>
That looks very odd to me, and I don't see anything wrong with the .h file.
However, since we are moving this to OvmfPkg and you are spinning a
v11, can we drop the bizarre prefix please?
Also, the 'extern EFI_GUID xxx' should be unnecessary these days -
these are generated by the build tools based on the [Protocols]
section in the INF.
next prev parent reply other threads:[~2023-01-26 17:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:56 [PATCH v10 0/4] Add safe unaccepted memory behavior Dionna Glaze
2023-01-26 0:56 ` [PATCH v10 1/4] OvmfPkg: Add memory acceptance event in AmdSevDxe Dionna Glaze
2023-01-26 10:30 ` Ard Biesheuvel
2023-01-26 16:04 ` Dionna Glaze
2023-02-09 13:35 ` [edk2-devel] " Gupta, Pankaj
2023-02-09 16:52 ` Dionna Glaze
2023-02-09 21:27 ` Dionna Glaze
2023-02-10 8:00 ` Gupta, Pankaj
2023-02-10 11:12 ` Ard Biesheuvel
2023-02-10 11:34 ` Gupta, Pankaj
2023-02-10 13:56 ` Gupta, Pankaj
2023-02-10 17:05 ` Dionna Glaze
2023-02-13 14:38 ` Gupta, Pankaj
2023-02-13 16:53 ` Dionna Glaze
2023-02-13 17:56 ` Gupta, Pankaj
2023-02-13 18:31 ` Dionna Glaze
2023-02-13 19:33 ` Lendacky, Thomas
2023-02-13 19:33 ` Gupta, Pankaj
2023-02-13 21:44 ` Dionna Glaze
2023-02-14 12:51 ` Gupta, Pankaj
2023-02-14 12:55 ` Gupta, Pankaj
2023-02-14 20:44 ` Dionna Glaze
2023-02-14 20:46 ` Gupta, Pankaj
[not found] ` <1743B21FF9509E5F.2641@groups.io>
2023-02-14 14:00 ` Gupta, Pankaj
2023-02-14 9:12 ` Gerd Hoffmann
2023-02-14 17:28 ` Dionna Glaze
2023-02-14 22:44 ` Lendacky, Thomas
2023-02-15 9:38 ` Gerd Hoffmann
2023-01-26 0:56 ` [PATCH v10 2/4] MdePkg: Introduce the SevMemoryAcceptance protocol Dionna Glaze
2023-01-26 1:24 ` Yao, Jiewen
2023-01-26 17:04 ` Dionna Glaze
2023-01-26 17:19 ` Ard Biesheuvel [this message]
2023-01-26 0:56 ` [PATCH v10 3/4] OvmfPkg: Implement AcceptAllUnacceptedMemory in AmdSevDxe Dionna Glaze
2023-01-26 0:56 ` [PATCH v10 4/4] OvmfPkg/PlatformPei: SEV-SNP make >=4GB unaccepted Dionna Glaze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEbnJE-2QzG_ka8dpbjSDPqVL45+dpmT8noLg-UkSLchg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox