From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web11.79826.1674753607312016614
 for <devel@edk2.groups.io>;
 Thu, 26 Jan 2023 09:20:07 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=F1QO7Uc0;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id A4F8A618E8
	for <devel@edk2.groups.io>; Thu, 26 Jan 2023 17:20:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 121D8C433A1
	for <devel@edk2.groups.io>; Thu, 26 Jan 2023 17:20:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1674753606;
	bh=ocbBNgjLzYdOXGcVJD4KKjgiMrRVw9F+0HuUrGXHtp4=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=F1QO7Uc0YgEtfZlPKQdzzVxRjDktKKxMaEPYD2XZ2U9RIqIcF2Xw2o8lK/37dJkcJ
	 zziPkhOwSq8AMXBwntKNZItT3TrF7VX0zxLzPEvZn14W4N8DWnypg77r0/CCMSzIQE
	 qi95CVb80tpyFsZDZf0ybB1xG9xtUiJWmdCEElL5ITOsdNdVzzvIchv2KGyacKBuqA
	 Aps1HUzQSYveYPLGkS3ZMok1v1ePMLieDZem+CKbKWn4UNKHzM35v7TIm5V5npOfEp
	 JyD82QR62UI7Twee0mZgIrSQdOVnN8jc+HX7jxNmFE1nFxbHdWycqqC9slAojJ2Ei5
	 wUjBU7md+L1Hg==
Received: by mail-lj1-f172.google.com with SMTP id o12so2629371ljp.11
        for <devel@edk2.groups.io>; Thu, 26 Jan 2023 09:20:05 -0800 (PST)
X-Gm-Message-State: AFqh2kpnVmm6Qx+1H0aSaJXTUKGN+X2cY2ePS2c+wQDKHfv4SDXWQhzX
	BtmnL3sWohdYtRg0ew3Utln/Ehg3oXXWLuKkStE=
X-Google-Smtp-Source: AMrXdXtlLm7RX44Fg+ZmAShr+7+Fn+KaiPnlOySF2GsByJR4gEmOAyt3lWIem1F0dBlaxElLzlRH0CXpzogaI2qbZLQ=
X-Received: by 2002:a2e:a163:0:b0:28b:95fe:65ea with SMTP id
 u3-20020a2ea163000000b0028b95fe65eamr2358001ljl.244.1674753604076; Thu, 26
 Jan 2023 09:20:04 -0800 (PST)
MIME-Version: 1.0
References: <20230126005647.3019225-1-dionnaglaze@google.com>
 <20230126005647.3019225-3-dionnaglaze@google.com> <MW4PR11MB58725FD249811C898D5DF2CC8CCF9@MW4PR11MB5872.namprd11.prod.outlook.com>
 <CAAH4kHYY+DfkW=2UTF40O1DthQQxySUCMiNDDLZ8x2uuDvYkfw@mail.gmail.com>
In-Reply-To: <CAAH4kHYY+DfkW=2UTF40O1DthQQxySUCMiNDDLZ8x2uuDvYkfw@mail.gmail.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Thu, 26 Jan 2023 18:19:52 +0100
X-Gmail-Original-Message-ID: <CAMj1kXEbnJE-2QzG_ka8dpbjSDPqVL45+dpmT8noLg-UkSLchg@mail.gmail.com>
Message-ID: <CAMj1kXEbnJE-2QzG_ka8dpbjSDPqVL45+dpmT8noLg-UkSLchg@mail.gmail.com>
Subject: Re: [PATCH v10 2/4] MdePkg: Introduce the SevMemoryAcceptance protocol
To: Dionna Amalie Glaze <dionnaglaze@google.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>, "devel@edk2.groups.io" <devel@edk2.groups.io>, 
	Gerd Hoffmann <kraxel@redhat.com>, James Bottomley <jejb@linux.ibm.com>, 
	Tom Lendacky <thomas.lendacky@amd.com>, "Xu, Min M" <min.m.xu@intel.com>, 
	Andrew Fish <afish@apple.com>, "Kinney, Michael D" <michael.d.kinney@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 26 Jan 2023 at 18:04, Dionna Amalie Glaze
<dionnaglaze@google.com> wrote:
>
> > As Gerd and I discussed before, this protocol should be in OvmfPkg.
> > Please move to https://github.com/tianocore/edk2/tree/master/OvmfPkg/Include/Protocol
> >
>
> Ah, I misinterpreted your response to Gerd's message. v11 will have it
> moved. The CI seems to think I've redefined the protocol struct type
> or failed to use the typedef for declarations, but I don't see how
> that would be. Is this a false positive that I can ignore for the next
> iteration? https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=78271&view=results
>

That looks very odd to me, and I don't see anything wrong with the .h file.

However, since we are moving this to OvmfPkg and you are spinning a
v11, can we drop the bizarre prefix please?

Also, the 'extern EFI_GUID xxx' should be unnecessary these days -
these are generated by the build tools based on the [Protocols]
section in the INF.