From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1511878003C for ; Thu, 21 Dec 2023 07:31:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cJWHibjAiqVM1+VK8HISVhAItI7jA3JMOL0/BWaYKDA=; c=relaxed/simple; d=groups.io; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:To:Cc:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703143887; v=1; b=ZpVv0+eMLZovi9ZSrd5sZx/ZeEj4JK53RgitTmyBwMOUDA5+UYO8QTF7KOrWRpExs1HLV/Qw qjFoyhhsQrRhFBnkdJBvkuLC9Mi/HCJ/6Jo70RPCaPYZPUklos8EuwZGn1pAWqAVU0AhogBFrIr EuABPbuMPME2GzsalHDjoBTU= X-Received: by 127.0.0.2 with SMTP id 6gfoYY7687511x54fZzjcjf1; Wed, 20 Dec 2023 23:31:27 -0800 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.47035.1703143887216743962 for ; Wed, 20 Dec 2023 23:31:27 -0800 X-Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 8AA966183D for ; Thu, 21 Dec 2023 07:31:26 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D737C433C9 for ; Thu, 21 Dec 2023 07:31:26 +0000 (UTC) X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50e270639d9so620220e87.3 for ; Wed, 20 Dec 2023 23:31:26 -0800 (PST) X-Gm-Message-State: oDOv0MyQIVE0BAsMD7VCrXwvx7686176AA= X-Google-Smtp-Source: AGHT+IF0gUHdur+f0qrzK3s80Kz/8u0FeUvqsJpYmDKPhHCwefmlIb2IF1Y6nZRpFs4GAZMU5sEy/ThCsHxmqTxuGaU= X-Received: by 2002:a05:6512:68e:b0:50e:584d:a2a0 with SMTP id t14-20020a056512068e00b0050e584da2a0mr894147lfe.21.1703143884442; Wed, 20 Dec 2023 23:31:24 -0800 (PST) MIME-Version: 1.0 References: <20231212130932.2467028-1-lichao@loongson.cn> <17A017C201FEB90D.32321@groups.io> <9014a7b3-095c-42b1-a9ef-5a388818385d@loongson.cn> In-Reply-To: From: "Ard Biesheuvel" Date: Thu, 21 Dec 2023 08:31:13 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v4 19/37] UefiCpuPkg: Add MMIO method in CpuIo2Dxe To: devel@edk2.groups.io, lichao@loongson.cn Cc: ray.ni@intel.com, "Kumar, Rahul R" , Gerd Hoffmann , Leif Lindholm , Ard Biesheuvel , Sami Mujawar Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZpVv0+eM; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Thu, 21 Dec 2023 at 04:48, Chao Li wrote: > ... > Ard, > > PcdPciIoTranslationIsEnabled is only use for whether to trigger the Ffio = read or write, it seem that only x86 or x64 need them, not others. > > When I was submitted the patch V2, CpuIo2Dxe was private to LoongArch, ju= st like Arm and RISC-V. Gerd recommended finding a better place for ArmPciC= puIo2Dxe so that other ARCH can easily use it. And then I found the UefiCpu= Pkg/CpuIo2Dxe might be able to accommodate the MMIO methods, so I merged th= em togeter in this change. > I think it makes sense to have a shared implementation under UefiCpuPkg or even MdeModulePkg. But merging it with the x86 implementation using function pointers that are dereferenced at runtime seems unnecessary to me. My preference would be to put this into MdeModulePkg, but Ray may have a different view. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112803): https://edk2.groups.io/g/devel/message/112803 Mute This Topic: https://groups.io/mt/103261693/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-