From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web08.4491.1613545031445746543
 for <devel@edk2.groups.io>;
 Tue, 16 Feb 2021 22:57:11 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DeIAo1CN;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id B85A764E45
	for <devel@edk2.groups.io>; Wed, 17 Feb 2021 06:57:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1613545030;
	bh=835mnlzvVT3xlPsM7VmffjwuyQdjxuLYX/AF/dkutyA=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=DeIAo1CNzb3bhyw4+0bT43mfLNhSU7Wh9MBAy28r8wEWjzg/aE9ewh44T9a0u7Kne
	 zllnGTYUJa0Ol7rl2ZVG5E7+yzOxKqtLDFO8fDrC2cWZwKtb6r5z2k1A9wJrOoTUsn
	 v9Dxd1tAnEeOYyiZxGXHR8OQmMC1gp7BpKFNvTn0ZPygumJwPKeJCZHpXoIc/Tgmxe
	 lIqBi2ObRABp/Uok6oOnL4N8CNa/L6tl3L4OOJk1eASI30enU21AKz6Lf5MYIoKueR
	 6PIMS90kdAIVlxk7dkoe+rvIvXtSG0czM80RqCtVDBTICG0veXWCoXJrRGIkjdEZF3
	 0IiwDQQNyY2dg==
Received: by mail-oi1-f174.google.com with SMTP id v193so13965782oie.8
        for <devel@edk2.groups.io>; Tue, 16 Feb 2021 22:57:10 -0800 (PST)
X-Gm-Message-State: AOAM530ZJ+VLoJ6Dw988A/uvjBwJ37lDf1iO7X4gkN3TFGaplEvuDIRg
	JRwGeyH886H0dJcZ9D4n6YIA/mqfyP2pIraYwbo=
X-Google-Smtp-Source: ABdhPJxbbjJpZ6LdEFWU267L8NJjm2Eiy/McWn3aTujSem2wbFJEV+KV5HwjtxsYvu4yUOpN4FHzn3nqyPXL4Ygf4cA=
X-Received: by 2002:aca:b6c1:: with SMTP id g184mr4867280oif.47.1613545029888;
 Tue, 16 Feb 2021 22:57:09 -0800 (PST)
MIME-Version: 1.0
References: <20210217061809.307479-1-lintonrjeremy@gmail.com>
In-Reply-To: <20210217061809.307479-1-lintonrjeremy@gmail.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 17 Feb 2021 07:56:56 +0100
X-Gmail-Original-Message-ID: <CAMj1kXEcdt4=uAv6niZCevKde1Qg4uREToHw=ryXLRb9VEnJxQ@mail.gmail.com>
Message-ID: <CAMj1kXEcdt4=uAv6niZCevKde1Qg4uREToHw=ryXLRb9VEnJxQ@mail.gmail.com>
Subject: Re: [PATCH v3 0/4] RPi: SD/WiFi ACPI updates
To: jlinton <lintonrjeremy@gmail.com>
Cc: devel@edk2.groups.io, Peter Batard <pete@akeo.ie>, 
	Andrei Warkentin <awarkentin@vmware.com>, Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>, 
	Leif Lindholm <leif@nuviainc.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Jeremy Linton <jeremy.linton@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Wed, 17 Feb 2021 at 07:18, jlinton <lintonrjeremy@gmail.com> wrote:
>
> From: Jeremy Linton <jeremy.linton@arm.com>
>
> The existing RPi3 ACPI entries for the Arasan
> and SDHCI controllers need updating to work
> with the RPi4. This is done by adding a caps
> override for the legacy Arasan controller and
> then adding an entirely new entry for the newer
> eMMC2 controller.
>
> Then we flip the default routing to make the eMMC2
> the default for the SD card, so that the WiFi can
> start working on the Arasan.
>
> Additional we add a menu item to enable the SDMA/ADMA2
> modes on the controller.
>
> v2->v3: Various small review tweaks, whitespace, wording
>             spelling, etc.
>

What happened to the IORT change? Don't we need that to ensure that
Linux sizes ZONE_DMA appropriately?


> v1->v2: Add option for user to enable/disable eMMC DMA
>         Only enable the emmc2 table on rpi4 &
>             !Arasan routing
>         Move emmc2 into its own SSDT and drop
>             second _DMA entry
>
> Jeremy Linton (4):
>   Platform/RaspberryPi: Add Negative table check
>   Platform/RaspberryPi/Acpitables: Add eMMC2 device and tweak Arasan
>   Platform/RaspberryPi: User control of eMMC2 DMA
>   Platform/RaspberryPi: Invert default Arasan, eMMC2 routing
>
>  Platform/RaspberryPi/AcpiTables/AcpiTables.inf     |   1 +
>  Platform/RaspberryPi/AcpiTables/Emmc.asl           | 129 +++++++++++++++++++++
>  Platform/RaspberryPi/AcpiTables/Sdhc.asl           |  18 ++-
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |  26 +++++
>  .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.inf    |   1 +
>  .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni |   4 +
>  .../RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr |  17 +++
>  Platform/RaspberryPi/Include/ConfigVars.h          |   8 ++
>  Platform/RaspberryPi/RPi3/RPi3.dsc                 |   1 +
>  Platform/RaspberryPi/RPi4/RPi4.dsc                 |   3 +-
>  Platform/RaspberryPi/RPi4/Readme.md                |   2 +-
>  Platform/RaspberryPi/RaspberryPi.dec               |   1 +
>  12 files changed, 206 insertions(+), 5 deletions(-)
>  create mode 100644 Platform/RaspberryPi/AcpiTables/Emmc.asl
>
> --
> 2.13.7
>