From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mx.groups.io with SMTP id smtpd.web12.23561.1662375447706215805
 for <devel@edk2.groups.io>;
 Mon, 05 Sep 2022 03:57:27 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BcGbces0;
 spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id AF1DD6120C
	for <devel@edk2.groups.io>; Mon,  5 Sep 2022 10:57:26 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C709C433D7
	for <devel@edk2.groups.io>; Mon,  5 Sep 2022 10:57:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1662375446;
	bh=VCN+sAWPhU/9CWKNkWnLcnTZ8a4D7VRKihYZD7H8ct4=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=BcGbces0NIoqORZMXJSR7pWPo0mcz2u71oqfOGxPxmndxgGL+0szJbBYR5wKxhxY1
	 HcdpDXc5yVf74m0PBRE1eEvjap3zgEFAqBNFSR8/EojNz6GSq+FOFs62DtwMxxhuOS
	 9GVbkFact7tEK/TCUJ6kiscEUnzo+ChLUz+SSeL+NRwBcT9VP+gGoaq7w8dcCSFjbT
	 j/7EZXVwVWhMS8Au1Olgn70zUmYD+Q0ekCg2ajlKInrtLp4rLG7F4XiUZuZeILV++i
	 XN8cyMG7xZFN3iYzeFnhGNbVklQd0L8+VaWQ5pSHP5xHO92TEL9SICFau54STIK+XK
	 OgP9g/nnCypNw==
Received: by mail-lj1-f171.google.com with SMTP id by6so8811575ljb.11
        for <devel@edk2.groups.io>; Mon, 05 Sep 2022 03:57:26 -0700 (PDT)
X-Gm-Message-State: ACgBeo0R9mPP/yibiYrKTyMCyCBtSAjP5yV5sgYvuZvJndu66gqkkobO
	3+r7Qxyk6pjXyz6oZEuXPvTTcezccdxiqNDbQ/M=
X-Google-Smtp-Source: AA6agR5krH0gvvj+b3eXivCl5TO5Tij/WhhEHgHg0Q6ce1RgqVHY7cnPDpz9gN+eR8uhSs94eYxV9dMZTh+54otH9b8=
X-Received: by 2002:a05:651c:1508:b0:268:a367:ebd8 with SMTP id
 e8-20020a05651c150800b00268a367ebd8mr6913423ljf.516.1662375443995; Mon, 05
 Sep 2022 03:57:23 -0700 (PDT)
MIME-Version: 1.0
References: <20220829155955.3767-1-rebecca@quicinc.com>
In-Reply-To: <20220829155955.3767-1-rebecca@quicinc.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 5 Sep 2022 12:57:12 +0200
X-Gmail-Original-Message-ID: <CAMj1kXEdEMkzN=VATCqn1vE=8JW5p8odc-26z4dUr4pMVO0iUg@mail.gmail.com>
Message-ID: <CAMj1kXEdEMkzN=VATCqn1vE=8JW5p8odc-26z4dUr4pMVO0iUg@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH 0/2] Add support EFI_MP_SERVICES_PROTOCOL on AARCH64
To: devel@edk2.groups.io, quic_rcran@quicinc.com
Cc: Leif Lindholm <quic_llindhol@quicinc.com>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Sami Mujawar <sami.mujawar@arm.com>, Jian J Wang <jian.j.wang@intel.com>, 
	Liming Gao <gaoliming@byosoft.com.cn>, Rebecca Cran <rebecca@quicinc.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 29 Aug 2022 at 18:00, Rebecca Cran <quic_rcran@quicinc.com> wrote:
>
> This is the rework of the patches I sent out in late 2021,
> building on fixes done by Ard at
> https://github.com/ardbiesheuvel/edk2/tree/armpkg-mpservicesdxe-refactor.
>
> The most significant changes are the addition of code to enable
> the MMU and caches on the APs, and changing MpServicesTest to
> use commandline parameters to control its operation.
>

IIRC, there were some issues with this code on bare metal. Which
hardware did you use to test it? Any chance you could try it on a
RPi4?

> Rebecca Cran (2):
>   ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls
>   MdeModulePkg: Add new Application/MpServicesTest application
>
>  ArmPkg/ArmPkg.dsc                                            |    1 +
>  MdeModulePkg/MdeModulePkg.dsc                                |    9 +
>  ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf |   55 +
>  MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf   |   41 +
>  ArmPkg/Drivers/ArmPsciMpServicesDxe/MpServicesInternal.h     |  351 ++++
>  MdeModulePkg/Application/MpServicesTest/Options.h            |   39 +
>  ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c   | 1774 ++++++++++++++++++++
>  MdeModulePkg/Application/MpServicesTest/MpServicesTest.c     |  558 ++++++
>  MdeModulePkg/Application/MpServicesTest/Options.c            |  215 +++
>  ArmPkg/Drivers/ArmPsciMpServicesDxe/MpFuncs.S                |   57 +
>  10 files changed, 3100 insertions(+)
>  create mode 100644 ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.inf
>  create mode 100644 MdeModulePkg/Application/MpServicesTest/MpServicesTest.inf
>  create mode 100644 ArmPkg/Drivers/ArmPsciMpServicesDxe/MpServicesInternal.h
>  create mode 100644 MdeModulePkg/Application/MpServicesTest/Options.h
>  create mode 100644 ArmPkg/Drivers/ArmPsciMpServicesDxe/ArmPsciMpServicesDxe.c
>  create mode 100644 MdeModulePkg/Application/MpServicesTest/MpServicesTest.c
>  create mode 100644 MdeModulePkg/Application/MpServicesTest/Options.c
>  create mode 100644 ArmPkg/Drivers/ArmPsciMpServicesDxe/MpFuncs.S
>
> --
> 2.30.2
>
>
>
> 
>
>