From: "Ard Biesheuvel" <ardb@kernel.org>
To: Ard Biesheuvel <ardb+git@google.com>
Cc: devel@edk2.groups.io, jeremy.linton@arm.com, quic_llindhol@quicinc.com
Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build
Date: Tue, 12 Mar 2024 11:43:27 +0100 [thread overview]
Message-ID: <CAMj1kXEddn9r4U8rXH_jiL+PDvJOX59hit2jVmUhjP85ud_xEA@mail.gmail.com> (raw)
In-Reply-To: <20240312102923.2053815-1-ardb+git@google.com>
On Tue, 12 Mar 2024 at 11:29, Ard Biesheuvel <ardb+git@google.com> wrote:
>
> From: Ard Biesheuvel <ardb@kernel.org>
>
> The DEBUG build no longer fits when all build options used by the
> release script on github.com/pftf are used, presumably due to the
> OpenSSL upgrade.
>
> So bump the size for all builds.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/RaspberryPi/RPi4/RPi4.fdf | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.fdf b/Platform/RaspberryPi/RPi4/RPi4.fdf
> index 816927761513..951488260ed4 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.fdf
> +++ b/Platform/RaspberryPi/RPi4/RPi4.fdf
> @@ -25,11 +25,11 @@
>
> [FD.RPI_EFI]
> BaseAddress = 0x00000000|gArmTokenSpaceGuid.PcdFdBaseAddress
> -Size = 0x001f0000|gArmTokenSpaceGuid.PcdFdSize
> +Size = 0x00210000|gArmTokenSpaceGuid.PcdFdSize
> ErasePolarity = 1
>
Ugh just realized that this breaks DT loading from TFA, which places
the DT at a fixed offset of 0x1f0000
> BlockSize = 0x00001000|gRaspberryPiTokenSpaceGuid.PcdFirmwareBlockSize
> -NumBlocks = 0x1f0
> +NumBlocks = 0x210
>
> ################################################################################
> #
> @@ -56,7 +56,7 @@ [FD.RPI_EFI]
> #
> # UEFI image
> #
> -0x00020000|0x001b0000
> +0x00020000|0x001d0000
> gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize
> FV = FVMAIN_COMPACT
>
> @@ -70,7 +70,7 @@ [FD.RPI_EFI]
> #
>
> # NV_VARIABLE_STORE
> -0x001d0000|0x0000e000
> +0x001f0000|0x0000e000
> gRaspberryPiTokenSpaceGuid.PcdNvStorageVariableBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize
>
> DATA = {
> @@ -113,11 +113,11 @@ [FD.RPI_EFI]
> }
>
> # NV_EVENT_LOG
> -0x001de000|0x00001000
> +0x001fe000|0x00001000
> gRaspberryPiTokenSpaceGuid.PcdNvStorageEventLogBase|gRaspberryPiTokenSpaceGuid.PcdNvStorageEventLogSize
>
> # NV_FTW_WORKING header
> -0x001df000|0x00001000
> +0x001ff000|0x00001000
> gRaspberryPiTokenSpaceGuid.PcdNvStorageFtwWorkingBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwWorkingSize
>
> DATA = {
> @@ -132,7 +132,7 @@ [FD.RPI_EFI]
> }
>
> # NV_FTW_WORKING data
> -0x001e0000|0x00010000
> +0x00200000|0x00010000
> gRaspberryPiTokenSpaceGuid.PcdNvStorageFtwSpareBase|gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize
>
> #
> --
> 2.44.0.278.ge034bb2e1d-goog
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116676): https://edk2.groups.io/g/devel/message/116676
Mute This Topic: https://groups.io/mt/104882052/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-12 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 10:29 [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build Ard Biesheuvel via groups.io
2024-03-12 10:43 ` Ard Biesheuvel [this message]
2024-03-13 2:01 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEddn9r4U8rXH_jiL+PDvJOX59hit2jVmUhjP85ud_xEA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox