From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web09.6194.1620823495926295761
 for <devel@edk2.groups.io>;
 Wed, 12 May 2021 05:44:56 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OJKK/dob;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 27127613EE
	for <devel@edk2.groups.io>; Wed, 12 May 2021 12:44:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1620823495;
	bh=pUPTD7AKy9dDRdGqNVTc+WYQeGUfPZffE5UnTGd2Lc4=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=OJKK/dobZpqVrUrMUWusdfZTdaBL9TUv8WSq7e/UaLwdSJCaaq1Uyd7hWwSYv8MS5
	 Vlt6HBz4Ti3AgR3Yk3tJQgTEqrlSY+j391vhb1GCGdNa4fEp/8diuqhgDde92Ma2k8
	 EBp7sfrVsVxlKRSXNoDcFIkDhyEaUMqhD7xdWiootUsXJIWTscM83u5R55w+j4BfpG
	 3T3AMS8J/3kxNDQ2pFC5A1gmNKfSkKLZOXQP8xQ2pscFKcgZPPvu37VRqKRncrR897
	 Z9uh1p4o1AyUJdasLYDb/v217XoRXDDGZTT3tfaxU7AnhHJdYRZ232ByzZHzJy4KeB
	 wjTfGqe5N710g==
Received: by mail-oi1-f171.google.com with SMTP id w22so8244330oiw.9
        for <devel@edk2.groups.io>; Wed, 12 May 2021 05:44:55 -0700 (PDT)
X-Gm-Message-State: AOAM533YRQtCobYYL/RwIMXRhw2nIc4Dgcn3rwjcGxhE3XxR0zZpek8Q
	hem24hcDdFbjrSh0WVasm9QPEqFFbgl/zvI4Feo=
X-Google-Smtp-Source: ABdhPJxhA1U4UZQhGWrET6x4AUmOTGBqgh+gDXtuaxkoZlD/de5QrY0nQABsXYCgiQS9yDZDexM5MtacjvfLe/hWd8Q=
X-Received: by 2002:aca:4056:: with SMTP id n83mr7459907oia.47.1620823494371;
 Wed, 12 May 2021 05:44:54 -0700 (PDT)
MIME-Version: 1.0
References: <20210511223734.864455-1-jeremy.linton@arm.com> <20210511223734.864455-3-jeremy.linton@arm.com>
In-Reply-To: <20210511223734.864455-3-jeremy.linton@arm.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Wed, 12 May 2021 14:44:42 +0200
X-Gmail-Original-Message-ID: <CAMj1kXEdh6tp28JM-5w5GWx3-Vr28iNOUoMVmKEpOYgG2OzFQg@mail.gmail.com>
Message-ID: <CAMj1kXEdh6tp28JM-5w5GWx3-Vr28iNOUoMVmKEpOYgG2OzFQg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] Platform/RaspberryPi: Increase genet dma window
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Ard Biesheuvel <ardb+tianocore@kernel.org>, 
	Peter Batard <pete@akeo.ie>, Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>, 
	Andrei Warkentin <awarkentin@vmware.com>, Jared McNeill <jmcneill@invisible.ca>
Content-Type: text/plain; charset="UTF-8"

On Wed, 12 May 2021 at 00:37, Jeremy Linton <jeremy.linton@arm.com> wrote:
>
> The genet is capable of addressing the entire memory space
> on the RPI4. Lets allow it to dma into those regions.
> This solves intermittent issues with grub/etc being able
> to communicate when the 3G limit is lifted on 8G boards.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> Reviewed-by: Jared McNeill <jmcneill@invisible.ca>
> ---
>  Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 5c6783eae7..cf796acf6a 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -717,7 +717,7 @@
>    Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf {
>      <PcdsFixedAtBuild>
>        gEmbeddedTokenSpaceGuid.PcdDmaDeviceOffset|0x00000000
> -      gEmbeddedTokenSpaceGuid.PcdDmaDeviceLimit|0xffffffff
> +      gEmbeddedTokenSpaceGuid.PcdDmaDeviceLimit|0xffffffffff
>    }
>
>    #
> --
> 2.13.7
>

As I said before, I am fine with this patch, but I would still like to
understand why this causes a failure. The device limit is used by the
DMA layer to decide whether bounce buffering is needed or not, but the
API should work as expected either way, with perhaps only an impact on
performance if bounce buffering is done unnecessarily.

What kind of errors are you seeing (and fixing) with this change?