From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "Pierre.Gondois@arm.com" <Pierre.Gondois@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH 15/24] OvmfPkg: Remove duplicated words
Date: Mon, 5 Sep 2022 15:55:21 +0200 [thread overview]
Message-ID: <CAMj1kXEdm05+Hj=FZEtuaZBRvComXhbLQ8sMrm8c3tN6Q-T8iA@mail.gmail.com> (raw)
In-Reply-To: <MW4PR11MB58723D3B41C8566B61CC735C8C709@MW4PR11MB5872.namprd11.prod.outlook.com>
On Wed, 24 Aug 2022 at 01:00, Yao, Jiewen <jiewen.yao@intel.com> wrote:
>
> Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>
>
Merged as #3287
> > -----Original Message-----
> > From: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> > Sent: Wednesday, August 24, 2022 12:00 AM
> > To: devel@edk2.groups.io
> > Cc: Pierre Gondois <pierre.gondois@arm.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>
> > Subject: [PATCH 15/24] OvmfPkg: Remove duplicated words
> >
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > In an effort to clean the documentation of the above
> > package, remove duplicated words.
> >
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > ---
> > OvmfPkg/Library/PeilessStartupLib/X64/VirtualMemory.c | 6 +++---
> > OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 2 +-
> > OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c | 2 +-
> > OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashDxe.c | 2 +-
> > OvmfPkg/SataControllerDxe/ComponentName.c | 4 ++--
> > OvmfPkg/SataControllerDxe/SataController.h | 4 ++--
> > OvmfPkg/XenBusDxe/ComponentName.c | 2 +-
> > OvmfPkg/XenBusDxe/ComponentName.h | 2 +-
> > OvmfPkg/XenPvBlkDxe/BlockFront.c | 2 +-
> > OvmfPkg/XenPvBlkDxe/ComponentName.c | 2 +-
> > OvmfPkg/XenPvBlkDxe/ComponentName.h | 2 +-
> > 11 files changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git a/OvmfPkg/Library/PeilessStartupLib/X64/VirtualMemory.c
> > b/OvmfPkg/Library/PeilessStartupLib/X64/VirtualMemory.c
> > index 8da06da74ef5..6877e521e485 100644
> > --- a/OvmfPkg/Library/PeilessStartupLib/X64/VirtualMemory.c
> > +++ b/OvmfPkg/Library/PeilessStartupLib/X64/VirtualMemory.c
> > @@ -813,7 +813,7 @@ CreateIdentityMappingPageTables (
> > {
> > //
> > // Each PML5 entry points to a page of PML4 entires.
> > - // So lets allocate space for them and fill them in in the IndexOfPml4Entries
> > loop.
> > + // So lets allocate space for them and fill them in the IndexOfPml4Entries
> > loop.
> > // When 5-Level Paging is disabled, below allocation happens only once.
> > //
> > PageMapLevel4Entry = (VOID *)BigPageAddress;
> > @@ -835,7 +835,7 @@ CreateIdentityMappingPageTables (
> > {
> > //
> > // Each PML4 entry points to a page of Page Directory Pointer entires.
> > - // So lets allocate space for them and fill them in in the IndexOfPdpEntries
> > loop.
> > + // So lets allocate space for them and fill them in the IndexOfPdpEntries
> > loop.
> > //
> > PageDirectoryPointerEntry = (VOID *)BigPageAddress;
> > BigPageAddress += SIZE_4KB;
> > @@ -875,7 +875,7 @@ CreateIdentityMappingPageTables (
> > {
> > //
> > // Each Directory Pointer entries points to a page of Page Directory entires.
> > - // So allocate space for them and fill them in in the
> > IndexOfPageDirectoryEntries loop.
> > + // So allocate space for them and fill them in the
> > IndexOfPageDirectoryEntries loop.
> > //
> > PageDirectoryEntry = (VOID *)BigPageAddress;
> > BigPageAddress += SIZE_4KB;
> > diff --git a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> > b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> > index 4e25f198aa76..a4c12b9057e5 100644
> > --- a/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> > +++ b/OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c
> > @@ -259,7 +259,7 @@ DebugClearMemory (
> > ASSERT (Buffer != NULL);
> >
> > //
> > - // SetMem() checks for the the ASSERT() condition on Length and returns
> > Buffer
> > + // SetMem() checks for the ASSERT() condition on Length and returns Buffer
> > //
> > return SetMem (Buffer, Length, PcdGet8 (PcdDebugClearMemoryValue));
> > }
> > diff --git a/OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c
> > b/OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c
> > index 7f37710b964f..30c258313135 100644
> > --- a/OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c
> > +++ b/OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c
> > @@ -108,7 +108,7 @@ LibGetTime (
> >
> > @retval EFI_SUCCESS The operation completed successfully.
> > @retval EFI_INVALID_PARAMETER A time field is out of range.
> > - @retval EFI_DEVICE_ERROR The time could not be set due due to hardware
> > error.
> > + @retval EFI_DEVICE_ERROR The time could not be set due to hardware
> > error.
> >
> > **/
> > EFI_STATUS
> > diff --git a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashDxe.c
> > b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashDxe.c
> > index 9e074c29bb2b..172d6a4267f8 100644
> > --- a/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashDxe.c
> > +++ b/OvmfPkg/QemuFlashFvbServicesRuntimeDxe/QemuFlashDxe.c
> > @@ -79,7 +79,7 @@ QemuFlashPtrWrite (
> > // Writing to flash is emulated by the hypervisor through the use of write
> > // protection. This won't work for an SEV-ES guest because the write won't
> > // be recognized as a true MMIO write, which would result in the required
> > - // #VC exception. Instead, use the the VMGEXIT MMIO write support directly
> > + // #VC exception. Instead, use the VMGEXIT MMIO write support directly
> > // to perform the update.
> > //
> > VmgInit (Ghcb, &InterruptState);
> > diff --git a/OvmfPkg/SataControllerDxe/ComponentName.c
> > b/OvmfPkg/SataControllerDxe/ComponentName.c
> > index d45803f95f6e..7b5912bab822 100644
> > --- a/OvmfPkg/SataControllerDxe/ComponentName.c
> > +++ b/OvmfPkg/SataControllerDxe/ComponentName.c
> > @@ -59,7 +59,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED
> > EFI_UNICODE_STRING_TABLE mSataControllerControlle
> >
> > @param This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> > instance.
> > @param Language A pointer to a three character ISO 639-2 language
> > identifier.
> > - This is the language of the driver name that that the caller
> > + This is the language of the driver name that the caller
> > is requesting, and it must match one of the languages specified
> > in SupportedLanguages. The number of languages supported by a
> > driver is up to the driver writer.
> > @@ -108,7 +108,7 @@ SataControllerComponentNameGetDriverName (
> > that wishes to retrieve the name of a child controller.
> > @param Language A pointer to a three character ISO 639-2 language
> > identifier. This is the language of the controller name
> > - that that the caller is requesting, and it must match one
> > + that the caller is requesting, and it must match one
> > of the languages specified in SupportedLanguages. The
> > number of languages supported by a driver is up to the
> > driver writer.
> > diff --git a/OvmfPkg/SataControllerDxe/SataController.h
> > b/OvmfPkg/SataControllerDxe/SataController.h
> > index ad93ab1d98c3..cb1abacfdc0f 100644
> > --- a/OvmfPkg/SataControllerDxe/SataController.h
> > +++ b/OvmfPkg/SataControllerDxe/SataController.h
> > @@ -465,7 +465,7 @@ IdeInitSetTiming (
> >
> > @param This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> > instance.
> > @param Language A pointer to a three character ISO 639-2 language
> > identifier.
> > - This is the language of the driver name that that the caller
> > + This is the language of the driver name that the caller
> > is requesting, and it must match one of the languages specified
> > in SupportedLanguages. The number of languages supported by a
> > driver is up to the driver writer.
> > @@ -506,7 +506,7 @@ SataControllerComponentNameGetDriverName (
> > that wishes to retrieve the name of a child controller.
> > @param Language A pointer to a three character ISO 639-2 language
> > identifier. This is the language of the controller name
> > - that that the caller is requesting, and it must match one
> > + that the caller is requesting, and it must match one
> > of the languages specified in SupportedLanguages. The
> > number of languages supported by a driver is up to the
> > driver writer.
> > diff --git a/OvmfPkg/XenBusDxe/ComponentName.c
> > b/OvmfPkg/XenBusDxe/ComponentName.c
> > index 9141e9264fc9..a5622bfef93b 100644
> > --- a/OvmfPkg/XenBusDxe/ComponentName.c
> > +++ b/OvmfPkg/XenBusDxe/ComponentName.c
> > @@ -52,7 +52,7 @@ EFI_UNICODE_STRING_TABLE
> > mXenBusDxeControllerNameTable[] = {
> >
> > @param This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> > instance.
> > @param Language A pointer to a three-character ISO 639-2 language
> > identifier.
> > - This is the language of the driver name that that the caller
> > + This is the language of the driver name that the caller
> > is requesting, and it must match one of the languages specified
> > in SupportedLanguages. The number of languages supported by a
> > driver is up to the driver writer.
> > diff --git a/OvmfPkg/XenBusDxe/ComponentName.h
> > b/OvmfPkg/XenBusDxe/ComponentName.h
> > index 592c5426dd77..88f3fe5b017b 100644
> > --- a/OvmfPkg/XenBusDxe/ComponentName.h
> > +++ b/OvmfPkg/XenBusDxe/ComponentName.h
> > @@ -12,7 +12,7 @@
> >
> > @param This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> > instance.
> > @param Language A pointer to a three-character ISO 639-2 language
> > identifier.
> > - This is the language of the driver name that that the caller
> > + This is the language of the driver name that the caller
> > is requesting, and it must match one of the languages specified
> > in SupportedLanguages. The number of languages supported by a
> > driver is up to the driver writer.
> > diff --git a/OvmfPkg/XenPvBlkDxe/BlockFront.c
> > b/OvmfPkg/XenPvBlkDxe/BlockFront.c
> > index 7aa5ef044be0..1827cc58e390 100644
> > --- a/OvmfPkg/XenPvBlkDxe/BlockFront.c
> > +++ b/OvmfPkg/XenPvBlkDxe/BlockFront.c
> > @@ -88,7 +88,7 @@ XenPvBlockFree (
> > }
> >
> > /**
> > - Wait until until the backend has reached the ExpectedState.
> > + Wait until the backend has reached the ExpectedState.
> >
> > @param Dev A XEN_BLOCK_FRONT_DEVICE instance.
> > @param ExpectedState The backend state expected.
> > diff --git a/OvmfPkg/XenPvBlkDxe/ComponentName.c
> > b/OvmfPkg/XenPvBlkDxe/ComponentName.c
> > index 6a27822749aa..f1fd7830fb1d 100644
> > --- a/OvmfPkg/XenPvBlkDxe/ComponentName.c
> > +++ b/OvmfPkg/XenPvBlkDxe/ComponentName.c
> > @@ -52,7 +52,7 @@ EFI_UNICODE_STRING_TABLE
> > mXenPvBlkDxeControllerNameTable[] = {
> >
> > @param This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> > instance.
> > @param Language A pointer to a three-character ISO 639-2 language
> > identifier.
> > - This is the language of the driver name that that the caller
> > + This is the language of the driver name that the caller
> > is requesting, and it must match one of the languages specified
> > in SupportedLanguages. The number of languages supported by a
> > driver is up to the driver writer.
> > diff --git a/OvmfPkg/XenPvBlkDxe/ComponentName.h
> > b/OvmfPkg/XenPvBlkDxe/ComponentName.h
> > index 12ea12601d7f..cd897966931f 100644
> > --- a/OvmfPkg/XenPvBlkDxe/ComponentName.h
> > +++ b/OvmfPkg/XenPvBlkDxe/ComponentName.h
> > @@ -12,7 +12,7 @@
> >
> > @param This A pointer to the EFI_COMPONENT_NAME_PROTOCOL
> > instance.
> > @param Language A pointer to a three-character ISO 639-2 language
> > identifier.
> > - This is the language of the driver name that that the caller
> > + This is the language of the driver name that the caller
> > is requesting, and it must match one of the languages specified
> > in SupportedLanguages. The number of languages supported by a
> > driver is up to the driver writer.
> > --
> > 2.25.1
>
next prev parent reply other threads:[~2022-09-05 13:55 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 16:00 [PATCH 00/24] Remove duplicated words PierreGondois
2022-08-23 16:00 ` [PATCH 01/24] .pytool: " PierreGondois
2022-08-23 16:00 ` [PATCH 02/24] ArmPkg: " PierreGondois
2022-08-23 17:13 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:28 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 03/24] ArmPlatformPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-08-24 13:26 ` Leif Lindholm
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 04/24] ArmVirtPkg: " PierreGondois
2022-08-23 17:12 ` [edk2-devel] " Sami Mujawar
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 05/24] BaseTools: " PierreGondois
2022-08-23 16:00 ` [PATCH 06/24] CryptoPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 07/24] DynamicTablesPkg: " PierreGondois
2022-08-23 17:09 ` Sami Mujawar
2022-08-23 16:00 ` [PATCH 08/24] EmbeddedPkg: " PierreGondois
2022-08-24 13:29 ` Leif Lindholm
2022-08-24 13:31 ` Chang, Abner
2022-09-05 13:54 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 09/24] EmulatorPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 10/24] FatPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 11/24] IntelFsp2WrapperPkg: " PierreGondois
2022-08-23 16:55 ` Chiu, Chasel
2022-09-01 23:18 ` [edk2-devel] " Nate DeSimone
2022-09-01 23:24 ` Nate DeSimone
2022-08-23 16:00 ` [PATCH 12/24] MdeModulePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 13/24] MdePkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 14/24] NetworkPkg: " PierreGondois
2022-09-02 14:31 ` [edk2-devel] " Maciej Rabeda
2022-08-23 16:00 ` [PATCH 15/24] OvmfPkg: " PierreGondois
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel [this message]
2022-08-23 16:00 ` [PATCH 16/24] PcAtChipsetPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 17/24] RedfishPkg: " PierreGondois
2022-08-24 13:32 ` Chang, Abner
2022-08-23 16:00 ` [PATCH 18/24] SecurityPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 19/24] ShellPkg: " PierreGondois
2022-08-24 5:34 ` Gao, Zhichao
2022-08-23 16:00 ` [PATCH 20/24] SourceLevelDebugPkg: " PierreGondois
2022-08-24 0:50 ` Wu, Hao A
2022-08-24 1:06 ` [edk2-devel] " Ni, Ray
2022-08-23 16:00 ` [PATCH 21/24] StandaloneMmPkg: " PierreGondois
2022-08-23 17:11 ` Sami Mujawar
2022-08-23 23:00 ` Yao, Jiewen
2022-09-05 13:55 ` Ard Biesheuvel
2022-08-23 16:00 ` [PATCH 22/24] UefiCpuPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 23/24] UefiPayloadPkg: " PierreGondois
2022-08-23 16:00 ` [PATCH 24/24] UnitTestFrameworkPkg: " PierreGondois
2022-08-25 3:12 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXEdm05+Hj=FZEtuaZBRvComXhbLQ8sMrm8c3tN6Q-T8iA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox