From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web10.110327.1671038820168816994 for ; Wed, 14 Dec 2022 09:27:00 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LC4i/nmM; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D15D1B819B3 for ; Wed, 14 Dec 2022 17:26:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AF22C43396 for ; Wed, 14 Dec 2022 17:26:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671038816; bh=j5OXXK426BBFCFH6NhrXE+/fQVEnFodN5V2EZjWd6Sw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LC4i/nmMHzl2y7U2X+joi+qtVZnKuY0l/H1+NqN4HCQIyifNLW4uOBB+2catpmelO RINM0MM8ObwYjGs06kOOOIKHqi8JR8CP76mUVfFPBPrvPlNtK0gvvBXC5C97OD+C+P PwFuX7TaBEKXwBq9rPSH7LG4/mKxn11vtFrCJCxVj+Y9jrMifWkvAt8DZgjw34NuOy uUxYDfGEEZBVoWSEHhxjwt0DeDKNRbooZKzI4npg+Nxj1yY6qNnEQU3BOKrAcAcb29 vfl5v8mrlwe1c3weNfLF+2ye7JUJVfF50pZBO0Gp6nCVHv258ylUWxjOhnzZvfkCEh ePdCs7m5jUa3g== Received: by mail-lj1-f177.google.com with SMTP id f16so7299167ljc.8 for ; Wed, 14 Dec 2022 09:26:56 -0800 (PST) X-Gm-Message-State: ANoB5pkZS/4zduLLR9Pgbl2WYTvV4Tq3Ql2GDzgJIbUIsIiWGNX5XRfT ELmGpkDoQS3ZSQBTGiE2CBMiUAjRH86+WsdyYpU= X-Google-Smtp-Source: AA0mqf4Cy2ZfHgQe8QD3nw3xKUwH7HnG+y+Qatra69ZeOZSpDs+MhgIIKLFRqOCRyY/X+iYX3y3xUpRZ/VE+mdDorMI= X-Received: by 2002:a2e:9546:0:b0:27b:54ad:6c59 with SMTP id t6-20020a2e9546000000b0027b54ad6c59mr871583ljh.352.1671038814400; Wed, 14 Dec 2022 09:26:54 -0800 (PST) MIME-Version: 1.0 References: <20221202131009.3190040-1-kraxel@redhat.com> <0b50afd4-cf0c-a8fd-443f-88a0f615a0ed@amd.com> In-Reply-To: <0b50afd4-cf0c-a8fd-443f-88a0f615a0ed@amd.com> From: "Ard Biesheuvel" Date: Wed, 14 Dec 2022 18:26:43 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/14] OvmfPkg: avoid global variables in PEI To: Tom Lendacky , Liming Gao , Bob Feng Cc: Gerd Hoffmann , devel@edk2.groups.io, Yuwei Chen , Erdem Aktas , Jordan Justen , Peter Grehan , Rebecca Cran , Ard Biesheuvel , Jiewen Yao , Min Xu , Brijesh Singh , Oliver Steffen , Pawel Polawski , James Bottomley Content-Type: text/plain; charset="UTF-8" On Mon, 12 Dec 2022 at 17:58, Tom Lendacky wrote: > > On 12/2/22 07:09, Gerd Hoffmann wrote: > > Writing to global variables changes the PEI firmware volume which in > > turn screws up firmware volume measurements. Fix OvmfPkg to avoid that, > > for the most part by using the PlatformInfoHob instead. > > Boot tested SEV, SEV-ES and SEV-SNP guests without issues. For the series: > > Tested-by: Tom Lendacky > Thanks, this look good to me so i'll pick up the OvmfPkg patches right away. Liming, Bob, any objections against the BaseTools/ patches? (#1 and #2)