From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web12.184.1620665877966444273
 for <devel@edk2.groups.io>;
 Mon, 10 May 2021 09:57:58 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GztZdgs6;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 588D2611CE
	for <devel@edk2.groups.io>; Mon, 10 May 2021 16:57:57 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1620665877;
	bh=DrQfyRcXsRjedwH30os4neURKYJFQl59ixT4Hy4b4bU=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=GztZdgs64hXbp8IQ+6lzUJ9y9dtsYRH0/NbQ9ueBm5owrvBggRb+y7zIo7aKAi6xr
	 LNrfH0AH9p6CTANEpgDaSKEi9y/TCZzALHwpdSqPXQd/tttn+V5/ACxXctLQ50YNsq
	 QM36mFHDaruft0uWXh+sU+gosGUpLiwj+E22mSDB7S8XXeeOqkO39bG6mbYqMG2dZU
	 NiMAfgFhRPWFRvL4dYnIq+hkv4v0iJ2t97/7Xp/Vo70z4mPeCsv2e+G/K/oBkxq9oH
	 pjQfBw0v251IctaXU9wg8J2INH1Bl/R3swNxa79s6WcE/K3bwkPqT56RvsVW/WCufp
	 39N+Ndf9+oQDw==
Received: by mail-oi1-f172.google.com with SMTP id u16so16399334oiu.7
        for <devel@edk2.groups.io>; Mon, 10 May 2021 09:57:57 -0700 (PDT)
X-Gm-Message-State: AOAM531wauCwwDxnYO1E8QxuXtz/bwtZQMQW+fLGjiORnIaRynKDbTAL
	xJk5LPjhbxVYVd9r0AvcA6Hy64NYjR5NgQNUFRg=
X-Google-Smtp-Source: ABdhPJxvX3F3bGG/g1GLNn0AdAdafvvLvWjQfhs3oM4Q7gbHKJsPTKHMLhhk8DOMS0nmDToTW9v4V7n5TDJ9vAbb/jA=
X-Received: by 2002:aca:e142:: with SMTP id y63mr18798477oig.33.1620665876765;
 Mon, 10 May 2021 09:57:56 -0700 (PDT)
MIME-Version: 1.0
References: <20210415192207.3257790-1-jeremy.linton@arm.com> <20210415192207.3257790-3-jeremy.linton@arm.com>
In-Reply-To: <20210415192207.3257790-3-jeremy.linton@arm.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 10 May 2021 18:57:45 +0200
X-Gmail-Original-Message-ID: <CAMj1kXEiJs28wZcAtk-_ekc+Vou3q15di3hODx9zbbjsDrnZNQ@mail.gmail.com>
Message-ID: <CAMj1kXEiJs28wZcAtk-_ekc+Vou3q15di3hODx9zbbjsDrnZNQ@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH 2/2] Platform/RaspberryPi: Increase genet dma window
To: edk2-devel-groups-io <devel@edk2.groups.io>, Jeremy Linton <jeremy.linton@arm.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>, Leif Lindholm <leif@nuviainc.com>, 
	Peter Batard <pete@akeo.ie>, Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>, 
	Andrei Warkentin <awarkentin@vmware.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 15 Apr 2021 at 21:22, Jeremy Linton <jeremy.linton@arm.com> wrote:
>
> The genet is capable of addressing the entire memory space
> on the RPI4. Lets allow it to dma into those regions.
> This solves intermittent issues with grub/etc being able
> to communicate when the 3G limit is lifted on 8G boards.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>


> ---
>  Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index ddf4dd6a41..facf34f034 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -698,7 +698,7 @@
>    Silicon/Broadcom/Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf {
>      <PcdsFixedAtBuild>
>        gEmbeddedTokenSpaceGuid.PcdDmaDeviceOffset|0x00000000
> -      gEmbeddedTokenSpaceGuid.PcdDmaDeviceLimit|0xffffffff
> +      gEmbeddedTokenSpaceGuid.PcdDmaDeviceLimit|0xffffffffff
>    }
>
>    #
> --
> 2.13.7
>
>
>
> 
>
>