From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web11.28640.1623670135708740020
 for <devel@edk2.groups.io>;
 Mon, 14 Jun 2021 04:28:55 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dPsCTztL;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0392361410
	for <devel@edk2.groups.io>; Mon, 14 Jun 2021 11:28:53 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1623670134;
	bh=tN3Cv6uHsgx1AxbJG8ORFiB21xhJjgAee/U0O4iCEmQ=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=dPsCTztLxWn8n3V7pcpGNm8+c705qEzJwJqn6q76tFgHYGCRIccF0QNq8MSTwroFd
	 aoW2SnhhM4k25dBHj9mYWyjXsa7tb7hK2yE4Eekzas11tPzrbWf2oQUrjJKWNOndZu
	 5G+IdOLqqTjro87i23hNspLibX6n9UJ6cnMkaHPxAh73YaOgGr5csnPnivUuIrerLc
	 A1Ozyh7Zs5yolmWkbf3FC9JJF6PfJhjOzqKdpZpvQ5ybEd7i1D+LIbQCFyQAUVxHgT
	 fGoTnLzpMQVlaPJUnCsN5TWIGD259OK9pMoNsu7nQXJCrjBalqnXaZtiwJCwZzrevp
	 cjQL7LKpJMgXQ==
Received: by mail-oi1-f176.google.com with SMTP id t140so14043058oih.0
        for <devel@edk2.groups.io>; Mon, 14 Jun 2021 04:28:53 -0700 (PDT)
X-Gm-Message-State: AOAM530Ix1pZt1or3k1XuudpRYHDYynXsLhIo4BWUIjzsuHEy5oe2cgn
	SvveIV9otqJGtyTivTepXi2XW/BcRBmWlyVb4d4=
X-Google-Smtp-Source: ABdhPJwqzKnepYsaPGrF0o8LES7rOZo8ySdFub+ZC42WI4Yq1r3CYlSAHH9X3Nsb2bt1bXVjH6QBBFyN3Vosk5Oc8lw=
X-Received: by 2002:aca:eb55:: with SMTP id j82mr9828067oih.174.1623670133321;
 Mon, 14 Jun 2021 04:28:53 -0700 (PDT)
MIME-Version: 1.0
References: <20210608135432.23420-1-rebecca@nuviainc.com> <CAMj1kXHmHmZYHo9wNRoWrAC3-s5rbYvN1gE2zesJQRWvz+DfOg@mail.gmail.com>
 <bc8e129b-ce0f-1574-646d-0be8b994571d@nuviainc.com>
In-Reply-To: <bc8e129b-ce0f-1574-646d-0be8b994571d@nuviainc.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 14 Jun 2021 13:28:42 +0200
X-Gmail-Original-Message-ID: <CAMj1kXEn9O11VtghqRrWXwhM8NvmKBdvWb-+Tf23qUDBzgdRZA@mail.gmail.com>
Message-ID: <CAMj1kXEn9O11VtghqRrWXwhM8NvmKBdvWb-+Tf23qUDBzgdRZA@mail.gmail.com>
Subject: Re: [PATCH 1/1] ArmPkg: Move cache defs used in Universal/Smbios into ArmLib.h
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Fri, 11 Jun 2021 at 00:44, Rebecca Cran <rebecca@nuviainc.com> wrote:
>
> On 6/10/21 9:04 AM, Ard Biesheuvel wrote:
> > On Tue, 8 Jun 2021 at 15:54, Rebecca Cran <rebecca@nuviainc.com> wrote:
> >> Many of the cache definitions in ArmLibPrivate.h are being used outside
> >> of ArmLib, in Universal/Smbios. Move them into ArmLib.h to make them
> >> public, and remove the include of ArmLibPrivate.h from files in
> >> Universal/Smbios.
> >>
> >> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
> > Hi Rebecca,
> >
> > If these definitions describe anything more than the software
> > interface exposed by the library, they really belong under
> > IndustryStandard/ not Library.
>
>
> It looks like I'd need to create a new file under
> ArmPkg/Include/IndustryStandard since the existing files don't look
> appropriate. I was wondering if a filename like ArmCache.h would be good?
>

Fine with me.