From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web12.1297.1651595172891657577 for ; Tue, 03 May 2022 09:26:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pjJ34JXY; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AA1836155E for ; Tue, 3 May 2022 16:26:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ABA0C385B2 for ; Tue, 3 May 2022 16:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651595171; bh=Ayb7yb+WuMEsNnUuFo+A7SoN5eT+H5bWMLKGywvdlcA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=pjJ34JXYESbMZdG8NIPGzI/C8HeKhi1UprzW1uiesU8sA7tCt97+uhaWFUTTgwMtQ 7Hrm6dEVY8eAbmWiF3922vCpqfeFhMLiUQfxl79TUT5VZ37psHeDQ4+BZQ4ZHejMSc rY2BR8Z7NEQwDRH+j+KqhajP8kcuhPMgP/gUfX0d4nFwPuJqEfNLbZ6G+rF5Gf0kwQ 7rNhJgizBZNoF/J/yMXGSAp9ikfZQHZbflcnmgxP4eXyT423yY/d5tyVd+uas31Jq/ 2xaOnMJTssftarpvvaC0WSxJ0NAH66Zp7kPOtAj+swRQNDo0vKPrkNtLdJHA1hUmPR ikJHLjSx6uMGQ== Received: by mail-oi1-f169.google.com with SMTP id m11so18663622oib.11 for ; Tue, 03 May 2022 09:26:11 -0700 (PDT) X-Gm-Message-State: AOAM53361VzGKhkbVyDAqreBPpRdbYR7oGw3JunHEWpLPg+b4Y+ZunQf b5iX8Axl+5opUITk15XpFdDqtOIGo5Cy4YS4N6M= X-Google-Smtp-Source: ABdhPJy7jdh5DPct+zUtWCAI6G3w+dUCjFzf3K+rU2cQcB5I1S1PFRlm9bdIV6IuaVmlIVsBmDsxMZDmShYlWIbBTKU= X-Received: by 2002:a05:6808:e8d:b0:322:bac0:2943 with SMTP id k13-20020a0568080e8d00b00322bac02943mr2170007oil.126.1651595170103; Tue, 03 May 2022 09:26:10 -0700 (PDT) MIME-Version: 1.0 References: <16E62E6A940424A8.9469@groups.io> <16EB65B9C6B20F3F.8534@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 3 May 2022 18:25:58 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/OvmfPkg*.dsc: Increase ACPI Reclaim memory size To: edk2-devel-groups-io , annie.li@oracle.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , "kraxel@redhat.com >> Gerd Hoffmann" , Karl Franz Heubaum , Aaron Young Content-Type: text/plain; charset="UTF-8" On Tue, 3 May 2022 at 17:54, annie li wrote: > > Adding maintainers into the CC list... > > On 5/2/2022 5:05 PM, annie li wrote: > > Hello > > > > I am wondering if anyone will review this patch please? Any comments > > are welcome. > > > > Thanks > > > > Annie > > > > On 4/15/2022 5:15 PM, annie li wrote: > >> The current ACPI Reclaim memory size is set as 0x10(64k). The > >> ACPI table size will be increased if the memory slots' number of > >> the guest gets increased. In the guest with more memory slots, > >> the ACPI Reclaim memory size may not be sufficient for hibernation. > >> This may cause resume failure of the hibernated guest that was > >> booted up with a fresh copied writable OVMF_VARS file. However, > >> the failure doesn't happen in following hibernation/resume > >> cycles. > >> > >> The ACPI_MAX_RAM_SLOTS is set as 256 in the current QEMU. With > >> ACPI_MAX_RAM_SLOTS, 18 pages are required to be allocated in ACPI > >> Reclaim memory. However, due to the 0x10(16 pages) setting, 2 extra > >> pages will be allocated in other space. This may break the > >> hibernation/resume in the above scenario. > >> > >> This patch increases the ACPI Reclaim memory size to 0x12, i.e. > >> PcdMemoryTypeEfiACPIReclaimMemory is set as 0x12(18 pages). > >> > >> Signed-off-by: Annie Li > >> --- > >> OvmfPkg/OvmfPkgIa32.dsc | 2 +- > >> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > >> OvmfPkg/OvmfPkgX64.dsc | 2 +- > >> 3 files changed, 3 insertions(+), 3 deletions(-) > >> No objections from me but before merging this, I'll give the other folks the opportunity to chime in as well. > >> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > >> index 29eea82571..fb158f98c9 100644 > >> --- a/OvmfPkg/OvmfPkgIa32.dsc > >> +++ b/OvmfPkg/OvmfPkgIa32.dsc > >> @@ -547,7 +547,7 @@ > >> # unknown) workloads / boot paths. > >> > >> # > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > >> > >> - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > >> > >> + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 > >> > >> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > >> index 56d3c49ab2..30d47ca28a 100644 > >> --- a/OvmfPkg/OvmfPkgIa32X64.dsc > >> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > >> @@ -552,7 +552,7 @@ > >> # unknown) workloads / boot paths. > >> > >> # > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > >> > >> - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > >> > >> + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 > >> > >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > >> index f0924c0f9d..6c10ceedd7 100644 > >> --- a/OvmfPkg/OvmfPkgX64.dsc > >> +++ b/OvmfPkg/OvmfPkgX64.dsc > >> @@ -552,7 +552,7 @@ > >> # unknown) workloads / boot paths. > >> > >> # > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > >> > >> - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > >> > >> + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > >> > >> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 > >> > > > > > > > > > > > > > > >