public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: Rebecca Cran <rebecca@bsdio.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Thomas Abraham <thomas.abraham@arm.com>,
	 Sami Mujawar <sami.mujawar@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: JunoPkg ARM build breakage: "Error: bad instruction `aarch64_bti(c)'"
Date: Wed, 10 May 2023 18:27:00 +0200	[thread overview]
Message-ID: <CAMj1kXEo2-A9NMys7PhzE6XfJdLCMSnOeK5ZbQXP8amCfAK_8g@mail.gmail.com> (raw)
In-Reply-To: <45c61530-3cf4-f1bf-4ff1-b7bf242dbddb@bsdio.com>

Hi Rebecca,

On Wed, 10 May 2023 at 18:23, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> I ran my script that tries to build all Arm platforms in edk2-platforms
> (with the exception of known broken ones) with the GCC5/GCC toolchain,
> and noticed a new breakage since I last ran it a few months ago.
>
> Building JunoPkg for ARM doesn't work.
>
> I also noticed it passes both -march=armv7-a and -march=armv8-a.
>

This looks like a bug in the Juno package - if I grep for aarch64_bti
in edk2, every single hit is in a aarch64 specific source or header
file, but it is getting pulled into an ARM build.

Does the below help?

diff --git a/Platform/ARM/Library/ArmShellCmdRunAxf/Arm/Pivot.S
b/Platform/ARM/Library/ArmShellCmdRunAxf/Arm/Pivot.S
index 50efcfacdfe6..7d5eed94b25f 100644
--- a/Platform/ARM/Library/ArmShellCmdRunAxf/Arm/Pivot.S
+++ b/Platform/ARM/Library/ArmShellCmdRunAxf/Arm/Pivot.S
@@ -4,7 +4,7 @@
 //  SPDX-License-Identifier: BSD-2-Clause-Patent
 //

-#include <AsmMacroIoLibV8.h>
+#include <AsmMacroIoLib.h>

 // VOID
 // RunAxfPivot (



>
> "arm-none-eabi-gcc" -march=armv7-a -mfloat-abi=soft -march=armv8-a -c -x
> assembler -imacros AutoGen.h -mlittle-endian -o
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/Platform/ARM/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf/OUTPUT/Arm/Pivot.obj
> -I/home/bcran/src/uefi/edk2-platforms/Platform/ARM/Library/ArmShellCmdRunAxf/Arm
> -I/home/bcran/src/uefi/edk2-platforms/Platform/ARM/Library/ArmShellCmdRunAxf
> -I/home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/Platform/ARM/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf/DEBUG
> -I/home/bcran/src/uefi/edk2/ArmPkg
> -I/home/bcran/src/uefi/edk2/ArmPkg/Include
> -I/home/bcran/src/uefi/edk2/MdeModulePkg
> -I/home/bcran/src/uefi/edk2/MdeModulePkg/Test/Mock/Include
> -I/home/bcran/src/uefi/edk2/MdeModulePkg/Include
> -I/home/bcran/src/uefi/edk2/MdePkg
> -I/home/bcran/src/uefi/edk2/MdePkg/Include
> -I/home/bcran/src/uefi/edk2/MdePkg/Test/UnitTest/Include
> -I/home/bcran/src/uefi/edk2/MdePkg/Test/Mock/Include
> -I/home/bcran/src/uefi/edk2/MdePkg/Include/Arm
> -I/home/bcran/src/uefi/edk2-platforms/Platform/ARM
> -I/home/bcran/src/uefi/edk2-platforms/Platform/ARM/Include
> -I/home/bcran/src/uefi/edk2/ShellPkg
> -I/home/bcran/src/uefi/edk2/ShellPkg/Include
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/Platform/ARM/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf/OUTPUT/Arm/Pivot.iiii
> Trim --trim-long --source-code -o
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe/OUTPUT/Arm/CopyMem.iiii
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe/OUTPUT/Arm/CopyMem.ii
> Trim --trim-long --source-code -o
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib/OUTPUT/Arm/ctzsi2.iiii
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib/OUTPUT/Arm/ctzsi2.ii
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/Platform/ARM/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf/OUTPUT/Arm/Pivot.iiii:
> Assembler messages:
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/Platform/ARM/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf/OUTPUT/Arm/Pivot.iiii:17:
> Error: bad instruction `aarch64_bti(c)'
> make: *** [GNUmakefile:363:
> /home/bcran/src/uefi/Build/ArmJuno/RELEASE_GCC5/ARM/Platform/ARM/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf/OUTPUT/Arm/Pivot.obj]
> Error 1
>
>
> --
> Rebecca Cran
>

  reply	other threads:[~2023-05-10 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 16:23 JunoPkg ARM build breakage: "Error: bad instruction `aarch64_bti(c)'" Rebecca Cran
2023-05-10 16:27 ` Ard Biesheuvel [this message]
2023-05-10 16:52   ` Rebecca Cran
2023-05-10 16:54     ` Ard Biesheuvel
2023-05-10 17:06       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXEo2-A9NMys7PhzE6XfJdLCMSnOeK5ZbQXP8amCfAK_8g@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox