From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web12.10083.1658508887301511246 for ; Fri, 22 Jul 2022 09:54:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=la+lZGTD; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F4DD620AE for ; Fri, 22 Jul 2022 16:54:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F408EC385A2 for ; Fri, 22 Jul 2022 16:54:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658508886; bh=QHlwOEkgDJ2pMqam408rCwqdCvvHYN/of4US9Oqlmz8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=la+lZGTDHCxPMqKv6K//oKCUXJDcApoaMZTwDSoVYP6n/NCSH1NN1bYmIsfhMXvjk MyvS4AO1D1DpzXF8JD/iiXz0XY0eFRDvYKJomRh2LwTtqilGdS8eCXvrwzGg5SnkuE K3EnSc82KF23i1Eh/NWlB1dTC7nuj0p86PTujeD7DzzmJnW5VGxARH62V0fOY8oXJM c7gNMaDC7k7rsV2UVeOcYiA8flT+K64aL2BmSy4UQ6IUncrvf+hqHTESVRm+yYl5k9 mfOu0DjSCojFGwG8GntzeeiO8c722BjxRu5yMLkzmDUEUZUamUi+mtERkWV4FUBabg dpIESG4AFGELw== Received: by mail-ot1-f51.google.com with SMTP id z12-20020a056830128c00b0061c8168d3faso3756555otp.7 for ; Fri, 22 Jul 2022 09:54:45 -0700 (PDT) X-Gm-Message-State: AJIora9kSsMjo6/5THMPwU62iKvTWMG6ak5c96oeP2NWS757zUASaOjP AckC4yG5KczQX86gKp87Dd4CPA+VjjNb85lTlpU= X-Google-Smtp-Source: AGRyM1vIn+umg6JUS6n4eUs4KGaS2jl3dpmmz0xoVV7AFf4iiWZbny+BY9xRQNKWjDCIT8emIkqTXGoz1+/5R2mx9uM= X-Received: by 2002:a05:6830:441f:b0:61c:a5bb:9c6a with SMTP id q31-20020a056830441f00b0061ca5bb9c6amr319593otv.265.1658508885015; Fri, 22 Jul 2022 09:54:45 -0700 (PDT) MIME-Version: 1.0 References: <163911902995.561661.9429300579159746333.stgit@localhost> <163911907249.561661.11382999726925773930.stgit@localhost> <16F1A3225F3A2D28.18186@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 22 Jul 2022 18:54:34 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v3 5/6] [edk2-platforms] Silicon/SynQuacer: add DBG2 ACPI table To: edk2-devel-groups-io , Masahisa Kojima Cc: Leif Lindholm , Ard Biesheuvel , Kazuhiko Sakamoto , Jaswinder Singh Content-Type: text/plain; charset="UTF-8" On Tue, 12 Jul 2022 at 03:43, Masahisa Kojima wrote: > > Hi Leif, Ard, > > A gentle ping again on this. > Merged as 2f5e841018d9..86759a1bf829 My apologies for the delay. -- Ard. > > > On Mon, 23 May 2022 at 13:58, Masahisa Kojima via groups.io > wrote: > > > > Hi Leif, Ard, > > > > A gentle ping on this on behalf of Masami, since he left Linaro. > > > > Thanks, > > Masahisa Kojima > > > > > > On Fri, 10 Dec 2021 at 15:51, Masami Hiramatsu > > wrote: > > > > > > Add DBG2 table to ACPI tables. The COM1 uart port will be used > > > for OS debug, and it is 16550 compatible. > > > > > > Signed-off-by: Masami Hiramatsu > > > --- > > > Changes in v2: > > > - Move Dbg2.aslc before Dsdt.asl to keep the list alphabetically sorted. > > > - Use EFI_ACPI_6_3_SYSTEM_MEMORY and EFI_ACPI_6_3_BYTE for initialization. > > > --- > > > .../Socionext/SynQuacer/AcpiTables/AcpiTables.inf | 1 > > > Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc | 70 ++++++++++++++++++++ > > > 2 files changed, 71 insertions(+) > > > create mode 100644 Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc > > > > > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf b/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > > > index 886777a0fa..e77d7a3056 100644 > > > --- a/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > > > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/AcpiTables.inf > > > @@ -19,6 +19,7 @@ > > > [Sources] > > > AcpiTables.h > > > AcpiSsdtRootPci.asl > > > + Dbg2.aslc > > > Dsdt.asl > > > Fadt.aslc > > > Gtdt.aslc > > > diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc b/Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc > > > new file mode 100644 > > > index 0000000000..89c9dbd998 > > > --- /dev/null > > > +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dbg2.aslc > > > @@ -0,0 +1,70 @@ > > > +/** @file > > > +* Debug Port Table (DBG2) > > > +* > > > +* Copyright (c) 2020,2021 Linaro Ltd. All rights reserved. > > > +* > > > +* SPDX-License-Identifier: BSD-2-Clause-Patent > > > +* > > > +**/ > > > +#include > > > +#include > > > +#include > > > +#include > > > +#include > > > + > > > +#include "AcpiTables.h" > > > + > > > +#pragma pack(1) > > > + > > > +#define SYNQUACER_UART1_STR { '\\', '_', 'S', 'B', '.', 'C', 'O', 'M', '1', 0x00 } > > > +#define SQ_GAS32(Address) { EFI_ACPI_6_3_SYSTEM_MEMORY, 32, 0, EFI_ACPI_6_3_BYTE, Address } > > > + > > > +typedef struct { > > > + EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT Dbg2Device; > > > + EFI_ACPI_6_3_GENERIC_ADDRESS_STRUCTURE BaseAddressRegister; > > > + UINT32 AddressSize; > > > + UINT8 NameSpaceString[10]; > > > +} DBG2_DEBUG_DEVICE_INFORMATION; > > > + > > > +typedef struct { > > > + EFI_ACPI_DEBUG_PORT_2_DESCRIPTION_TABLE Description; > > > + DBG2_DEBUG_DEVICE_INFORMATION Dbg2DeviceInfo; > > > +} DBG2_TABLE; > > > + > > > + > > > +STATIC DBG2_TABLE Dbg2 = { > > > + { > > > + __ACPI_HEADER ( > > > + EFI_ACPI_6_3_DEBUG_PORT_2_TABLE_SIGNATURE, > > > + DBG2_TABLE, > > > + EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT_REVISION > > > + ), > > > + OFFSET_OF (DBG2_TABLE, Dbg2DeviceInfo), > > > + 1 /* NumberOfDebugPorts */ > > > + }, > > > + { > > > + { > > > + EFI_ACPI_DBG2_DEBUG_DEVICE_INFORMATION_STRUCT_REVISION, > > > + sizeof (DBG2_DEBUG_DEVICE_INFORMATION), > > > + 1, /* NumberofGenericAddressRegisters */ > > > + 10, /* NameSpaceStringLength */ > > > + OFFSET_OF (DBG2_DEBUG_DEVICE_INFORMATION, NameSpaceString), > > > + 0, /* OemDataLength */ > > > + 0, /* OemDataOffset */ > > > + EFI_ACPI_DBG2_PORT_TYPE_SERIAL, > > > + EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS, > > > + {EFI_ACPI_RESERVED_BYTE, EFI_ACPI_RESERVED_BYTE}, > > > + OFFSET_OF (DBG2_DEBUG_DEVICE_INFORMATION, BaseAddressRegister), > > > + OFFSET_OF (DBG2_DEBUG_DEVICE_INFORMATION, AddressSize) > > > + }, > > > + SQ_GAS32 (SYNQUACER_UART1_BASE), /* BaseAddressRegister */ > > > + SYNQUACER_UART1_SIZE, /* AddressSize */ > > > + SYNQUACER_UART1_STR, /* NameSpaceString */ > > > + } > > > +}; > > > + > > > +#pragma pack() > > > + > > > +// Reference the table being generated to prevent the optimizer from removing > > > +// the data structure from the executable > > > +VOID* CONST ReferenceAcpiTable = &Dbg2; > > > > > > > > > > > > > > > > > >