From: "Ard Biesheuvel" <ardb@kernel.org>
To: Sunny Wang <Sunny.Wang@arm.com>
Cc: devel@edk2.groups.io,
Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Pierre Gondois <Pierre.Gondois@arm.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table
Date: Mon, 22 Mar 2021 09:07:29 +0100 [thread overview]
Message-ID: <CAMj1kXEpcR5OqkurB40XWL_DSRYdSzwNyAZBAWCkHD-wTctq-Q@mail.gmail.com> (raw)
In-Reply-To: <20210322061221.1407-1-Sunny.Wang@arm.com>
On Mon, 22 Mar 2021 at 07:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
>
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
>
Compatible
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> index c17c74e174..61353213fe 100644
> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> @@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
> // UART PL011
> Device(COM0) {
> Name(_HID, "ARMH0011")
> - Name(_CID, "PL011")
> Name(_UID, Zero)
> Name(_CRS, ResourceTemplate() {
> Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
> --
> 2.31.0.windows.1
>
next prev parent reply other threads:[~2021-03-22 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 6:12 [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table Sunny Wang
2021-03-22 8:07 ` Ard Biesheuvel [this message]
2021-03-22 10:35 ` Sami Mujawar
2021-03-23 3:37 ` [edk2-devel] " Sunny Wang
-- strict thread matches above, loose matches on Subject: below --
2021-03-23 3:19 Sunny Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEpcR5OqkurB40XWL_DSRYdSzwNyAZBAWCkHD-wTctq-Q@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox