From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
 by mx.groups.io with SMTP id smtpd.web12.9815.1616400463352354155
 for <devel@edk2.groups.io>;
 Mon, 22 Mar 2021 01:07:43 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TvmVcHnr;
 spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org)
Received: by mail.kernel.org (Postfix) with ESMTPSA id 0196461970
	for <devel@edk2.groups.io>; Mon, 22 Mar 2021 08:07:41 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1616400462;
	bh=1h3cQPTzlOE7CEO4obxV6zFdrNPr0yVJRQ4jWfIh6Lk=;
	h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
	b=TvmVcHnrso4QISCqQGdg0GgQEPX1nc9kCABuzwSkSksTvY3ZjtQuCGI0Dot4Md64X
	 gVwPu3kI+fW9jV6TMbwHgI4hd8/OEHRnPUH9arnenwMKVxB1GjTQt8FqiRJdJnXoGR
	 K+EvYkmR+o1lXxrF7FzJZnhZOcyIZaslR2BZTiR7eZKWUkDeM0qFMn2XjSXlOTll/g
	 VvRg4v0oU0r0X17HH31wjddGhV0DNgW51C5rkV2a0f5le0ZcYnXJH3m2x8TVXgoMtY
	 jXGu53HF4dVEY6kXnJjFCaII4vOuTiZ8hq/wpV3hfcE2QcRucrSakqXJGdljaicPGV
	 S38UPy2tR+ljw==
Received: by mail-oi1-f169.google.com with SMTP id i3so12151124oik.7
        for <devel@edk2.groups.io>; Mon, 22 Mar 2021 01:07:41 -0700 (PDT)
X-Gm-Message-State: AOAM531oGDXITsKYw/fKU9rxFnNilKIpmmbocAAoHbUUzckSeFgeW+TA
	0BC8doF8SuzKEuZWvmuUmihYaodJoMhTz/n9ypU=
X-Google-Smtp-Source: ABdhPJxkpP8t2NTtOYOVJ5+hQsJuxvEEQybZMdbum23VA8LNAu9oRhL7uabuBUcaQPFPsSMOZ71iFxBMGpAHrkar8HA=
X-Received: by 2002:aca:1a01:: with SMTP id a1mr9058812oia.33.1616400461222;
 Mon, 22 Mar 2021 01:07:41 -0700 (PDT)
MIME-Version: 1.0
References: <20210322061221.1407-1-Sunny.Wang@arm.com>
In-Reply-To: <20210322061221.1407-1-Sunny.Wang@arm.com>
From: "Ard Biesheuvel" <ardb@kernel.org>
Date: Mon, 22 Mar 2021 09:07:29 +0100
X-Gmail-Original-Message-ID: <CAMj1kXEpcR5OqkurB40XWL_DSRYdSzwNyAZBAWCkHD-wTctq-Q@mail.gmail.com>
Message-ID: <CAMj1kXEpcR5OqkurB40XWL_DSRYdSzwNyAZBAWCkHD-wTctq-Q@mail.gmail.com>
Subject: Re: [PATCH] Platform/ARM/Juno: Remove bogus PL011 _CID from DSDT ACPI table
To: Sunny Wang <Sunny.Wang@arm.com>
Cc: devel@edk2.groups.io, Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>, 
	Sami Mujawar <sami.mujawar@arm.com>, Pierre Gondois <Pierre.Gondois@arm.com>, 
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Mon, 22 Mar 2021 at 07:13, Sunny Wang <Sunny.Wang@arm.com> wrote:
>
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.
>

Compatible

> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Pierre Gondois <Pierre.Gondois@arm.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> index c17c74e174..61353213fe 100644
> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
> @@ -256,7 +256,6 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
>      // UART PL011
>      Device(COM0) {
>        Name(_HID, "ARMH0011")
> -      Name(_CID, "PL011")
>        Name(_UID, Zero)
>        Name(_CRS, ResourceTemplate() {
>          Memory32Fixed(ReadWrite, 0x7FF80000, 0x1000)
> --
> 2.31.0.windows.1
>