From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by mx.groups.io with SMTP id smtpd.web09.17619.1643540499802791810 for ; Sun, 30 Jan 2022 03:01:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pMikIhan; spf=pass (domain: kernel.org, ip: 145.40.73.55, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 3C772CE0E7A for ; Sun, 30 Jan 2022 11:01:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F6D0C36AE2 for ; Sun, 30 Jan 2022 11:01:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643540494; bh=uvnV4ggp8zLlYu23tjNEU/bMgpXUF8tahvurrHGHQYw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=pMikIhanpEymGlEGPHcOz4RMKcyl+EHRBnCohEvbcSqq5uBQhIQGKeRpmDYErUveS P1TqiCn3I3RSgSZ9GN6QOAtvj1inxeCDGh/KH4mQ2Igp6mFfGGeGMwNIRmJIc3PPP9 XmoCr2SC9C3H0Fl28WAFVxzHu5vTu/wEfl35lAU8CEuzMUZ39BWyDD9GTl54kCW0hg 9wsHg39/WNG4RjNDSY7xO1NWzhOsFQqlF/nAjItbNUhdZhlIMYWz0pULbtx86W+67x eqbX8mL3ENu9CMauMtYa94gF7wEECd7hM4fRUHkp4ZkIDV6M21ZV6ZYHjOKJO6OEfB 51L3TXRmwmNBA== Received: by mail-wr1-f51.google.com with SMTP id s18so19826355wrv.7 for ; Sun, 30 Jan 2022 03:01:34 -0800 (PST) X-Gm-Message-State: AOAM531eocxIud9yx729yktGz376NgnyQyxiFpUQXMg5Sn4kqa53FJUm 0DHIX3FAPR2EuRoRRD0bf4oc65KkK0qHYyuiUZk= X-Google-Smtp-Source: ABdhPJwkiXZ3uxJSFIXi1h/CN3z71ahCzl2NAl38JcsvN7Ng8/atNXUqTPq3ocb1rtlU7sGmt11X3ZWUN0+Nc/bsW78= X-Received: by 2002:a05:6000:1c9:: with SMTP id t9mr13589646wrx.550.1643540492754; Sun, 30 Jan 2022 03:01:32 -0800 (PST) MIME-Version: 1.0 References: <20211216220800.9628-1-rebecca@nuviainc.com> In-Reply-To: <20211216220800.9628-1-rebecca@nuviainc.com> From: "Ard Biesheuvel" Date: Sun, 30 Jan 2022 12:01:21 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 00/17] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 To: Rebecca Cran Cc: edk2-devel-groups-io , Ard Biesheuvel , Samer El-Haj-Mahmoud , Leif Lindholm , Sami Mujawar , Wenyi Xie , Peng Xie , Ling Jia , Yiqi Shu , Nhi Pham , Vu Nguyen , Thang Nguyen , Chuong Tran , Pete Batard , Masami Hiramatsu , Graeme Gregory , Radoslaw Biernacki , Marcin Wojtas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 16 Dec 2021 at 23:08, Rebecca Cran wrote: > > Changes from v1: > > Fixed Platform/SoftIron, Platform/RaspberryPi, Silicon/AMD, > Silicon/Ampere, Silicon/Phytium, Silicon/Hisilicon. > > Patches 1/17 through 8/17 are the same as v1. > > -------- > > The following platforms are already broken: > > o Drivers/OptionRomPkg/OptionRomPkg.dsc for AARCH64 and ARM: due to Optio= nRomPkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf. > > o Features/Ext4Pkg/Ext4Pkg.dsc for ARM: edk2-platforms/Features/Ext4Pkg/E= xt4Dxe/Inode.c:341: undefined reference to `__aeabi_uidivmod') > > o Platform/ARM/SgiPkg/RdN1Edge/RdN1Edge.dsc for ARM > > o Platform/Hisilicon/{D03,D05,D06} for AARCH64: Platform/Hisilicon/D03/Li= brary/OemMiscLib2P/BoardFeature2PHi1610.c:50:18: error: =E2=80=98EmHilink0H= ccs1X8Width16=E2=80=99 undeclared here (not in a function)) > > o Silicon/Marvell/Armada7k8k/Armada7k8kCapsule.dscfor AARCH64 and ARM: er= ror C0DE: Unknown fatal error when processing [Silicon/Marvell/Armada7k8k/A= rmada7k8kCapsule.dsc] > > o Platform/ARM/SgiPkg/RdE1Edge/RdE1Edge.dsc for ARM. > > o Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc for ARM. > > o Platform/ARM/SgiPkg/RdN2/RdN2.dsc for ARM. > > o Platform/ARM/SgiPkg/RdV1/RdV1.dsc for ARM. > > o Platform/ARM/SgiPkg/RdV1Mc/RdV1Mc.dsc for ARM. > > o Platform/ARM/SgiPkg/Sgi575/Sgi575.dsc for ARM. > > o Platform/Comcast/RDKQemu/RDKQemu.dsc for AARCH64 and ARM due to ACPI > issue. > > o Platform/Marvell/Cn913xDb/Cn913xDbA.dsc for AARCH64 and ARM: tries to > use literal $(PLATFORM_NAME). > > o Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc for AARCH6= 4 > and ARM: VariablePolicyHelperLib issue. > > o Platform/SolidRun/Cn913xCEx7Eval/Cn913xCEx7Eval.dsc for AARCH64 and ARM= : > T91 not found. > > -------- > > This patch series depends on the "Add EFI_MP_SERVICES_PROTOCOL support > for AARCH64" series which is in the process of being reviewed. > > With the addition of EFI_MP_SERVICES_PROTOCOL support for Arm, consumers > of ArmPkg/Drivers/CpuDxe now need an instance of MpInitLib. This series > adds ArmPkg/Library/MpInitLib/DxeMpInitLib.inf. > > Also, the ARM_CORE_INFO struct has changed so there's now an MPIDR field > where there were previously separate cluster and core fields. This > series updates the initializers and other code for the various instances. > I have pushed the ones that update the uses of ARM_CORE_INFO. The remaining ones are hopefully unneeded if we make the MP services protocol a separate driver. > > Rebecca Cran (17): > Platform/ARM: Add MpInitLib instance > Platform/Socionext: Add instance of MpInitLib > Silicon/Marvell: Add instance of MpInitLib > Platform/Qemu: Add instance of MpInitLib > Platform/ARM: Update ARM_CORE_INFO initializer for MPIDR field change > Silicon/Marvell: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Socionext: Update ARM_CORE_INFO initializer for MPIDR field > change > Silicon/Qemu: Update ARM_CORE_INFO initializer for MPIDR field change > Platform/AMD: Add instance of MpInitLib to OverdriveBoard.dsc > Platform/SoftIron: Add instance of MpInitLib to Overdrive1000Board.dsc > Platform/RaspberryPi: Add instance of MpInitLib to RPi3.dsc and > RPi4.dsc > Silicon/AMD: Update Styx code to work with changes ARM_CORE_INFO > struct > Silicon/Ampere: Add instance of MpInitLib to AmpereAltraPkg.dsc > Silicon/Ampere: Update ArmPlatformLib to work with changed > ARM_CORE_INFO > Silicon/Phytium: Add instance of MpInitLib to PhytiumCommonPkg.dsc.inf > Silicon/Phytium: Update FT2000-4Pkg PlatformLib for ARM_CORE_INFO > change > Silicon/Hisilicon: Add instance of MpInitLib to Hisilicon.dsc.inc > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | = 1 + > Platform/ARM/JunoPkg/ArmJuno.dsc | = 1 + > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJuno.c | = 12 ++--- > Platform/ARM/Morello/MorelloPlatform.dsc.inc | = 1 + > Platform/ARM/N1Sdp/N1SdpPlatform.dsc | = 1 + > Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | = 1 + > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | = 1 + > Platform/ARM/VExpressPkg/Library/ArmVExpressLibCTA15-A7/CTA15-A7.c | = 16 +++---- > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSM.c | = 16 +++---- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc | = 1 + > Platform/RaspberryPi/RPi3/RPi3.dsc | = 1 + > Platform/RaspberryPi/RPi4/RPi4.dsc | = 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | = 1 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | = 1 + > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | = 1 + > Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/AcpiPlatform.c | = 3 +- > Silicon/AMD/Styx/Drivers/PlatInitPei/PlatInitPei.c | = 8 ++-- > Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | = 22 ++++----- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | = 1 + > Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c | = 5 +- > Silicon/Hisilicon/Hisilicon.dsc.inc | = 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | = 1 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.c | = 8 ++-- > Silicon/Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.c | = 2 +- > Silicon/Phytium/PhytiumCommonPkg/PhytiumCommonPkg.dsc.inc | = 1 + > Silicon/Qemu/SbsaQemu/Library/SbsaQemuLib/SbsaQemuLib.c | = 8 ++-- > Silicon/Socionext/SynQuacer/Library/SynQuacerLib/SynQuacer.c | = 48 ++++++++++---------- > 27 files changed, 88 insertions(+), 76 deletions(-) > > -- > 2.31.1 >