From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web12.35693.1650919765833628132 for ; Mon, 25 Apr 2022 13:49:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hjiPhDhc; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 717FCB818A3 for ; Mon, 25 Apr 2022 20:49:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1215FC385AD for ; Mon, 25 Apr 2022 20:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650919762; bh=jVOhwEt9h09vk6n/vlsFZZRvJ1L80Vilcm7Wph9dAUQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hjiPhDhcNAv8A/lvM8+HTZbEh8ThHA1HAismXijP/cOoslTlGsAVRByYhQGt47CF9 xDV7s2NA1C792TwEuUOtJfJ2QNhVvVZE0EYNqWmiq7lXTlFfFKtMC+1ksg89OnDDvj +cVUKO0ZmoBmbUWxPN/hIRaxF3N3co7zWX0e9f1hNHGuwuGjon04VdisvBbeRB/WNb BJ/j4PZIlV/2CoYJ5ITWsip4B04sBA+UxR0MIkoAfJzebi0FJB3AjVEXITyR2UDIvT XWCaITdbTAwQqxzHMh+HCpjjjfiLWGN64GC1RWu6OKUEOynm51oMcHzUacw0RMjGgz dRiZneuzLZLMg== Received: by mail-ot1-f50.google.com with SMTP id v12-20020a9d7d0c000000b006054b51c3d4so11639992otn.8 for ; Mon, 25 Apr 2022 13:49:22 -0700 (PDT) X-Gm-Message-State: AOAM531oVn4A/mJ4heu7338+HYQ5eK5yi/THnE8Y/p4cMXHecMSlSPn1 Wq+zfBE0D6DYlSNe+ull9I8rKZ/YlKM7d6tHiqA= X-Google-Smtp-Source: ABdhPJxFNXxWBrbticIFeHvu3BD3u35tL3jRCAshW2bux7x425RDriRuGiiMDAJ5EHDMVO4yM/iGtsfCsVH96GVcDPI= X-Received: by 2002:a05:6830:242d:b0:605:589f:e2a7 with SMTP id k13-20020a056830242d00b00605589fe2a7mr7158454ots.71.1650919761218; Mon, 25 Apr 2022 13:49:21 -0700 (PDT) MIME-Version: 1.0 References: <20220422073713.2087781-1-kraxel@redhat.com> <20220422073713.2087781-2-kraxel@redhat.com> In-Reply-To: <20220422073713.2087781-2-kraxel@redhat.com> From: "Ard Biesheuvel" Date: Mon, 25 Apr 2022 22:49:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory To: edk2-devel-groups-io , Gerd Hoffmann Cc: Pawel Polawski , Ard Biesheuvel , Liming Gao , Hao A Wu , Ray Ni , Oliver Steffen , Leif Lindholm , Jordan Justen , Jiewen Yao , Abner Chang , Jian J Wang Content-Type: text/plain; charset="UTF-8" On Fri, 22 Apr 2022 at 09:37, Gerd Hoffmann wrote: > > io range is not mandatory according to pcie spec, > so allow bridge configurations without io address > space assigned. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Ard Biesheuvel Could one of the MdeModulePkg maintainers please get this reviewed? Thanks. > --- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > index b20bcd310ad5..712662707931 100644 > --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c > @@ -1085,6 +1085,9 @@ NotifyPhase ( > RootBridge->ResAllocNode[Index].Base = BaseAddress; > RootBridge->ResAllocNode[Index].Status = ResAllocated; > DEBUG ((DEBUG_INFO, "Success\n")); > + } else if ((Index == TypeIo) && (RootBridge->Io.Base == MAX_UINT64)) { > + /* optional on PCIe */ > + DEBUG ((DEBUG_INFO, "PCI Root Bridge does not provide IO Resources.\n")); > } else { > ReturnStatus = EFI_OUT_OF_RESOURCES; > DEBUG ((DEBUG_ERROR, "Out Of Resource!\n")); > -- > 2.35.1 > > > > > >