public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: devel@edk2.groups.io, rebecca@bsdio.com,  "Feng,
	Bob C" <bob.c.feng@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>
Cc: Andrew Fish <afish@apple.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	 Michael D Kinney <michael.d.kinney@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>
Subject: Re: [edk2-devel] MdeModulePkg build fails for AARCH64 on Ubuntu 22.04
Date: Mon, 22 Aug 2022 11:11:41 +0200	[thread overview]
Message-ID: <CAMj1kXEsbF9C9a9PH0m6eGdSbvPHQ2QvgRZg4UZJy4JGSLNMkQ@mail.gmail.com> (raw)
In-Reply-To: <41a26d57-4fae-f53f-29ae-d6c7b258eaee@bsdio.com>

(cc Bob)

NOTE this affects the stable tag - please see below


On Sun, 21 Aug 2022 at 06:34, Rebecca Cran <rebecca@bsdio.com> wrote:
>
> I noticed that MdeModulePkg fails to build on my Ubuntu 22.04 system
> (and previously on the Ubuntu 20.04 installation). Is this a known bug?
>
> It shouldn't be relevant, but I'm using gcc version 11.2.0 (Ubuntu
> 11.2.0-17ubuntu1). But perhaps more relevant, I'm using Python 3.10.4.
>
> I'm trying to build commit e2ac68a23b4954d5c0399913a1df3dd9fd90315d.
>
>
> bcran@photon:~/src/tmp/edk2$ build -p MdeModulePkg/MdeModulePkg.dsc -a
> AARCH64 -t GCC5 -b RELEASE
> Build environment: Linux-5.15.0-46-generic-x86_64-with-glibc2.35
> Build start time: 22:29:18, Aug.20 2022
>
> WORKSPACE        = /home/bcran/src/tmp/edk2
> EDK_TOOLS_PATH   = /home/bcran/src/tmp/edk2/BaseTools
> CONF_PATH        = /home/bcran/src/tmp/edk2/Conf
> PYTHON_COMMAND   = /usr/bin/python3
>
>
> Processing meta-data
> .Architecture(s)  = AARCH64
> Build target     = RELEASE
> Toolchain        = GCC5
>
> Active Platform          =
> /home/bcran/src/tmp/edk2/MdeModulePkg/MdeModulePkg.dsc
>
>
> build.py...
> /home/bcran/src/tmp/edk2/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf(42):
> error 3000: PCD
> [gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode] in
> [/home/bcran/src/tmp/edk2/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf]
> is not found in dependent packages:
>                  /home/bcran/src/tmp/edk2/MdePkg/MdePkg.dec
>          /home/bcran/src/tmp/edk2/MdeModulePkg/MdeModulePkg.dec
>
>

This looks like a BaseTools regression to me - afaik, these packages
all used to build for AARCH64 in the past.

The following LockBoxLib resolutions appear in MdeModulePkg.dsc (with
line numbers)

115-[LibraryClasses.common.PEIM]
119:  LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf

178-[LibraryClasses.ARM, LibraryClasses.AARCH64]
181:  LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf

No other [LlibraryClasses] references to SmmLockBoxPeiLib.inf exist in
that file, and the [Components] reference does not apply to AARCH64.

This means the DSC parser ends up using the earlier definition, which
I think is a bug, or at least a change in behavior. Note that doing
this silently could potentially break many platforms in subtle ways so
I think this should be root caused and preferably fixed before
creating the stable tag.

  reply	other threads:[~2022-08-22  9:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-21  4:34 MdeModulePkg build fails for AARCH64 on Ubuntu 22.04 Rebecca Cran
2022-08-22  9:11 ` Ard Biesheuvel [this message]
2022-08-22  9:30   ` [edk2-devel] " Ard Biesheuvel
2022-08-22  9:34     ` Ard Biesheuvel
2022-08-23  1:54       ` 回复: " gaoliming
2022-08-23  7:40         ` Bob Feng
2022-08-24  7:16           ` 回复: " gaoliming
2022-08-24 17:17             ` Bob Feng
2022-08-25  8:48               ` Leif Lindholm
2022-08-25 15:43                 ` Michael D Kinney
2022-08-26  0:28                   ` Ni, Ray
2022-08-26  0:55                   ` Bob Feng
2022-08-26  3:28                     ` Long1 Huang
2022-08-26 10:12                       ` Ard Biesheuvel
2022-08-24  7:49           ` Ard Biesheuvel
2022-08-24 10:14             ` Ard Biesheuvel
2022-08-25  2:04               ` 回复: [edk2-devel][edk2-stable202208] " gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXEsbF9C9a9PH0m6eGdSbvPHQ2QvgRZg4UZJy4JGSLNMkQ@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox