From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web09.5717.1666170045132973148 for ; Wed, 19 Oct 2022 02:00:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HBI9QKJc; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7915261811 for ; Wed, 19 Oct 2022 09:00:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94C1BC433C1 for ; Wed, 19 Oct 2022 09:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666170043; bh=W4Kp4wugRF6HIyKiO0WxSBOI6QLFtUBzwQUlQWlfGt0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HBI9QKJc7aUJMD+S1Gk2lKjbDcAbcqOV5DaJMzXQcECl9vulIqrTG9srDKeG1/6oB Gg3fJsh5awNhGGx3dLcB3oo/dm2Q80gG+H9g8NElZabLhmFu6kvj0AAC6VqxZaW/So fMmQ4nvJ6oXngGW4Fpz/bjRO16tlSCQXfiRgScpNFssfxrCtAmpKOIbXbEYXDJUlxO KyXRKqn+hd3bnDEi7rYVTcjhV4MxHHnjrvvZKh+Rn+/ZR25FIp69uVFhbZLZKdu8fu 6LR/LZDqhkOFHFZi2jQsAq2zPN1Mc7N5QBo4mVSp2fFJ6ujcFdolStv62CKy/1FUK9 O0jTA5R/TK0xQ== Received: by mail-lf1-f53.google.com with SMTP id d6so26972121lfs.10 for ; Wed, 19 Oct 2022 02:00:43 -0700 (PDT) X-Gm-Message-State: ACrzQf3Hi+42ask8JthH5jk2VCPTe3mAC6xUTBphkOxwxZGf5tOP+pab C4G2pbde1MGRow0+MOR50TPMaNEsk5vEk6QX3Pg= X-Google-Smtp-Source: AMsMyM5Ye+bOiZekVls081tz0m757pjQbJfEgIy1TaST6tE7Q1V47Vo0LOWZD3gJF3x6s82KDvXFDM0kmzuYrS6A0NQ= X-Received: by 2002:a05:6512:3119:b0:4a2:d749:ff82 with SMTP id n25-20020a056512311900b004a2d749ff82mr2604673lfb.637.1666170041695; Wed, 19 Oct 2022 02:00:41 -0700 (PDT) MIME-Version: 1.0 References: <20221014164836.1513036-1-sunilvl@ventanamicro.com> <20221014164836.1513036-30-sunilvl@ventanamicro.com> In-Reply-To: <20221014164836.1513036-30-sunilvl@ventanamicro.com> From: "Ard Biesheuvel" Date: Wed, 19 Oct 2022 11:00:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-staging/RiscV64QemuVirt PATCH V4 29/34] OvmfPkg: Add Qemu NOR flash DXE driver To: Sunil V L Cc: devel@edk2.groups.io, Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann Content-Type: text/plain; charset="UTF-8" On Fri, 14 Oct 2022 at 18:50, Sunil V L wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4076 > > RISC-V needs NorFlashDxe driver for qemu virt machine. The > ArmPlatformPkg has this driver but migrating it to generic > package like MdeModulePkg introduces circular dependencies. > So, add NorFlashDxe driver in OvmfPkg which is mostly the > copy of the driver in ArmPlatformPkg except the support > for PcdNorFlashCheckBlockLocked feature. This approach also > allows to optimize the driver for virtual platforms. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Signed-off-by: Sunil V L > --- > OvmfPkg/Drivers/NorFlashDxe/NorFlashDxe.inf | 67 ++ > OvmfPkg/Drivers/NorFlashDxe/NorFlashStandaloneMm.inf | 61 ++ I don't think we need the StandaloneMm variant here