From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web08.25808.1613940632764964917 for ; Sun, 21 Feb 2021 12:50:32 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qouLtMR1; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2337864E09 for ; Sun, 21 Feb 2021 20:50:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613940632; bh=PV6Tv8rhbYnDt4frJNjSG+OO0Ji4TpB+Lm/nv1E5qI8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qouLtMR1zd9/HmT88/E1c2ok6xmhPuxA/voaZ6dlu6ZMqSaRFB2mjf/FCBb4y1ziK khrtKKXL+W9ci9Hk0RfYoNi2daq1Jd5GEaNjqCHflGPB3Mw6Q6p1OsgCMbNTlHTuEM lnVT69HbtuapQM1QDK7zj4gj1BNZpcKFnY0T83woBFqzDMaGkriJNyjZlES31y9yXL GwD0daEKGNlzwXyG3/FdKDs2JKq1qNBChsLgfQHdlpO6Mg+NbDsf7AXfqDC6io/Q/p D97GZ7/1hkkFKz+SVy6U0GsdCPicmcfUvsLiuMiwYQyc2BXdxTu38Ol2J0xVoDnDqj sm/PWatLTuqUw== Received: by mail-oi1-f174.google.com with SMTP id l3so12041309oii.2 for ; Sun, 21 Feb 2021 12:50:32 -0800 (PST) X-Gm-Message-State: AOAM532C90jZeD2ZVQYuC4HgQ/jwcsgCsGcHRdS4M0sms7HXYzGj30hm PMuAxc4gWcw4ECRcZ9slUo8+93iEG4DbvsFDhDk= X-Google-Smtp-Source: ABdhPJxSOqudQQGIJzfAAhcJoVbF3x7DFfdzvest5Qa9MGg/gYFavxs4qtrI4XYeAzk6Z0NDQu0MAhMr/zrABOjZ764= X-Received: by 2002:aca:307:: with SMTP id 7mr13518864oid.174.1613940631477; Sun, 21 Feb 2021 12:50:31 -0800 (PST) MIME-Version: 1.0 References: <20210220164133.21746-1-Samer.El-Haj-Mahmoud@arm.com> <20210220214614.GL1664@vanye> <20210221204312.GM1664@vanye> In-Reply-To: <20210221204312.GM1664@vanye> From: "Ard Biesheuvel" Date: Sun, 21 Feb 2021 21:50:20 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity To: Leif Lindholm Cc: Samer El-Haj-Mahmoud , devel@edk2.groups.io, Ard Biesheuvel , Pete Batard Content-Type: text/plain; charset="UTF-8" On Sun, 21 Feb 2021 at 21:43, Leif Lindholm wrote: > > On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote: > > On Sat, 20 Feb 2021 at 22:46, Leif Lindholm wrote: > > > > > > *How* annoying was this? > > > > > > This is kind of useful information, well at the "would be good to see > > > in a regular DEBUG build" level. > > > > > > This change will have suddenly effectively hidden a message that was > > > already present in many platforms, where they were not (very) annoyingly > > > repetitive during a normal boot. > > > > > > It feels the test suite is not the thing that we need to optimise > > > debug output for. > > > > > > Is there some alternative way we can rate limit this? > > > > Given that the sole purpose of this library is to paper over the fact > > that the platform violates the spec, and lacks the ability to tell > > time, I think it makes little sense to obsess over how wrong the value > > is that it returns. > > I'm not obsessing about anything, I'm saying that using tediousness > when running a testsuite as an argument, potential issues with the > only aspect that makes this implementation useful without having to > rebuild firmware every few weeks are now hidden. > > If we truly don't care about the feature, nuke it. Don't hide when it > breaks. > Nuke what exactly? I think the library has a use, I simply don't see the point of reporting 25-50 times every boot that no timestamp was recorded in a variable.