From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web09.460.1626454541114428794 for ; Fri, 16 Jul 2021 09:55:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bxuAcc0D; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 60D52613EB for ; Fri, 16 Jul 2021 16:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626454540; bh=I1kisZPJ959wZIURDZpry7OP9kQMnvhD9S5UFCgKb9Q=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bxuAcc0DNddyj/gOxNwt0XW01cdP7ynPEteqOhc2yA/frXO03J4KoX8pie5uQ3/ZL 4BP61W40b00GMCrlgrZghdsGqNNag5BMu6nDbxLv1mqr3B8+KQMDl9SUYjl//+rPmG yKKHAw5vw49XZIQfhEUC42w3mi5WiWeFUyySBz9i791SO3RMp92RJIrw9/+qn1ScGh d1AhuZJeMTlhA6+VM4PPh37bQkDHj/7HSEQDDitjknDJOaFxlC3+XnUbw0UBulcqrD 7PBma0xhhAyqA09siB6WKa0xkJ/nMUkXzly4XtnykrxCbJU7cGaxn+P4W6VpR/St/X pIZyZCXamfnMQ== Received: by mail-ot1-f54.google.com with SMTP id o72-20020a9d224e0000b02904bb9756274cso10521129ota.6 for ; Fri, 16 Jul 2021 09:55:40 -0700 (PDT) X-Gm-Message-State: AOAM531mwKvwllz2ZpvHy99h59M3F2V+W+MpTlUnQhvyqwQV+4oloWg6 9wcLfg/oyoGu5fabKIrtg/dLuuFMObgV0kNCwVw= X-Google-Smtp-Source: ABdhPJzjjd4t2d1InhZhMLtNMsL2ehLfeuUt5qRfXyKFDorz78nyTqxjw7PPC79oZyihTv0oiSuZjWvTYU6ZO6H5ulQ= X-Received: by 2002:a9d:2625:: with SMTP id a34mr4064924otb.77.1626454539759; Fri, 16 Jul 2021 09:55:39 -0700 (PDT) MIME-Version: 1.0 References: <20210706094925.1107407-1-philmd@redhat.com> <72c07b27-73d4-b25a-12d7-e309f5dc5dce@redhat.com> <8459a1b4-a044-3909-c6cd-f872d92d5166@redhat.com> In-Reply-To: <8459a1b4-a044-3909-c6cd-f872d92d5166@redhat.com> From: "Ard Biesheuvel" Date: Fri, 16 Jul 2021 18:55:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg: Remove meaningless comment To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: Laszlo Ersek , edk2-devel-groups-io , Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Julien Grall Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 7 Jul 2021 at 19:14, Philippe Mathieu-Daud=C3=A9 wrote: > > On 7/6/21 5:57 PM, Laszlo Ersek wrote: > > On 07/06/21 11:49, Philippe Mathieu-Daud=C3=A9 wrote: > >> From: Philippe Mathieu-Daude > >> > >> The "Shell Embedded Boot Loader" description (added in > >> commit 6f5872b1f401) does not add any value, remove it. > >> > >> Cc: Laszlo Ersek > >> Cc: Ard Biesheuvel > >> Cc: Leif Lindholm > >> Cc: Sami Mujawar > >> Cc: Julien Grall > >> Suggested-by: Laszlo Ersek > >> Signed-off-by: Philippe Mathieu-Daude > >> --- > >> ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > >> ArmVirtPkg/ArmVirtKvmTool.fdf | 2 +- > >> ArmVirtPkg/ArmVirtXen.fdf | 2 +- > >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 2 +- > >> 4 files changed, 4 insertions(+), 4 deletions(-) > >> > >> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > >> index d9abadbe708c..e17238e63803 100644 > >> --- a/ArmVirtPkg/ArmVirt.dsc.inc > >> +++ b/ArmVirtPkg/ArmVirt.dsc.inc > >> @@ -376,7 +376,7 @@ [Components.common] > >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > >> > >> # > >> - # UEFI application (Shell Embedded Boot Loader) > >> + # UEFI application > >> # > >> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf { > >> > >> diff --git a/ArmVirtPkg/ArmVirtKvmTool.fdf b/ArmVirtPkg/ArmVirtKvmTool= .fdf > >> index 076155199905..8ad67233dc90 100644 > >> --- a/ArmVirtPkg/ArmVirtKvmTool.fdf > >> +++ b/ArmVirtPkg/ArmVirtKvmTool.fdf > >> @@ -174,7 +174,7 @@ [FV.FvMain] > >> INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > >> > >> # > >> - # UEFI application (Shell Embedded Boot Loader) > >> + # UEFI application > >> # > >> INF ShellPkg/Application/Shell/Shell.inf > >> INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.i= nf > >> diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf > >> index 8fbbc2313aff..bab4af446cfb 100644 > >> --- a/ArmVirtPkg/ArmVirtXen.fdf > >> +++ b/ArmVirtPkg/ArmVirtXen.fdf > >> @@ -178,7 +178,7 @@ [FV.FvMain] > >> INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > >> > >> # > >> - # UEFI application (Shell Embedded Boot Loader) > >> + # UEFI application > >> # > >> INF ShellPkg/Application/Shell/Shell.inf > >> INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.i= nf > >> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirt= QemuFvMain.fdf.inc > >> index 5b1d10057545..5ecde9233951 100644 > >> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > >> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > >> @@ -100,7 +100,7 @@ [FV.FvMain] > >> INF OvmfPkg/VirtioRngDxe/VirtioRng.inf > >> > >> # > >> - # UEFI application (Shell Embedded Boot Loader) > >> + # UEFI application > >> # > >> INF ShellPkg/Application/Shell/Shell.inf > >> INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.i= nf > >> > > > > I'm really sorry Phil, but even the new comment looks just super weird > > to me. I've grepped the edk2 codebase for > > "ShellPkg/Application/Shell/Shell.inf", and looked at the leading > > context (approx. 30 lines) near every match -- and now I actually think > > we don't need *any* comments here. > > Yes I agree. > So do I. > > I mean we could say "UEFI Shell > > Application", but is that really helpful? I have no idea. > > > > I'll let other ArmVirtPkg reviewers comment on this. > > > > Thanks > > Laszlo > > >