From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web10.11008.1683704369246369010 for ; Wed, 10 May 2023 00:39:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NqRZwjT1; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8127362F86 for ; Wed, 10 May 2023 07:39:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC46AC4339B for ; Wed, 10 May 2023 07:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683704367; bh=vXAs+KxWQFSF7eE869hLCdeZWfrwJ08sJjRsU2UIOGA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=NqRZwjT1rk4IveaFy4XyQSpXxJ/VyIrJKyP8aP/hh81ud4iQ04tEcFPeIDAEYeCIm mEjT4nGs6nn1oDuVvIIoW1J1no2OsQKbN8Xh1nWopTbHX867kpEQxGQE1V1VOKzKhP xYD+qEn0CG/idbDRUxvAs7YqB9jRXcxswWU5Lp6NiFS9ARwLyJ0c1XW5v0fVY21toD nZksc98d24xBduql+ytGvC90rzeBxUN3PoaSzPuLNzybXuHyfuQ3P07djpO/lGZio1 S4lDolEXpDWPx40+GbjPQPuJLwCGg0rFrABOYFmDVE+LbzYF0qEVJ8OJUGbwyiHWWL Y76Y7ammrsqtA== Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2ac81d2bfbcso74128451fa.3 for ; Wed, 10 May 2023 00:39:27 -0700 (PDT) X-Gm-Message-State: AC+VfDwn757FFf0MkXNpwqEPnuS4xYxKS2hC4E2DAZxYdS6J5Gis+6CE 7Bicku1EJr41E7+eyWzULhtS9L5nk50OqWnzvCI= X-Google-Smtp-Source: ACHHUZ4rY0ldfIJpmxFDSEm5jMTzXvVYQyxzQbVC43m4n/l/ZUcFgyeo39Qq2sslWDkRdw9O8ssFY+1iSl5Su7dcDOY= X-Received: by 2002:a19:a40f:0:b0:4d1:3d1d:4914 with SMTP id q15-20020a19a40f000000b004d13d1d4914mr1501869lfc.33.1683704365692; Wed, 10 May 2023 00:39:25 -0700 (PDT) MIME-Version: 1.0 References: <20230510073358.79042-1-kraxel@redhat.com> In-Reply-To: <20230510073358.79042-1-kraxel@redhat.com> From: "Ard Biesheuvel" Date: Wed, 10 May 2023 09:39:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtioSerialDxe: fix RELEASE build error To: devel@edk2.groups.io, kraxel@redhat.com Cc: Pawel Polawski , Ard Biesheuvel , Jordan Justen , Oliver Steffen , Jiewen Yao , Rebecca Cran Content-Type: text/plain; charset="UTF-8" On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote: > > EventNames is used to pretty-print debug log messages. > Add #ifdef to only include it in debug builds. > Fixes a clang build failure. > > Reported-by: Rebecca Cran > Signed-off-by: Gerd Hoffmann Queued up as #4381 - thanks. > --- > OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c > index bfb2b324eadf..5fb4ce31914b 100644 > --- a/OvmfPkg/VirtioSerialDxe/VirtioSerial.c > +++ b/OvmfPkg/VirtioSerialDxe/VirtioSerial.c > @@ -25,6 +25,7 @@ > > STATIC LIST_ENTRY mVirtioSerialList; > > +#if !defined (MDEPKG_NDEBUG) > STATIC CONST CHAR8 *EventNames[] = { > [VIRTIO_SERIAL_DEVICE_READY] = "device-ready", > [VIRTIO_SERIAL_DEVICE_ADD] = "device-add", > @@ -35,6 +36,7 @@ STATIC CONST CHAR8 *EventNames[] = { > [VIRTIO_SERIAL_PORT_OPEN] = "port-open", > [VIRTIO_SERIAL_PORT_NAME] = "port-name", > }; > +#endif > > VOID > EFIAPI > -- > 2.40.1 > > > > > >