From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mx.groups.io with SMTP id smtpd.web11.436.1618332828010228645 for ; Tue, 13 Apr 2021 09:53:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A+Z+xhDG; spf=pass (domain: kernel.org, ip: 198.145.29.99, mailfrom: ardb@kernel.org) Received: by mail.kernel.org (Postfix) with ESMTPSA id 87E3D613AB for ; Tue, 13 Apr 2021 16:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618332827; bh=Bv+dJkRPdfEnUK3D3rwK/+ahY92RfuyGVD7DtsFgbwU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=A+Z+xhDGqGthz0kdSj7X8z6Ak31JpT3kjlG3CtEE5Zyg9PegNSP3aYcJkaeh8slFT 2XfM6+JgCv89NkuRyD6oxL3chxEHL3/juLpxID/vYj9hSGFpl5FHUQrhB5AsSfLK/g FPvbG9HS/+jxkFid9/xsBGe0XsE70SvqOI+ZSE3iYKDVpaclbRmV2eKn6Q5X+iL1Cb CODXIzjVZ5rzBM2RY8DtHRMCjLWHhG2/FH3TP6UwJJIRCt9uudZd4+E5CgFKOjjjtm O2FcNYlrNkk/XkKcuRe88H6mOmGLI3JIXElXHfUbzpSKgbq7MDyfeVrAoUgUxM/P1j JesAMAJfTvqxA== Received: by mail-ot1-f51.google.com with SMTP id v24-20020a9d69d80000b02901b9aec33371so16734864oto.2 for ; Tue, 13 Apr 2021 09:53:47 -0700 (PDT) X-Gm-Message-State: AOAM531arHU4lQgiyJ9E/vIaVDtaOOGj24ODccGxSjle/yZQQeYo6IXw p+ZDN6I/GlEfAXtfHPnuLOobw2rPSCxD3YBcSZU= X-Google-Smtp-Source: ABdhPJwKU42ccGoSzBKet6EZTeBZuSAy3ypsMoZQ8wTF6QiFI+mYFR15kk+wE4pmg0yRm+aAWLj4Tf++kO+FTF0F3Ds= X-Received: by 2002:a9d:12cb:: with SMTP id g69mr28415026otg.77.1618332826829; Tue, 13 Apr 2021 09:53:46 -0700 (PDT) MIME-Version: 1.0 References: <20210331021619.19761-1-rebecca@nuviainc.com> <20210331021619.19761-2-rebecca@nuviainc.com> <20210413165117.GC1664@vanye> In-Reply-To: <20210413165117.GC1664@vanye> From: "Ard Biesheuvel" Date: Tue, 13 Apr 2021 18:53:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/5] ArmPkg: Allow platforms to override PCI supported state in SmbiosMiscDxe To: Leif Lindholm Cc: Rebecca Cran , edk2-devel-groups-io , Ard Biesheuvel Content-Type: text/plain; charset="UTF-8" On Tue, 13 Apr 2021 at 18:51, Leif Lindholm wrote: > > On Tue, Mar 30, 2021 at 20:16:15 -0600, Rebecca Cran wrote: > > Not all platforms support PCI, so introduce a PCD to allow platforms to > > specify whether they support it. > > Are we planning to add one? > If not, I'd rather skip this until we do. > These days, I would expect any platform providing SMBIOS tables to > have PCI. > Also, does it matter? SMBIOS is mostly informational, and whether a platform 'supports' PCI does not imply that it 'implements' it. And even if it implements PCI, it may not have any slots. IOW, this is PC legacy that we care little about one way or the other, I think.. > No further comments on this set. > > / > Leif > > > Signed-off-by: Rebecca Cran > > --- > > ArmPkg/ArmPkg.dec | 1 + > > ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 + > > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 4 ++++ > > 3 files changed, 6 insertions(+) > > > > diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec > > index a8a22c649ff8..51ac2191c85a 100644 > > --- a/ArmPkg/ArmPkg.dec > > +++ b/ArmPkg/ArmPkg.dec > > @@ -125,6 +125,7 @@ [PcdsFixedAtBuild.common] > > # > > # SMBIOS PCDs > > # > > + gArmTokenSpaceGuid.PcdPlatformSupportsPCI|TRUE|BOOLEAN|0x30000052 > > gArmTokenSpaceGuid.PcdSystemProductName|L""|VOID*|0x30000053 > > gArmTokenSpaceGuid.PcdSystemVersion|L""|VOID*|0x30000054 > > gArmTokenSpaceGuid.PcdBaseBoardManufacturer|L""|VOID*|0x30000055 > > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > > index 60d8fe31c219..ebc4c99ac436 100644 > > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > > @@ -71,6 +71,7 @@ [Pcd] > > gArmTokenSpaceGuid.PcdFdSize > > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor > > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString > > + gArmTokenSpaceGuid.PcdPlatformSupportsPCI > > gArmTokenSpaceGuid.PcdSystemBiosRelease > > gArmTokenSpaceGuid.PcdEmbeddedControllerFirmwareRelease > > gArmTokenSpaceGuid.PcdSystemProductName > > diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > > index 5aea32521bd3..a06f814aeb7c 100644 > > --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > > +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c > > @@ -13,6 +13,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -264,6 +265,9 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) > > UnicodeStrToAsciiStrS (Version, StrStart, VerStrLen + 1); > > StrStart += VerStrLen + 1; > > UnicodeStrToAsciiStrS (ReleaseDate, StrStart, DateStrLen + 1); > > + > > + SmbiosRecord->BiosCharacteristics.PciIsSupported = FixedPcdGetBool (PcdPlatformSupportsPCI); > > + > > // > > // Now we have got the full smbios record, call smbios protocol to add this record. > > // > > -- > > 2.26.2 > >