From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web09.1787.1662483391980428339 for ; Tue, 06 Sep 2022 09:56:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dS51D+hw; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 65E20B8197B for ; Tue, 6 Sep 2022 16:56:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 205EAC433B5 for ; Tue, 6 Sep 2022 16:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662483389; bh=lk8DKheWwjAwiql0qzgeaW9odZzIEJT9ncrqCoAykpo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dS51D+hwh6ZEAGMn0CVGZjvrFQ9EkDoasZ6fUKCCtEk/O6Gz1fEmb4qIpY2WOifTL 6a0HMRaTfhNBsTpHajQViydIewXiAyhnOr4vRBfI++yW004z0SpRTpzG9XcBf3QCV3 gAG7yJuvtmQ58STrlIeE/pxnR3IfgBdJ58HbYH24cwHagnHKnLDQv+Z0Y+CK1zoNBt RlU9imAxctbdoMQtuj2Uc0mDySidkXmD+TyfNgpSU6POrTECuzHgy5g5jebo9PzSLO 3QcRudeqwCnxOhY5sr9LKSadzcGAtDKjochhWQ/RQRLavNIIw9NorA1y0Q+TmKaWA9 UrgttBZORbbpQ== Received: by mail-lf1-f52.google.com with SMTP id q7so18328460lfu.5 for ; Tue, 06 Sep 2022 09:56:29 -0700 (PDT) X-Gm-Message-State: ACgBeo2D6U2QkpH7XuPcPnWPpwX5NfBR6knR8ADH5CCohDkfG/6qBelo RSyxaqOZ52PBRrEpmvl9MescTsoAidFQYpxv38k= X-Google-Smtp-Source: AA6agR6hXIq1AiUa+bdHUO75GIQN/zMUpzwUBOEYDKZP7JJ34emuwfrhUdMqXOEsv3mGeKg6EGd87LGctlcWVYePL4o= X-Received: by 2002:a05:6512:4024:b0:497:4db:6ad0 with SMTP id br36-20020a056512402400b0049704db6ad0mr1763322lfb.637.1662483387131; Tue, 06 Sep 2022 09:56:27 -0700 (PDT) MIME-Version: 1.0 References: <16E62E6A940424A8.9469@groups.io> <16EB65B9C6B20F3F.8534@groups.io> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 6 Sep 2022 18:56:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/OvmfPkg*.dsc: Increase ACPI Reclaim memory size To: devel@edk2.groups.io, annie.li@oracle.com Cc: Jiewen Yao , Jordan Justen , "kraxel@redhat.com >> Gerd Hoffmann" , Karl Franz Heubaum , Aaron Young Content-Type: text/plain; charset="UTF-8" On Fri, 22 Jul 2022 at 14:43, annie li wrote: > > Hello Ard, > > Looks there hasn't any feedback from other maintainers yet. > > Would you like to merge this patch in or still wait for more feedback? > > Could anyone else please review this patch? thank you! > Reviewed-by: Ard Biesheuvel Merged as #3298 > On 5/13/2022 7:28 AM, Annie.li wrote: > > On 5/3/2022 12:25 PM, Ard Biesheuvel wrote: > >> On Tue, 3 May 2022 at 17:54, annie li wrote: > >>> Adding maintainers into the CC list... > >>> > >>> On 5/2/2022 5:05 PM, annie li wrote: > >>>> Hello > >>>> > >>>> I am wondering if anyone will review this patch please? Any comments > >>>> are welcome. > >>>> > >>>> Thanks > >>>> > >>>> Annie > >>>> > >>>> On 4/15/2022 5:15 PM, annie li wrote: > >>>>> The current ACPI Reclaim memory size is set as 0x10(64k). The > >>>>> ACPI table size will be increased if the memory slots' number of > >>>>> the guest gets increased. In the guest with more memory slots, > >>>>> the ACPI Reclaim memory size may not be sufficient for hibernation. > >>>>> This may cause resume failure of the hibernated guest that was > >>>>> booted up with a fresh copied writable OVMF_VARS file. However, > >>>>> the failure doesn't happen in following hibernation/resume > >>>>> cycles. > >>>>> > >>>>> The ACPI_MAX_RAM_SLOTS is set as 256 in the current QEMU. With > >>>>> ACPI_MAX_RAM_SLOTS, 18 pages are required to be allocated in ACPI > >>>>> Reclaim memory. However, due to the 0x10(16 pages) setting, 2 extra > >>>>> pages will be allocated in other space. This may break the > >>>>> hibernation/resume in the above scenario. > >>>>> > >>>>> This patch increases the ACPI Reclaim memory size to 0x12, i.e. > >>>>> PcdMemoryTypeEfiACPIReclaimMemory is set as 0x12(18 pages). > >>>>> > >>>>> Signed-off-by: Annie Li > >>>>> --- > >>>>> OvmfPkg/OvmfPkgIa32.dsc | 2 +- > >>>>> OvmfPkg/OvmfPkgIa32X64.dsc | 2 +- > >>>>> OvmfPkg/OvmfPkgX64.dsc | 2 +- > >>>>> 3 files changed, 3 insertions(+), 3 deletions(-) > >>>>> > >> No objections from me but before merging this, I'll give the other > >> folks the opportunity to chime in as well. > > > > Thank you Ard for reviewing this. > > > > Could anyone else please review this patch? thank you! > > > > Thanks > > > > Annie > > > >> > >>>>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > >>>>> index 29eea82571..fb158f98c9 100644 > >>>>> --- a/OvmfPkg/OvmfPkgIa32.dsc > >>>>> +++ b/OvmfPkg/OvmfPkgIa32.dsc > >>>>> @@ -547,7 +547,7 @@ > >>>>> # unknown) workloads / boot paths. > >>>>> > >>>>> # > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > >>>>> > >>>>> - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > >>>>> > >>>>> + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 > >>>>> > >>>>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > >>>>> index 56d3c49ab2..30d47ca28a 100644 > >>>>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc > >>>>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > >>>>> @@ -552,7 +552,7 @@ > >>>>> # unknown) workloads / boot paths. > >>>>> > >>>>> # > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > >>>>> > >>>>> - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > >>>>> > >>>>> + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 > >>>>> > >>>>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > >>>>> index f0924c0f9d..6c10ceedd7 100644 > >>>>> --- a/OvmfPkg/OvmfPkgX64.dsc > >>>>> +++ b/OvmfPkg/OvmfPkgX64.dsc > >>>>> @@ -552,7 +552,7 @@ > >>>>> # unknown) workloads / boot paths. > >>>>> > >>>>> # > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIMemoryNVS|0x80 > >>>>> > >>>>> - gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x10 > >>>>> > >>>>> + gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory|0x12 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiReservedMemoryType|0x80 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesCode|0x100 > >>>>> > >>>>> gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiRuntimeServicesData|0x100 > >>>>> > >>>> > >>>> > >>>> > >>>> > >>> > >>> > >>> > >>> > > > > >