[edk2-devel] [PATCH edk2-platforms 0/2] SbsaQemu: some simple cleanups

[edk2-devel] [PATCH edk2-platforms 0/2] SbsaQemu: some simple cleanups

[Marcin Juszkiewicz]

During recent work I found some places in a need of cleanups. Piled them
in separate branch waiting for better commit messages.

One patch drops Pcds for Core/Cluster count as we do not use them.

Other updates some comments in code.

To: devel@edk2.groups.io
Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Graeme Gregory <graeme@xora.org.uk>

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
Marcin Juszkiewicz (2):
      SbsaQemu: fix comments in SbsaQemuHardwareInfoLib
      SbsaQemu: drop not used Pcds for Cluster/Core count

 Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                  | 3 ---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                                 | 4 ----
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf   | 1 -
 .../Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.c       | 6 +++---
 4 files changed, 3 insertions(+), 11 deletions(-)
---
base-commit: ad553efc01125cad4ebdbe694b82cf6a59ce6a03
change-id: 20240711-b4-cleanups-9f28a3e38597

Best regards,
-- 
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119889): https://edk2.groups.io/g/devel/message/119889
Mute This Topic: https://groups.io/mt/107158768/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 1/2] SbsaQemu: fix comments in SbsaQemuHardwareInfoLib

[Marcin Juszkiewicz]

EDK2 takes information from TF-A. How it got that info does not interest
us.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 .../Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.c       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.c b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.c
index 596a3453c70f..05b6fca9e538 100644
--- a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.c
+++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuHardwareInfoLib/SbsaQemuHardwareInfoLib.c
@@ -15,7 +15,7 @@
 #include <IndustryStandard/SbsaQemuSmc.h>
 
 /**
-  Get CPU count from information passed by Qemu.
+  Get CPU count from information passed by TF-A.
 
 **/
 UINT32
@@ -38,7 +38,7 @@ GetCpuCount (
 }
 
 /**
-  Get MPIDR for a given cpu from device tree passed by Qemu.
+  Get MPIDR for a given cpu from TF-A.
 
   @param [in]   CpuId    Index of cpu to retrieve MPIDR value for.
 
@@ -67,7 +67,7 @@ GetMpidr (
 }
 
 /**
-  Get NUMA node id for a given cpu from device tree passed by Qemu.
+  Get NUMA node id for a given cpu from TF-A.
 
   @param [in]   CpuId    Index of cpu to retrieve NUMA node id for.
 

-- 
2.45.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119890): https://edk2.groups.io/g/devel/message/119890
Mute This Topic: https://groups.io/mt/107158769/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH edk2-platforms 2/2] SbsaQemu: drop not used Pcds for Cluster/Core count

[Marcin Juszkiewicz]

We read CPU topology from TF-A so there is no need to keep fake values
anymore.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 Silicon/Qemu/SbsaQemu/SbsaQemu.dec                                | 3 ---
 Platform/Qemu/SbsaQemu/SbsaQemu.dsc                               | 4 ----
 Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 1 -
 3 files changed, 8 deletions(-)

diff --git a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec
index 8f3533800767..60daeff915c5 100644
--- a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec
+++ b/Silicon/Qemu/SbsaQemu/SbsaQemu.dec
@@ -49,9 +49,6 @@ [PcdsFixedAtBuild.common]
   gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciExpressBarLimit|0xFFFFFFFF|UINT64|0x00000010
 
 [PcdsDynamic.common]
-  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCoreCount|0x1|UINT32|0x00000100
-  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdClusterCount|0x1|UINT32|0x00000101
-
   gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSystemManufacturer|L""|VOID*|0x00000110
   gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSystemSerialNumber|L""|VOID*|0x00000111
   gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdSystemSKU|L""|VOID*|0x00000112
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index e78f1d71998a..02d62b377c45 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -496,10 +496,6 @@ [PcdsFixedAtBuild.common]
 [PcdsDynamicDefault.common]
   gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|3
 
-  # Core and Cluster Count
-  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdCoreCount|1
-  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdClusterCount|1
-
   # System Memory Size -- 128 MB initially, actual size will be fetched from DT
   # TODO as no DT will be used we should pass this by some other method
   gArmTokenSpaceGuid.PcdSystemMemorySize|0x08000000
diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
index 727c8e82d16e..035901ecab40 100644
--- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
+++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf
@@ -44,7 +44,6 @@ [LibraryClasses]
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
-  gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdClusterCount
 
   gArmTokenSpaceGuid.PcdGicDistributorBase
   gArmTokenSpaceGuid.PcdGicRedistributorsBase

-- 
2.45.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119891): https://edk2.groups.io/g/devel/message/119891
Mute This Topic: https://groups.io/mt/107158770/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] SbsaQemu: some simple cleanups

[Ard Biesheuvel]

On Thu, 11 Jul 2024 at 09:35, Marcin Juszkiewicz
<marcin.juszkiewicz@linaro.org> wrote:
>
> During recent work I found some places in a need of cleanups. Piled them
> in separate branch waiting for better commit messages.
>
> One patch drops Pcds for Core/Cluster count as we do not use them.
>
> Other updates some comments in code.
>
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Graeme Gregory <graeme@xora.org.uk>
>
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
> Marcin Juszkiewicz (2):
>       SbsaQemu: fix comments in SbsaQemuHardwareInfoLib
>       SbsaQemu: drop not used Pcds for Cluster/Core count
>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119934): https://edk2.groups.io/g/devel/message/119934
Mute This Topic: https://groups.io/mt/107158768/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 0/2] SbsaQemu: some simple cleanups

[Marcin Juszkiewicz]

On 15.07.2024 10:55, Ard Biesheuvel wrote:
>> During recent work I found some places in a need of cleanups. Piled them
>> in separate branch waiting for better commit messages.
>>
>> One patch drops Pcds for Core/Cluster count as we do not use them.
>>
>> Other updates some comments in code.
>>
>> To:devel@edk2.groups.io
>> Cc: Leif Lindholm<quic_llindhol@quicinc.com>
>> Cc: Ard Biesheuvel<ardb+tianocore@kernel.org>
>> Cc: Graeme Gregory<graeme@xora.org.uk>
>>
>> Signed-off-by: Marcin Juszkiewicz<marcin.juszkiewicz@linaro.org>
>> ---
>> Marcin Juszkiewicz (2):
>>        SbsaQemu: fix comments in SbsaQemuHardwareInfoLib
>>        SbsaQemu: drop not used Pcds for Cluster/Core count
>>
> Reviewed-by: Ard Biesheuvel<ardb@kernel.org>

Thanks, pushed as b40ce006a6dbc87daedbe1d71b4dc32593101d1d


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120217): https://edk2.groups.io/g/devel/message/120217
Mute This Topic: https://groups.io/mt/107158768/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-