Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version

["Ard Biesheuvel" <ardb@kernel.org>]

On Fri, 31 Mar 2023 at 11:56, Ni, Ray <ray.ni@intel.com> wrote:
>
> Ard,
> Thanks for the detailed commit messages. That really helps me to understand why XCODE version
> was needed.
>
> However, I feel it would be great if you can "highlight" what are changed by this patch.
> The following is just an example. You can reword as you like.
>
> 1. Change for non-XCODE SecPeiCpuExceptionHandlerLib:
>    * Use SecPeiExceptionHandlerAsm.nasm (renamed from ExceptionHandlerAsm.nasm)
>    * Removed some unnecessary absolute references
>    * (32 IDT stubs are still in .text.)

Indeed

> 2. Change for XCODE SecPeiCpuExceptionHandlerLib:
>    * Use SecPeiExceptionHandlerAsm.nasm instead of Xcode5ExceptionHandlerAsm.nasm
>    * CET logic is not in SecPeiExceptionHandlerAsm.nasm (but aligns to non-XCODE lib instance)

No, this does not actually change in this patch. The CET logic does
not exist in the generic SecPei version either before or after this
patch.

Only the Xcode version is changed, because that version uses the same
as the Dxe/Smm version, which does have the CET code.

>    * Fixed a bug that does runtime fixup in TEXT section in SPI flash.
>    * Emitted the code carrying the absolute symbol references into the .data which XCODE or
>       LLD linkers allow.
>      Then fixup can be done by other build tools such as GenFv if the code runs in SPI flash,
>      or by PE coff loader if the code is loaded to memory.
>
> Again, thanks for the quick patches just because I asked some XCODE questions.
>

No problem. I'd like to get this fixed too for OVMF.