From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by mx.groups.io with SMTP id smtpd.web11.51063.1680257587652421299 for ; Fri, 31 Mar 2023 03:13:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i7PhP7Gi; spf=pass (domain: kernel.org, ip: 145.40.68.75, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ABAEEB82E27 for ; Fri, 31 Mar 2023 10:13:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72664C433A0 for ; Fri, 31 Mar 2023 10:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1680257584; bh=mJz+AW/EL1h7VA8mbgOcrGa3yl8KhI6jgw333DRxUBA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=i7PhP7Gi/i9klVtYP9h61DGuNC2LRlAh+JdNIA0UIGVWU1CjDp6XTMpbsS5XSjsaP Pdyy4l69jsvHldAF26KCwNSUdo5Oz5xkBziEBgF0PsekFzYgCWm13Q74ehtNrOC9+Z XBFD9p+O99/rQnzC62vA2mUDFyNPYCzW2kstI2AaAjHrmvkX2Nlh3QvWqNZ186KJqT gJyH4s/Te4ncs7ZLpE9e1P4vvJ1MTIz232UjVvOF075Ot2W/psMCWrLAan7Jbji80d KM2gjTEmlkV8w+pieGitUTK5xzaBpPW8IWX5HY3qs7siLTOK72+ThJdpXYOXnbAHOq FZ9xAm45M2zbQ== Received: by mail-lf1-f54.google.com with SMTP id x17so28237700lfu.5 for ; Fri, 31 Mar 2023 03:13:04 -0700 (PDT) X-Gm-Message-State: AAQBX9eMwWPfP7jo18ZP4nPt6zmdfelBt8d+fylLbvXXk3xKhMy+OjDm Q+qbIt1Ilhab+KLYTGceHTXJzwBqGFaZZ3U8G6U= X-Google-Smtp-Source: AKy350ZoYmVlUmAnLqzMAjayLTKfF1F3y0OnGYGB6VcqX0pB5+w0yb37I6a65Y5pxMtwvqiDS6N0ACmK1uJ5iH0ai6k= X-Received: by 2002:a19:ad09:0:b0:4eb:dcc:52ce with SMTP id t9-20020a19ad09000000b004eb0dcc52cemr5799258lfc.9.1680257582369; Fri, 31 Mar 2023 03:13:02 -0700 (PDT) MIME-Version: 1.0 References: <20230331091437.1593337-1-ardb@kernel.org> <20230331091437.1593337-3-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Fri, 31 Mar 2023 12:12:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [RFT PATCH v3 2/5] UefiCpuPkg/CpuExceptionHandlerLib: Use single SEC/PEI version To: devel@edk2.groups.io, ray.ni@intel.com Cc: Andrew Fish , "Kinney, Michael D" , "Liu, Zhiguang" , Rebecca Cran , Tom Lendacky , =?UTF-8?Q?Marvin_H=C3=A4user?= Content-Type: text/plain; charset="UTF-8" On Fri, 31 Mar 2023 at 11:56, Ni, Ray wrote: > > Ard, > Thanks for the detailed commit messages. That really helps me to understand why XCODE version > was needed. > > However, I feel it would be great if you can "highlight" what are changed by this patch. > The following is just an example. You can reword as you like. > > 1. Change for non-XCODE SecPeiCpuExceptionHandlerLib: > * Use SecPeiExceptionHandlerAsm.nasm (renamed from ExceptionHandlerAsm.nasm) > * Removed some unnecessary absolute references > * (32 IDT stubs are still in .text.) Indeed > 2. Change for XCODE SecPeiCpuExceptionHandlerLib: > * Use SecPeiExceptionHandlerAsm.nasm instead of Xcode5ExceptionHandlerAsm.nasm > * CET logic is not in SecPeiExceptionHandlerAsm.nasm (but aligns to non-XCODE lib instance) No, this does not actually change in this patch. The CET logic does not exist in the generic SecPei version either before or after this patch. Only the Xcode version is changed, because that version uses the same as the Dxe/Smm version, which does have the CET code. > * Fixed a bug that does runtime fixup in TEXT section in SPI flash. > * Emitted the code carrying the absolute symbol references into the .data which XCODE or > LLD linkers allow. > Then fixup can be done by other build tools such as GenFv if the code runs in SPI flash, > or by PE coff loader if the code is loaded to memory. > > Again, thanks for the quick patches just because I asked some XCODE questions. > No problem. I'd like to get this fixed too for OVMF.