From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web11.10374.1674027287640660471 for ; Tue, 17 Jan 2023 23:34:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SA7n98bc; spf=pass (domain: kernel.org, ip: 139.178.84.217, mailfrom: ardb@kernel.org) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DFCE9616D7 for ; Wed, 18 Jan 2023 07:34:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7537C433F1 for ; Wed, 18 Jan 2023 07:34:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674027285; bh=1UlXvl5mOckeo3jtyA4uWNqPOeivpf715TzmJXmmyFI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=SA7n98bcpQXoLGCsNdiVzI7u54DyqfbFI8rPeurPkaeDDd1GS7BtJnYftJ/Ics91j PdLXf9xYU8ZofLA3jmiL+1GZcFC5mrsmK7En35oIO166wX8jmgRpCD2y4xNyqUBNYx ueq7Q6iXnkxbX2S1LERxR4N0Qv1FoHK7W1MZ53jtEFI+cQ1zk+A7Tr6cDkojLpmWRf L7Qqs6QNCH8zFuHAT+mjUN2UzpITRA+4RVc3EMQ1XNIaWLSjs9Ve+wDl7vhR/vP5yL rc0V2NUgV5oy9duu8ms01uxkNOllPjoHvdm+Nm8ccqacKDELzic7nSgKMbS91FYHT/ ei1qPGuNVgRLw== Received: by mail-lf1-f44.google.com with SMTP id f34so50475815lfv.10 for ; Tue, 17 Jan 2023 23:34:45 -0800 (PST) X-Gm-Message-State: AFqh2kqXzZz0O1wUTGQHjghN5ngrGBPXo9JsHJgtzPnQblrBr6hxB8wC MMWMlQtz6+Wqk5ExQcHKxFiWGMo/IhOtG13gWk8= X-Google-Smtp-Source: AMrXdXsrM4Iq7toFgZSiabdQGSLfEGg6OUKoowthJQq4gK7pmAPxh3TjnS4WqYFakTKbVOK+BiaWFc1DT5irPw7veow= X-Received: by 2002:ac2:4bd5:0:b0:4d5:76af:f890 with SMTP id o21-20020ac24bd5000000b004d576aff890mr330016lfq.228.1674027283956; Tue, 17 Jan 2023 23:34:43 -0800 (PST) MIME-Version: 1.0 References: <20230105162528.1430368-1-ardb@kernel.org> <20230105162528.1430368-2-ardb@kernel.org> In-Reply-To: From: "Ard Biesheuvel" Date: Wed, 18 Jan 2023 08:34:32 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX To: Oliver Steffen Cc: devel@edk2.groups.io, dann.frazier@canonical.com Content-Type: text/plain; charset="UTF-8" On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote: > > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote: >> >> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote: >> > >> > Hi Ard, Hi everyone, >> > >> > Thanks for the work! >> > >> > But somehow this patch (as it was merged into master branch) does not >> > work for me on the ThunderX box we have. >> > >> > Any idea what could be wrong? >> >> I'm not sure I understand the question. The patch targets ThunderX, >> and you are using a ThunderX2. >> >> What were you expecting to happen, and what is happening instead? > > > Firmware does not start at all when using KVM. > > Please excuse my limited knowledge of Arm processor variants. > I assumed that ThunderX and ThunderX2 are very similar and hoped > the fix would also work for this case. > > The issue was introduced by the same commit that Dann > reported (07be1d34d95460a238fcd0f6693efb747c28b329): > "ArmVirtPkg/ArmVirtQemu: enable initial ID map at early boot". > Can you share the QEMU command line that you are using? I use a ThunderX2 basically 24/7 to do all my Linux and EDK2 development, so this change was developed on ThunderX2 and so I'm surprised you are seeing this issue. Did you try the DEBUG build as well?