From: "Ard Biesheuvel" <ardb@kernel.org>
To: Sughosh Ganu <sughosh.ganu@linaro.org>
Cc: devel@edk2.groups.io, Sami Mujawar <sami.mujawar@arm.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable
Date: Mon, 22 Feb 2021 15:05:54 +0100 [thread overview]
Message-ID: <CAMj1kXEzLXvA2FkYgwbsJ3jF5UdTUrRANJP9HKFAj1sBZ8Z_MQ@mail.gmail.com> (raw)
In-Reply-To: <CADg8p96svTiLZkyGPdjKk6NPTzieni5C6ErPVCgRLfWm7Rtdcw@mail.gmail.com>
On Mon, 22 Feb 2021 at 12:47, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>
>
> hi Ard,
>
> On Mon, 22 Feb 2021 at 16:19, Ard Biesheuvel <ardb@kernel.org> wrote:
>>
>> On Fri, 19 Feb 2021 at 07:36, Sughosh Ganu <sughosh.ganu@linaro.org> wrote:
>> >
>> > The Secure Partition(SP) can request services from the Secure
>> > Partition Manager Core(SPMC) either through FF-A calls or through the
>> > existing SVC calls. Add a feature flag Pcd for enabling the FF-A
>> > method -- when this is set to FALSE, the SP uses the existing SVC
>> > calls for making the requests.
>> >
>> > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
>> > ---
>> >
>> > Changes since V4: None
>> >
>>
>> Didn't I already ack some of these patches for v3?
>>
>> In general, please carry over Rb's that have been given on the list if
>> the patches haven't changed substantially.
>
>
> The reason i did not put your R-b on this patch is because i have made a change in the patch where the Pcd has now been put under the [PcdsFeatureFlag.AARCH64] section. In the v3 patchset, the flag was under [PcdsFeatureFlag.common] section. This was required to avoid the build break of StandaloneMm for X64 builds. I do have your R-b on other patches which have not been changed from the previous versions.
>
Fair enough.
next prev parent reply other threads:[~2021-02-22 14:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 6:35 [PATCH v5 00/14] Add support for using FF-A calls Sughosh Ganu
2021-02-19 6:35 ` [PATCH v5 01/14] ArmPkg/IndustryStandard: Add barebones FF-A header Sughosh Ganu
2021-02-19 6:35 ` [PATCH v5 02/14] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters Sughosh Ganu
2021-02-19 6:35 ` [PATCH v5 03/14] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point Sughosh Ganu
2021-02-19 6:35 ` [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable Sughosh Ganu
2021-02-22 9:28 ` [edk2-devel] " Sami Mujawar
2021-02-22 10:48 ` Ard Biesheuvel
2021-02-22 11:47 ` Sughosh Ganu
2021-02-22 14:05 ` Ard Biesheuvel [this message]
2021-02-19 6:35 ` [PATCH v5 05/14] ArmPkg: Add macros for SPM version Sughosh Ganu
2021-02-22 9:30 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:35 ` [PATCH v5 06/14] StandaloneMmPkg: Use macros for SPM version check Sughosh Ganu
2021-02-22 9:31 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:36 ` [PATCH v5 07/14] ArmPkg: Add macros for SPM version with FF-A support enabled Sughosh Ganu
2021-02-22 9:32 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:36 ` [PATCH v5 08/14] StandaloneMmPkg: Add option to use FF-A calls for getting SPM version Sughosh Ganu
2021-02-22 9:37 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:36 ` [PATCH v5 09/14] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM Sughosh Ganu
2021-02-19 6:36 ` [PATCH v5 10/14] ArmPkg: Use FF-A header file in Standalone MM Arm MMU library Sughosh Ganu
2021-02-19 6:36 ` [PATCH v5 11/14] ArmPkg: Allow FF-A calls to get memory region's attributes Sughosh Ganu
2021-02-22 9:38 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:36 ` [PATCH v5 12/14] ArmPkg: Allow FF-A calls to set " Sughosh Ganu
2021-02-19 6:36 ` [PATCH v5 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd Sughosh Ganu
2021-02-19 6:36 ` [PATCH v5 14/14] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm Sughosh Ganu
2021-02-22 14:10 ` [PATCH v5 00/14] Add support for using FF-A calls Ard Biesheuvel
2021-02-22 15:19 ` Sughosh Ganu
2021-02-23 16:04 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXEzLXvA2FkYgwbsJ3jF5UdTUrRANJP9HKFAj1sBZ8Z_MQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox